linux-toradex.git/include/linux/hid.h, branch v5.19-rc3

HID: input: accommodate priorities for slotted devices

2022-03-01T14:46:03+00:00

Multitouch devices in hybrid mode are reporting multiple times the
same collection. We should accommodate for this in our handling
of priorities by defining the slots they belong to.

Signed-off-by: Benjamin Tissoires 
Reviewed-by: Ping Cheng 
Acked-by: Peter Hutterer 
Signed-off-by: Jiri Kosina

HID: input: remove the need for HID_QUIRK_INVERT

2022-03-01T14:46:03+00:00

HID_QUIRK_INVERT is kind of complex to deal with and was bogus.

Furthermore, it didn't make sense to use a global per struct hid_device
quirk for something dynamic as the current state.

Store the current tool information in the report itself, and re-order
the processing of the fields to enforce having all the tablet "state"
fields before getting to In Range and other input fields.

This way, we now have all the information whether a tool is present
or not while processing In Range.

This new behavior enforces that only one tool gets forwarded to userspace
at the same time, and that if either eraser or invert is set, we enforce
BTN_TOOL_RUBBER.

Note that the release of the previous tool now happens in its own EV_SYN
report so userspace doesn't get confused by having 2 tools.

These changes are tested in the following hid-tools regression tests:
https://gitlab.freedesktop.org/libevdev/hid-tools/-/merge_requests/127

Signed-off-by: Benjamin Tissoires 
Reviewed-by: Ping Cheng 
Acked-by: Peter Hutterer 
Signed-off-by: Jiri Kosina

HID: input: enforce Invert usage to be processed before InRange

2022-03-01T14:46:03+00:00

When a device exposes both Invert and InRange, Invert must be processed
before InRange. If we keep the order of the device and we process them
out of order, InRange will first set BTN_TOOL_PEN, and then Invert will
set BTN_TOOL_RUBBER. Userspace knows how to deal with that situation,
but fixing it in the kernel is now easier.

Signed-off-by: Benjamin Tissoires 
Reviewed-by: Ping Cheng 
Acked-by: Peter Hutterer 
Signed-off-by: Jiri Kosina

HID: compute an ordered list of input fields to process

2022-03-01T14:46:02+00:00

This will be used in a later commit:
we build a list of input fields (and usage_index) that is ordered based
on a usage priority.

Changing the usage priority allows to re-order the processed list, meaning
that we can enforce some usages to be process before others.

For instance, before processing InRange in the HID tablets, we need to
know if we are using the eraser (side or button). Enforcing a higher
(lower number) priority for Invert allows to force the input stack to
process that field before.

Signed-off-by: Benjamin Tissoires 
Reviewed-by: Ping Cheng 
Acked-by: Peter Hutterer 
Signed-off-by: Jiri Kosina

HID: core: split data fetching from processing in hid_input_field()

2022-03-01T14:46:02+00:00

This is a preparatory patch for being able to process the usages
out of order. We split the retrieval of the data in a separate function
and also split out the processing of the usages depending if the field
is an array or a variable.

No functional changes from this patch.

Signed-off-by: Benjamin Tissoires 
Reviewed-by: Ping Cheng 
Acked-by: Peter Hutterer 
Signed-off-by: Jiri Kosina

HID: core: statically allocate read buffers

2022-03-01T14:46:02+00:00

This is a preparation patch for rethinking the generic processing
of HID reports.

We can actually pre-allocate all of our memory instead of dynamically
allocating/freeing it whenever we parse a report.

Signed-off-by: Benjamin Tissoires 
Reviewed-by: Ping Cheng 
Acked-by: Peter Hutterer 
Signed-off-by: Jiri Kosina

Merge branch 'for-5.17/core' into for-linus

2022-01-10T08:49:13+00:00

- support for USI style pens (Tero Kristo, Mika Westerberg)
- quirk for devices that need inverted X/Y axes (Alistair Francis)
- small core code cleanups and deduplication (Benjamin Tissoires)

HID: address kernel-doc warnings

2022-01-06T14:39:43+00:00

The command ./scripts/kernel-doc -none include/linux/hid.h reports:

  include/linux/hid.h:818: warning: cannot understand function prototype: 'struct hid_ll_driver '
  include/linux/hid.h:1135: warning: expecting prototype for hid_may_wakeup(). Prototype was for hid_hw_may_wakeup() instead

Address those kernel-doc warnings.

Signed-off-by: Lukas Bulwahn 
Signed-off-by: Jiri Kosina

HID: quirks: Allow inverting the absolute X/Y values

2021-12-14T10:37:52+00:00

Add a HID_QUIRK_X_INVERT/HID_QUIRK_Y_INVERT quirk that can be used
to invert the X/Y values.

Signed-off-by: Alistair Francis 
[bentiss: silence checkpatch warning]
Signed-off-by: Benjamin Tissoires 
Link: https://lore.kernel.org/r/20211208124045.61815-2-alistair@alistair23.me

HID: input: Make hidinput_find_field() static

2021-12-14T09:08:45+00:00

This function is not called outside of hid-input.c so we can make it
static.

Signed-off-by: Mika Westerberg 
Reviewed-by: Benjamin Tissoires 
Signed-off-by: Tero Kristo 
Signed-off-by: Benjamin Tissoires 
Link: https://lore.kernel.org/r/20211210111138.1248187-5-tero.kristo@linux.intel.com