linux-toradex.git/include/linux/i3c/device.h, branch v6.14-rc3

i3c: fix kdoc parameter description for module_i3c_i2c_driver()

2025-01-12T22:49:23+00:00

A typo mentioned I3C when it should have been I2C.

Signed-off-by: Wolfram Sang 
Reviewed-by: Geert Uytterhoeven 
Link: https://lore.kernel.org/r/20241219220338.10315-1-wsa+renesas@sang-engineering.com
Signed-off-by: Alexandre Belloni

driver core: have match() callback in struct bus_type take a const *

2024-07-03T13:16:54+00:00

In the match() callback, the struct device_driver * should not be
changed, so change the function callback to be a const *.  This is one
step of many towards making the driver core safe to have struct
device_driver in read-only memory.

Because the match() callback is in all busses, all busses are modified
to handle this properly.  This does entail switching some container_of()
calls to container_of_const() to properly handle the constant *.

For some busses, like PCI and USB and HV, the const * is cast away in
the match callback as those busses do want to modify those structures at
this point in time (they have a local lock in the driver structure.)
That will have to be changed in the future if they wish to have their
struct device * in read-only-memory.

Cc: Rafael J. Wysocki 
Reviewed-by: Alex Elder 
Acked-by: Sumit Garg 
Link: https://lore.kernel.org/r/2024070136-wrongdoer-busily-01e8@gregkh
Signed-off-by: Greg Kroah-Hartman

i3c: add actual_len in i3c_priv_xfer

2024-01-07T23:49:20+00:00

In MIPI I3C Specification:

"Ninth Bit of SDR Target Returned (Read) Data as End-of-Data: In I2C, the
ninth Data bit from Target to Controller is an ACK by the Controller. By
contrast, in I3C this bit allows the Target to end a Read, and allows the
Controller to Abort a Read. In SDR terms, the ninth bit of Read data is
referred to as the T-Bit (for ‘Transition’)"

I3C allow devices early terminate data transfer. So need "actual_len" field
to indicate how much get by i3c_priv_xfer.

Reviewed-by: Miquel Raynal 
Signed-off-by: Frank Li 
Link: https://lore.kernel.org/r/20231201222532.2431484-4-Frank.Li@nxp.com
Signed-off-by: Alexandre Belloni

i3c: Fix typo "Provisional ID" to "Provisioned ID"

2023-10-10T10:11:13+00:00

The MIPI I3C spec refers to a Provisioned ID, since it is (sometimes)
provisioned at device manufacturing.

Signed-off-by: Matt Johnston 
Acked-by: Rob Herring 
Reviewed-by: Miquel Raynal 
Link: https://lore.kernel.org/r/20231003075339.197099-1-matt@codeconstruct.com.au
Signed-off-by: Alexandre Belloni

i3c: fix device.h kernel-doc warnings

2023-02-16T12:42:22+00:00

Fix all kernel-doc warnings in :

include/linux/i3c/device.h:27: warning: contents before sections
include/linux/i3c/device.h:196: warning: Excess function parameter 'dev' description in 'dev_to_i3cdev'

Fixes: fa838c8ce537 ("i3c: move dev_to_i3cdev() to use container_of_const()")
Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure")
Signed-off-by: Randy Dunlap 
Cc: Boris Brezillon 
Cc: Greg Kroah-Hartman 
Cc: Alexandre Belloni 
Cc: linux-i3c@lists.infradead.org
Link: https://lore.kernel.org/r/20230213070324.1564-1-rdunlap@infradead.org
Signed-off-by: Greg Kroah-Hartman

driver core: make struct device_type.uevent() take a const *

2023-01-27T12:45:36+00:00

The uevent() callback in struct device_type should not be modifying the
device that is passed into it, so mark it as a const * and propagate the
function signature changes out into all relevant subsystems that use
this callback.

Cc: Alan Stern 
Cc: Andreas Noever 
Cc: Andy Shevchenko 
Cc: Bard Liao 
Cc: Chaitanya Kulkarni 
Cc: Dan Williams 
Cc: Dmitry Torokhov 
Cc: Frank Rowand 
Cc: Ira Weiny 
Cc: Jason Gunthorpe 
Cc: Jens Axboe 
Cc: Jilin Yuan 
Cc: Jiri Slaby 
Cc: Len Brown 
Cc: Mark Gross 
Cc: "Martin K. Petersen" 
Cc: "Matthew Wilcox (Oracle)" 
Cc: Maximilian Luz 
Cc: Michael Jamet 
Cc: Ming Lei 
Cc: Pierre-Louis Bossart 
Cc: Rob Herring 
Cc: Sakari Ailus 
Cc: Sanyog Kale 
Cc: Sean Young 
Cc: Stefan Richter 
Cc: Thomas Gleixner 
Cc: Won Chung 
Cc: Yehezkel Bernat 
Acked-by: Rafael J. Wysocki 
Acked-by: Mika Westerberg  # for Thunderbolt
Acked-by: Mauro Carvalho Chehab 
Acked-by: Alexandre Belloni 
Acked-by: Heikki Krogerus 
Acked-by: Wolfram Sang 
Acked-by: Vinod Koul 
Acked-by: Hans de Goede 
Link: https://lore.kernel.org/r/20230111113018.459199-6-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman

i3c: move dev_to_i3cdev() to use container_of_const()

2023-01-27T12:45:32+00:00

The driver core is changing to pass some pointers as const, so move
dev_to_i3cdev() to use container_of_const() to handle this change.
dev_to_i3cdev() now properly keeps the const-ness of the pointer passed
into it, while as before it could be lost.

Acked-by: Alexandre Belloni 
Acked-by: Hans de Goede 
Link: https://lore.kernel.org/r/20230111113018.459199-3-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman

i3c: export SETDASA method

2022-12-11T20:25:58+00:00

Because not all I3C drivers have the hot-join feature ready, and
especially not all I3C devices support hot-join feature, exporting
SETDASA method could be useful. With this function, the I3C controller
could perform a DAA to I3C devices when users decide to turn these I3C
devices off and on again during run-time.

Tested: This change has been tested with turnning off an I3C device and
turning on it again during run-time. The device driver calls SETDASA
method to perform DAA to the device. And communication between I3C
controller and device is set up again correctly.

Signed-off-by: Jack Chen 
Link: https://lore.kernel.org/r/20221207205059.3848851-1-zenghuchen@google.com
Signed-off-by: Alexandre Belloni

i3c: Correct the macro module_i3c_i2c_driver

2022-12-11T20:20:27+00:00

Present definition for module_i3c_i2c_driver uses only the
1st argument i.e., struct i3c_driver.
Irrespective of CONFIG_I3C being enabled/disabled,
struct i2c_driver is never passed to module_driver()

Passing struct i2c_driver as the 4th argument works.

Signed-off-by: Akshay Gupta 
Signed-off-by: Naveen Krishna Chatradhi 
Link: https://lore.kernel.org/r/20221205105413.937704-1-naveenkrishna.chatradhi@amd.com
Signed-off-by: Alexandre Belloni

i3c: Make remove callback return void

2021-02-01T23:16:57+00:00

The driver core ignores the return value of struct bus_type::remove()
because there is only little that can be done. To simplify the quest to
make this function return void, let struct i3c_driver::remove() return
void, too. This makes it obvious that returning an error code is
a bad idea and future driver authors cannot get that wrong.

Up to now there are no drivers with a remove callback, so there is no
need to adapt drivers.

Signed-off-by: Uwe Kleine-König 
Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20210128091048.17006-2-u.kleine-koenig@pengutronix.de