linux-toradex.git/include/linux/ipmi_smi.h, branch v2.6.36-rc5

ipmi: remove ipmi_smi.h self-include

2010-03-12T23:52:40+00:00

There is no need for linux/ipmi_smi.h to include itself.

Signed-off-by: Corey Minyard 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

proc 2/2: remove struct proc_dir_entry::owner

2009-03-30T21:14:44+00:00

Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy
as correctly noted at bug #12454. Someone can lookup entry with NULL
->owner, thus not pinning enything, and release it later resulting
in module refcount underflow.

We can keep ->owner and supply it at registration time like ->proc_fops
and ->data.

But this leaves ->owner as easy-manipulative field (just one C assignment)
and somebody will forget to unpin previous/pin current module when
switching ->owner. ->proc_fops is declared as "const" which should give
some thoughts.

->read_proc/->write_proc were just fixed to not require ->owner for
protection.

rmmod'ed directories will be empty and return "." and ".." -- no harm.
And directories with tricky enough readdir and lookup shouldn't be modular.
We definitely don't want such modular code.

Removing ->owner will also make PDE smaller.

So, let's nuke it.

Kudos to Jeff Layton for reminding about this, let's say, oversight.

http://bugzilla.kernel.org/show_bug.cgi?id=12454

Signed-off-by: Alexey Dobriyan

ipmi: remove ->write_proc code

2008-04-29T15:06:15+00:00

IPMI code theoretically allows ->write_proc users, but nobody uses this thus
far.

Signed-off-by: Alexey Dobriyan 
Acked-by: Corey Minyard 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ipmi: style fixes in the base code

2008-04-29T15:06:15+00:00

Lots of style fixes for the base IPMI driver.  No functional changes.
Basically fixes everything reported by checkpatch and fixes the comment
style.

Signed-off-by: Corey Minyard 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

IPMI: fix comparison in demangle_device_id

2007-10-30T15:06:55+00:00

Coverity spotted some incorrect code in a recent change to the IPMI driver;
this patch make sure the data is really long enough to pull the
manufacturer id and product id out of a get device id message.

Signed-off-by: Corey Minyard 
Cc: Adrian Bunk 
Cc: Stian Jordet 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Fix misspellings of "system", "controller", "interrupt" and "necessary".

2007-10-19T21:10:43+00:00

Fix the various misspellings of "system", controller", "interrupt" and
"[un]necessary".

Signed-off-by: Robert P. J. Day 
Signed-off-by: Adrian Bunk

IPMI: add 0.9 support

2007-10-18T21:37:32+00:00

Add support for IPMI 0.9 systems to the IPMI driver.  Just handle a shorter
get device ID command with less information.

Signed-off-by: Corey Minyard 
Cc: Stian Jordet 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] IPMI: Add maintenance mode

2006-12-07T16:39:47+00:00

Some commands and operations on a BMC can cause the BMC to "go away" for a
while.  This can cause the automatic flag processing and other things of that
nature to timeout and generate annoying logs, or possibly cause other bad
things to happen when in firmware update mode.

Add detection of those commands (cold reset, warm reset, and any firmware
command) and turns off automatic processing for 30 seconds.  It also add a
manual override either way.

Signed-off-by: Corey Minyard 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] IPMI: pass sysfs name from lower level driver

2006-12-07T16:39:47+00:00

Pass in the sysfs name from the lower-level IPMI driver, as the coming IPMI
serial driver will need that to link properly from the serial device sysfs
directory.

Signed-off-by: Corey Minyard 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] IPMI: fix startup race condition

2006-03-31T20:18:54+00:00

Matt Domsch noticed a startup race with the IPMI kernel thread, it was
possible (though extraordinarly unlikely) that a message could come in
before the upper layer was ready to handle it.  This patch splits the
startup processing of an IPMI interface into two parts, one to get ready
and one to actually start the processes to receive messages from the
interface.

[akpm@osdl.org: cleanups]
Signed-off-by: Corey Minyard 
Cc: Matt Domsch 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds