linux-toradex.git/include/linux/lcm.h, branch T20_LinuxImageV2.0Beta1_20121218 Linux kernel for Apalis and Colibri modules block: Fix overrun in lcm() and move it to lib 2010-03-15T11:47:59+00:00 Martin K. Petersen martin.petersen@oracle.com 2010-03-15T11:46:51+00:00 2cda2728aa1c8c006418a24f867b25e5eb7a32e2 lcm() was defined to take integer-sized arguments. The supplied arguments are multiplied, however, causing us to overflow given sufficiently large input. That in turn led to incorrect optimal I/O size reporting in some cases (RAID over RAID). Switch lcm() over to unsigned long similar to gcd() and move the function from blk-settings.c to lib. Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Jens Axboe <jens.axboe@oracle.com> 
lcm() was defined to take integer-sized arguments.  The supplied
arguments are multiplied, however, causing us to overflow given
sufficiently large input.  That in turn led to incorrect optimal I/O
size reporting in some cases (RAID over RAID).

Switch lcm() over to unsigned long similar to gcd() and move the
function from blk-settings.c to lib.

Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>