linux-toradex.git/include/linux/mfd/cros_ec.h, branch v4.1.14

mfd: cros_ec: Add char dev and virtual dev pointers

2015-02-26T23:44:58+00:00

The ChromeOS Embedded Controller has to be accessed by applications.
A virtual character device is used as an interface with user-space.

Extend the struct cros_ec_device with the fields needed by the driver
of this virtual character device.

Signed-off-by: Javier Martinez Canillas 
Acked-by: Lee Jones 
Tested-by: Gwendal Grignou 
Reviewed-by: Gwendal Grignou 
Signed-off-by: Olof Johansson

mfd: cros_ec: Use fixed size arrays to transfer data with the EC

2015-02-26T23:44:52+00:00

The struct cros_ec_command will be used as an ioctl() argument for the
API to control the ChromeOS EC from user-space. So the data structure
has to be 64-bit safe to make it compatible between 32 and 64 avoiding
the need for a compat ioctl interface. Since pointers are self-aligned
to different byte boundaries, use fixed size arrays instead of pointers
for transferring ingoing and outgoing data with the Embedded Controller.

Also, re-arrange struct members by decreasing alignment requirements to
reduce the needing padding size.

Signed-off-by: Javier Martinez Canillas 
Acked-by: Lee Jones 
Tested-by: Gwendal Grignou 
Reviewed-by: Gwendal Grignou 
Signed-off-by: Olof Johansson

mfd: cros_ec: stop calling ->cmd_xfer() directly

2014-10-06T20:29:07+00:00

Instead of having users of the ChromeOS EC call the interface-specific
cmd_xfer() callback directly, introduce a central cros_ec_cmd_xfer()
to use instead.  This will allow us to put all the locking and retry
logic in one place instead of duplicating it across the different
drivers.

Signed-off-by: Andrew Bresticker 
Reviewed-by: Simon Glass 
Signed-off-by: Javier Martinez Canillas 
Reviewed-by: Doug Anderson 
Signed-off-by: Lee Jones

mfd: cros_ec: Move EC interrupt to cros_ec_keyb

2014-07-09T13:58:20+00:00

If we receive EC interrupts after the cros_ec driver has probed, but
before the cros_ec_keyb driver has probed, the cros_ec IRQ handler
will not run the cros_ec_keyb notifier and the EC will leave the IRQ
line asserted.  The cros_ec IRQ handler then returns IRQ_HANDLED and
the resulting flood of interrupts causes the machine to hang.

Since the EC interrupt is currently only used for the keyboard, move
the setup and handling of the EC interrupt to the cros_ec_keyb driver.

Signed-off-by: Andrew Bresticker 
Signed-off-by: Doug Anderson 
Acked-by: Dmitry Torokhov 
Signed-off-by: Lee Jones

mfd: cros_ec: ec_dev->cmd_xfer() returns number of bytes received from EC

2014-07-09T13:58:20+00:00

When communicating with the EC, the cmd_xfer() function should return the
number of bytes it received from the EC, or negative on error.

Signed-off-by: Bill Richardson 
Signed-off-by: Doug Anderson 
Reviewed-by: Simon Glass 
Acked-by: Wolfram Sang 
Signed-off-by: Lee Jones

mfd: cros_ec: Check result code from EC messages

2014-07-09T13:58:19+00:00

Just because the host was able to talk to the EC doesn't mean that the EC
was happy with what it was told. Errors in communincation are not the same
as error messages from the EC itself.

This change lets the EC report its errors separately.

[dianders: Added common function to cros_ec.c]

Signed-off-by: Bill Richardson 
Signed-off-by: Doug Anderson 
Signed-off-by: Lee Jones

mfd: cros_ec: cleanup: Remove EC wrapper functions

2014-07-09T13:58:18+00:00

Remove the three wrapper functions that talk to the EC without passing all
the desired arguments and just use the underlying communication function
that passes everything in a struct intead.

This is internal code refactoring only. Nothing should change.

Signed-off-by: Bill Richardson 
Signed-off-by: Doug Anderson 
Reviewed-by: Simon Glass 
Acked-by: Wolfram Sang 
Acked-by: Dmitry Torokhov 
Signed-off-by: Lee Jones

mfd: cros_ec: cleanup: remove unused fields from struct cros_ec_device

2014-07-09T13:58:18+00:00

struct cros_ec_device has a superfluous "name" field. We can get all the
debugging info we need from the existing ec_name and phys_name fields, so
let's take out the extra field.

The printout also has sufficient info in it without explicitly adding
the transport.  Before this change:
  cros-ec-spi spi2.0: Chrome EC (SPI)

After this change:
  cros-ec-spi spi2.0: Chrome EC device registered

Signed-off-by: Bill Richardson 
Signed-off-by: Doug Anderson 
Reviewed-by: Simon Glass 
Signed-off-by: Lee Jones

mfd: cros_ec: Use struct cros_ec_command to communicate with the EC

2014-07-09T13:58:17+00:00

This is some internal structure reorganization / renaming to prepare
for future patches that will add a userspace API to cros_ec.  There
should be no visible changes.

Signed-off-by: Bill Richardson 
Signed-off-by: Doug Anderson 
Signed-off-by: Lee Jones

mfd: cros_ec: Tweak struct cros_ec_device for clarity

2014-07-09T13:58:16+00:00

The members of struct cros_ec_device were improperly commented, and
intermixed the private and public sections. This is just cleanup to make it
more obvious what goes with what.

[dianders: left lock in the structure but gave it the name that will
eventually be used.]

Signed-off-by: Bill Richardson 
Signed-off-by: Doug Anderson 
Signed-off-by: Lee Jones