linux-toradex.git/include/linux/netpoll.h, branch v2.6.38.5

bonding: Fix bonding drivers improper modification of netpoll structure

2010-10-18T15:32:07+00:00

The bonding driver currently modifies the netpoll structure in its xmit path
while sending frames from netpoll.  This is racy, as other cpus can access the
netpoll structure in parallel. Since the bonding driver points np->dev to a
slave device, other cpus can inadvertently attempt to send data directly to
slave devices, leading to improper locking with the bonding master, lost frames,
and deadlocks.  This patch fixes that up.

This patch also removes the real_dev pointer from the netpoll structure as that
data is really only used by bonding in the poll_controller, and we can emulate
its behavior by check each slave for IS_UP.

Signed-off-by: Neil Horman 
Signed-off-by: David S. Miller

netpoll: Disable IRQ around RCU dereference in netpoll_rx

2010-09-17T23:55:03+00:00

We cannot use rcu_dereference_bh safely in netpoll_rx as we may
be called with IRQs disabled.  We could however simply disable
IRQs as that too causes BH to be disabled and is safe in either
case.

Thanks to John Linville for discovering this bug and providing
a patch.

Signed-off-by: Herbert Xu 
Signed-off-by: David S. Miller

net: make netpoll_rx return bool for !CONFIG_NETPOLL

2010-08-10T23:24:41+00:00

"netpoll: Use 'bool' for netpoll_rx() return type." missed the case when
CONFIG_NETPOLL is disabled.

Signed-off-by: John W. Linville 
Signed-off-by: David S. Miller

netpoll: Use correct primitives for RCU dereferencing

2010-06-16T04:44:29+00:00

Now that RCU debugging checks for matching rcu_dereference calls
and rcu_read_lock, we need to use the correct primitives or face
nasty warnings.

Signed-off-by: Herbert Xu 
Signed-off-by: David S. Miller

netpoll: Add netpoll_tx_running

2010-06-15T17:58:40+00:00

This patch adds the helper netpoll_tx_running for use within
ndo_start_xmit.  It returns non-zero if ndo_start_xmit is being
invoked by netpoll, and zero otherwise.

This is currently implemented by simply looking at the hardirq
count.  This is because for all non-netpoll uses of ndo_start_xmit,
IRQs must be enabled while netpoll always disables IRQs before
calling ndo_start_xmit.

Signed-off-by: Herbert Xu 
Signed-off-by: David S. Miller

netpoll: Allow netpoll_setup/cleanup recursion

2010-06-15T17:58:40+00:00

This patch adds the functions __netpoll_setup/__netpoll_cleanup
which is designed to be called recursively through ndo_netpoll_seutp.

They must be called with RTNL held, and the caller must initialise
np->dev and ensure that it has a valid reference count.

Signed-off-by: Herbert Xu 
Signed-off-by: David S. Miller

netpoll: Fix RCU usage

2010-06-15T17:58:38+00:00

The use of RCU in netpoll is incorrect in a number of places:

1) The initial setting is lacking a write barrier.
2) The synchronize_rcu is in the wrong place.
3) Read barriers are missing.
4) Some places are even missing rcu_read_lock.
5) npinfo is zeroed after freeing.

This patch fixes those issues.  As most users are in BH context,
this also converts the RCU usage to the BH variant.

Signed-off-by: Herbert Xu 
Acked-by: Paul E. McKenney 
Signed-off-by: David S. Miller

netpoll: Use 'bool' for netpoll_rx() return type.

2010-05-06T08:31:27+00:00

Signed-off-by: David S. Miller

netpoll: add generic support for bridge and bonding devices

2010-05-06T07:47:21+00:00

This whole patchset is for adding netpoll support to bridge and bonding
devices. I already tested it for bridge, bonding, bridge over bonding,
and bonding over bridge. It looks fine now.

To make bridge and bonding support netpoll, we need to adjust
some netpoll generic code. This patch does the following things:

1) introduce two new priv_flags for struct net_device:
   IFF_IN_NETPOLL which identifies we are processing a netpoll;
   IFF_DISABLE_NETPOLL is used to disable netpoll support for a device
   at run-time;

2) introduce one new method for netdev_ops:
   ->ndo_netpoll_cleanup() is used to clean up netpoll when a device is
     removed.

3) introduce netpoll_poll_dev() which takes a struct net_device * parameter;
   export netpoll_send_skb() and netpoll_poll_dev() which will be used later;

4) hide a pointer to struct netpoll in struct netpoll_info, ditto.

5) introduce ->real_dev for struct netpoll.

6) introduce a new status NETDEV_BONDING_DESLAE, which is used to disable
   netconsole before releasing a slave, to avoid deadlocks.

Cc: David Miller 
Cc: Neil Horman 
Signed-off-by: WANG Cong 
Signed-off-by: David S. Miller

netpoll: allow execution of multiple rx_hooks per interface

2010-01-14T04:38:26+00:00

Signed-off-by: Daniel Borkmann 
Signed-off-by: David S. Miller