linux-toradex.git/include/linux/nvme.h, branch v5.12-rc7

nvme: add tracing of zns commands

2021-02-02T09:26:12+00:00

When support for the NVMe ZNS commands was merged, tracing of these has
been omitted.

Add nvme_cmd_zone_mgmt_send, nvme_cmd_zone_mgmt_recv as well as
nvme_cmd_zone_append to the nvme driver's tracing facility.

Signed-off-by: Johannes Thumshirn 
Signed-off-by: Christoph Hellwig

nvme: update enumerations for status codes

2021-02-02T09:26:12+00:00

All the updates are mentioned in the ratified NVMe 1.4 spec.

Reviewed-by: Hannes Reinecke 
Signed-off-by: Max Gurtovoy 
Signed-off-by: Christoph Hellwig

nvme-pci: allow use of cmb on v1.4 controllers

2021-01-18T17:58:18+00:00

Since NVMe v1.4 the Controller Memory Buffer must be explicitly enabled
by the host.

Signed-off-by: Klaus Jensen 
[hch: avoid a local variable and add a comment]
Signed-off-by: Christoph Hellwig

nvmet: add passthru code to process commands

2020-07-29T05:45:21+00:00

Add passthru command handling capability for the NVMeOF target and
export passthru APIs which are used to integrate passthru
code with nvmet-core.

The new file passthru.c handles passthru cmd parsing and execution.
In the passthru mode, we create a block layer request from the nvmet
request and map the data on to the block layer request.

Admin commands and features are on an allow list as there are a number
of each that don't make too much sense with passthrough. We use an
allow list such that new commands can be considered before being blindly
passed through. In both cases, vendor specific commands are always
allowed.

We also reject reservation IO commands as the underlying device cannot
differentiate between multiple hosts behind a fabric.

Based-on-a-patch-by: Chaitanya Kulkarni 
Signed-off-by: Logan Gunthorpe 
Reviewed-by: Keith Busch 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Christoph Hellwig

nvme: support for zoned namespaces

2020-07-08T14:16:20+00:00

Add support for NVM Express Zoned Namespaces (ZNS) Command Set defined
in NVM Express TP4053. Zoned namespaces are discovered based on their
Command Set Identifier reported in the namespaces Namespace
Identification Descriptor list. A successfully discovered Zoned
Namespace will be registered with the block layer as a host managed
zoned block device with Zone Append command support. A namespace that
does not support append is not supported by the driver.

Reviewed-by: Martin K. Petersen 
Reviewed-by: Johannes Thumshirn 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Sagi Grimberg 
Reviewed-by: Javier González 
Reviewed-by: Himanshu Madhani 
Signed-off-by: Hans Holmberg 
Signed-off-by: Dmitry Fomichev 
Signed-off-by: Ajay Joshi 
Signed-off-by: Aravind Ramesh 
Signed-off-by: Niklas Cassel 
Signed-off-by: Matias Bjørling 
Signed-off-by: Damien Le Moal 
Signed-off-by: Keith Busch 
Signed-off-by: Christoph Hellwig

nvme: support for multiple Command Sets Supported and Effects log pages

2020-07-08T14:16:20+00:00

The Commands Supported and Effects log page was extended with a CSI
field that enables the host to query the log page for each command set
supported. Retrieve this log page for each command set that an attached
namespace supports, and save a pointer to that log in the namespace head.

Reviewed-by: Matias Bjørling 
Reviewed-by: Javier González 
Reviewed-by: Himanshu Madhani 
Reviewed-by: Martin K. Petersen 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Johannes Thumshirn 
Reviewed-by: Daniel Wagner 
Signed-off-by: Keith Busch 
Signed-off-by: Christoph Hellwig

nvme: implement multiple I/O Command Set support

2020-07-08T14:16:19+00:00

Implements support for multiple I/O Command Sets.  NVMe TP 4056
introduces a method to enumerate multiple command sets per namespace. If
the command set is exposed, this method for enumeration will be used
instead of the traditional method that uses the CC.CSS register command
set register for command set identification.

For namespaces where the Command Set Identifier is not supported or
recognized, the specific namespace will not be created.

Reviewed-by: Javier González 
Reviewed-by: Martin K. Petersen 
Reviewed-by: Johannes Thumshirn 
Reviewed-by: Matias Bjørling 
Reviewed-by: Daniel Wagner 
Reviewed-by: Himanshu Madhani 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Niklas Cassel 
Signed-off-by: Christoph Hellwig

nvme: add Metadata Capabilities enumerations

2020-05-27T05:12:40+00:00

The enumerations will be used to expose the namespace metadata format by
the target.

Suggested-by: Christoph Hellwig 
Signed-off-by: Israel Rukshin 
Signed-off-by: Max Gurtovoy 
Reviewed-by: James Smart 
Reviewed-by: Martin K. Petersen 
Signed-off-by: Christoph Hellwig

nvme: replace zero-length array with flexible-array

2020-05-27T05:12:37+00:00

The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.

Also, notice that, dynamic memory allocations won't be affected by
this change:

"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]

sizeof(flexible-array-member) triggers a warning because flexible array
members have incomplete type[1]. There are some instances of code in
which the sizeof operator is being incorrectly/erroneously applied to
zero-length arrays and the result is zero. Such instances may be hiding
some bugs. So, this work (flexible-array member conversions) will also
help to get completely rid of those sorts of issues.

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")

Signed-off-by: Gustavo A. R. Silva 
Signed-off-by: Christoph Hellwig

nvme: define constants for identification values

2020-05-09T22:18:36+00:00

Improve code readability by defining the specification's constants that
the driver is using when decoding identification payloads.

Signed-off-by: Keith Busch 
Reviewed-by: Bart van Assche 
Reviewed-by: Chaitanya Kulkarni 
Acked-by: Sagi Grimberg 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe