linux-toradex.git/include/linux/phy.h, branch v2.6.26-rc5

phylib: Fix some sparse warnings

2008-05-06T16:01:41+00:00

Declared some things static, declared some things in the header.

Signed-off-by: Andy Fleming 
Signed-off-by: Jeff Garzik

phylib: Add support for board-level PHY fixups

2008-04-25T06:08:52+00:00

Sometimes the specific interaction between the platform and the PHY
requires special handling.  For instance, to change where the PHY's
clock input is, or to add a delay to account for latency issues in the
data path.  We add a mechanism for registering a callback with the PHY
Lib to be called on matching PHYs when they are brought up, or reset.

Signed-off-by: Andy Fleming 
Signed-off-by: Jeff Garzik

phylib: factor out get_phy_id from within get_phy_device

2008-04-17T19:31:33+00:00

We were already doing what amounts to a get_phy_id from within
get_phy_device, and rather than duplicate this for the TBIPA
probing, we might as well just factor it out and make it available
instead.

Signed-off-by: Paul Gortmaker 
Acked-by: Andy Fleming 
Signed-off-by: Jeff Garzik

phy: Clean up header style

2008-04-17T00:09:35+00:00

Multi-line comments weren't all CodingStyle compliant

Signed-off-by: Andy Fleming 
Signed-off-by: Jeff Garzik

phy: Change mii_bus id field to a string

2008-04-17T00:09:35+00:00

Having the id field be an int was making more complex bus topologies
excessively difficult.  For now, just convert it to a string, and
change all instances of "bus->id = val" to
snprintf(id, MII_BUS_ID_LEN, "%x", val).

Signed-off-by: Andy Fleming 
Signed-off-by: Jeff Garzik

PHYLIB: Locking fixes for PHY I/O potentially sleeping

2008-02-03T12:28:41+00:00

PHY read/write functions can potentially sleep (e.g., a PHY accessed
via I2C).  The following changes were made to account for this:

    * Change spin locks to mutex locks
    * Add a BUG_ON() to phy_read() phy_write() to warn against
      calling them from an interrupt context.
    * Use work queue for PHY state machine handling since
      it can potentially sleep
    * Change phydev lock from spinlock to mutex

Signed-off-by: Nate Case 
Acked-by: Andy Fleming 
Signed-off-by: Jeff Garzik 
Signed-off-by: David S. Miller

PHY: Add the phy_device_release device method.

2007-12-04T20:06:33+00:00

Lately I've got this nice badness on mdio bus removal:

Device 'e0103120:06' does not have a release() function, it is broken and must be fixed.
------------[ cut here ]------------
Badness at drivers/base/core.c:107
NIP: c015c1a8 LR: c015c1a8 CTR: c0157488
REGS: c34bdcf0 TRAP: 0700   Not tainted  (2.6.23-rc5-g9ebadfbb-dirty)
MSR: 00029032   CR: 24088422  XER: 00000000
...
[c34bdda0] [c015c1a8] device_release+0x78/0x80 (unreliable)
[c34bddb0] [c01354cc] kobject_cleanup+0x80/0xbc
[c34bddd0] [c01365f0] kref_put+0x54/0x6c
[c34bdde0] [c013543c] kobject_put+0x24/0x34
[c34bddf0] [c015c384] put_device+0x1c/0x2c
[c34bde00] [c0180e84] mdiobus_unregister+0x2c/0x58
...

Though actually there is nothing broken, it just device
subsystem core expects another "pattern" of resource managment.

This patch implement phy device's release function, thus
we're getting rid of this badness.

Also small hidden bug fixed, hope none other introduced. ;-)

Signed-off-by: Anton Vorontsov 
Acked-by: Andy Fleming 
Signed-off-by: Jeff Garzik

phylib: add PHY interface modes for internal delay for tx and rx only

2007-12-01T21:32:30+00:00

Allow phylib specification of cases where hardware needs to configure
PHYs for Internal Delay only on either RX or TX (not both).

Signed-off-by: Kim Phillips 
Tested-by: Anton Vorontsov 
Acked-by: Li Yang 
Signed-off-by: Jeff Garzik

PHYLIB: IRQ event workqueue handling fixes

2007-10-10T23:53:55+00:00

Keep track of disable_irq_nosync() invocations and call enable_irq() the
right number of times if work has been cancelled that would include them.

Now that the call to flush_work_keventd() (problematic because of
rtnl_mutex being held) has been replaced by cancel_work_sync() another
issue has arisen and been left unresolved.  As the MDIO bus cannot be
accessed from the interrupt context the PHY interrupt handler uses
disable_irq_nosync() to prevent from looping and schedules some work to be
done as a softirq, which, apart from handling the state change of the
originating PHY, is responsible for reenabling the interrupt.  Now if the
interrupt line is shared by another device and a call to the softirq
handler has been cancelled, that call to enable_irq() never happens and the
other device cannot use its interrupt anymore as its stuck disabled.

I decided to use a counter rather than a flag because there may be more
than one call to phy_change() cancelled in the queue -- a real one and a
fake one triggered by free_irq() if DEBUG_SHIRQ is used, if nothing else.
Therefore because of its nesting property enable_irq() has to be called the
right number of times to match the number disable_irq_nosync() was called
and restore the original state.  This DEBUG_SHIRQ feature is also the
reason why free_irq() has to be called before cancel_work_sync().

While at it I updated the comment about phy_stop_interrupts() being called
from `keventd' -- this is no longer relevant as the use of
cancel_work_sync() makes such an approach unnecessary.  OTOH a similar
comment referring to flush_scheduled_work() in phy_stop() still applies as
using cancel_work_sync() there would be dangerous.

Checked with checkpatch.pl and at the run time (with and without
DEBUG_SHIRQ).

Signed-off-by: Maciej W. Rozycki 
Cc: Andy Fleming 
Cc: Jeff Garzik 
Signed-off-by: Andrew Morton 
Signed-off-by: Jeff Garzik

phylib: add RGMII-ID interface mode definition

2007-04-28T15:01:04+00:00

The RGMII spec allows compliance for devices that implement an internal
delay on TXC or RXC inside the transmitter.  This patch adds an RGMII_ID
definition to support RGMII-ID devices in the phylib.

Signed-off-by: Kim Phillips 
Signed-off-by: Jeff Garzik