linux-toradex.git/include/linux/posix_acl.h, branch v3.4.73 Linux kernel for Apalis and Colibri modules BUG: headers with BUG/BUG_ON etc. need linux/bug.h 2012-03-04T22:54:34+00:00 Paul Gortmaker paul.gortmaker@windriver.com 2011-11-24T01:12:59+00:00 187f1882b5b0748b3c4c22274663fdb372ac0452 If a header file is making use of BUG, BUG_ON, BUILD_BUG_ON, or any other BUG variant in a static inline (i.e. not in a #define) then that header really should be including <linux/bug.h> and not just expecting it to be implicitly present. We can make this change risk-free, since if the files using these headers didn't have exposure to linux/bug.h already, they would have been causing compile failures/warnings. Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> 
If a header file is making use of BUG, BUG_ON, BUILD_BUG_ON, or any
other BUG variant in a static inline (i.e. not in a #define) then
that header really should be including <linux/bug.h> and not just
expecting it to be implicitly present.

We can make this change risk-free, since if the files using these
headers didn't have exposure to linux/bug.h already, they would have
been causing compile failures/warnings.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
RCUify freeing acls, let check_acl() go ahead in RCU mode if acl is cached 2011-08-03T04:58:42+00:00 Al Viro viro@zeniv.linux.org.uk 2011-08-03T01:32:13+00:00 3567866bf26190d1e734c975c907eb06e923ba23 Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> 
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
get rid of boilerplate switches in posix_acl.h 2011-08-03T04:47:21+00:00 Al Viro viro@zeniv.linux.org.uk 2011-08-03T04:47:21+00:00 951c0d660a7c35286e401ca6d6ef38c9d49643c7 the only potentially subtle thing here: get_cached_acl() is never called with the second argument other than ACL_TYPE_{ACCESS,DEFAULT}. IOW, that return ERR_PTR(-EINVAL) in there might as well be BUG(). Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> 
the only potentially subtle thing here: get_cached_acl()
is never called with the second argument other than
ACL_TYPE_{ACCESS,DEFAULT}.  IOW, that return ERR_PTR(-EINVAL)
in there might as well be BUG().

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
switch posix_acl_chmod() to umode_t 2011-08-01T06:10:32+00:00 Al Viro viro@zeniv.linux.org.uk 2011-07-23T23:03:11+00:00 86bc704db0ab7e69230f79bc7d124e063259abc6 again, that's what all callers pass to it Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> 
again, that's what all callers pass to it

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
switch posix_acl_from_mode() to umode_t 2011-08-01T06:10:20+00:00 Al Viro viro@zeniv.linux.org.uk 2011-07-23T23:01:48+00:00 3a5fba19b080b365d67866db38e32e6a4a2089e8 ... seeing that this is what all callers pass to it anyway. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> 
... seeing that this is what all callers pass to it anyway.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
switch posix_acl_equiv_mode() to umode_t * 2011-08-01T06:10:06+00:00 Al Viro viro@zeniv.linux.org.uk 2011-07-23T22:56:36+00:00 d6952123b53cc8b334df69bba2cd0063b0d88f68 ... so that &inode->i_mode could be passed to it Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> 
... so that &inode->i_mode could be passed to it

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
switch posix_acl_create() to umode_t * 2011-08-01T06:09:42+00:00 Al Viro viro@zeniv.linux.org.uk 2011-07-23T22:37:50+00:00 d3fb612076eebec6f67257db0c7a9666ac7e5892 so we can pass &inode->i_mode to it Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> 
so we can pass &inode->i_mode to it

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
bury posix_acl_..._masq() variants 2011-07-25T18:27:32+00:00 Al Viro viro@zeniv.linux.org.uk 2011-07-23T07:27:37+00:00 edde854e8bb34a7f32fa993d721f1da0faf64165 made static; no callers left outside of posix_acl.c. posix_acl_clone() also has lost all external callers and became static... Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> 
made static; no callers left outside of posix_acl.c.  posix_acl_clone() also
has lost all external callers and became static...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
kill boilerplates around posix_acl_create_masq() 2011-07-25T18:27:32+00:00 Al Viro viro@zeniv.linux.org.uk 2011-07-23T07:10:32+00:00 826cae2f2b4d726b925f43bc208a571639da4761 new helper: posix_acl_create(&acl, gfp, mode_p). Replaces acl with modified clone, on failure releases acl and replaces with NULL. Returns 0 or -ve on error. All callers of posix_acl_create_masq() switched. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> 
new helper: posix_acl_create(&acl, gfp, mode_p).  Replaces acl with
modified clone, on failure releases acl and replaces with NULL.
Returns 0 or -ve on error.  All callers of posix_acl_create_masq()
switched.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
kill boilerplate around posix_acl_chmod_masq() 2011-07-25T18:27:30+00:00 Al Viro viro@zeniv.linux.org.uk 2011-07-23T04:18:02+00:00 bc26ab5f65ae41b71df86ea46df3c3833d1d8d83 new helper: posix_acl_chmod(&acl, gfp, mode). Replaces acl with modified clone or with NULL if that has failed; returns 0 or -ve on error. All callers of posix_acl_chmod_masq() switched to that - they'd been doing exactly the same thing. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> 
new helper: posix_acl_chmod(&acl, gfp, mode).  Replaces acl with modified
clone or with NULL if that has failed; returns 0 or -ve on error.  All
callers of posix_acl_chmod_masq() switched to that - they'd been doing
exactly the same thing.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>