linux-toradex.git/include/linux/pse-pd, branch v6.16-rc6

net: pse-pd: Clean ethtool header of PSE structures

2025-01-14T12:56:33+00:00

Remove PSE-specific structures from the ethtool header to improve code
modularity, maintain independent headers, and reduce incremental build
time.

Signed-off-by: Kory Maincent 
Signed-off-by: Paolo Abeni

net: pse-pd: Remove is_enabled callback from drivers

2025-01-14T12:56:32+00:00

The is_enabled callback is now redundant as the admin_state can be obtained
directly from the driver and provides the same information.

To simplify functionality, the core will handle this internally, making
the is_enabled callback unnecessary at the driver level. Remove the
callback from all drivers.

Acked-by: Oleksij Rempel 
Signed-off-by: Kory Maincent 
Signed-off-by: Paolo Abeni

net: pse-pd: Split ethtool_get_status into multiple callbacks

2025-01-14T12:56:32+00:00

The ethtool_get_status callback currently handles all status and PSE
information within a single function. This approach has two key
drawbacks:

1. If the core requires some information for purposes other than
   ethtool_get_status, redundant code will be needed to fetch the same
   data from the driver (like is_enabled).

2. Drivers currently have access to all information passed to ethtool.
   New variables will soon be added to ethtool status, such as PSE ID,
   power domain IDs, and budget evaluation strategies, which are meant
   to be managed solely by the core. Drivers should not have the ability
   to modify these variables.

To resolve these issues, ethtool_get_status has been split into multiple
callbacks, with each handling a specific piece of information required
by ethtool or the core.

Signed-off-by: Kory Maincent 
Signed-off-by: Paolo Abeni

net: pse-pd: Use power limit at driver side instead of current limit

2025-01-14T12:56:32+00:00

The regulator framework uses current limits, but the PSE standard and
known PSE controllers rely on power limits. Instead of converting
current to power within each driver, perform the conversion in the PSE
core. This avoids redundancy in driver implementation and aligns better
with the standard, simplifying driver development.

Remove at the same time the _pse_ethtool_get_status() function which is
not needed anymore.

Acked-by: Oleksij Rempel 
Signed-off-by: Kory Maincent 
Signed-off-by: Paolo Abeni

net: pse-pd: Add power limit check

2025-01-14T12:56:32+00:00

Checking only the current limit is not sufficient. According to the
standard, voltage can reach up to 57V and current up to 1.92A, which
exceeds the power limit described in the standard (99.9W). Add a power
limit check to prevent this.

Acked-by: Oleksij Rempel 
Signed-off-by: Kory Maincent 
Signed-off-by: Paolo Abeni

net: pse-pd: Remove unused pse_ethtool_get_pw_limit function declaration

2025-01-14T12:56:32+00:00

Removed the unused pse_ethtool_get_pw_limit() function declaration from
pse.h. This function was declared but never implemented or used,
making the declaration unnecessary.

Reviewed-by: Kalesh AP 
Reviewed-by: Andrew Lunn 
Acked-by: Oleksij Rempel 
Reviewed-by: Kyle Swenson 
Signed-off-by: Kory Maincent 
Signed-off-by: Paolo Abeni

net: pse-pd: Add new power limit get and set c33 features

2024-07-06T01:30:00+00:00

This patch add a way to get and set the power limit of a PSE PI.
For that it uses regulator API callbacks wrapper like get_voltage() and
get/set_current_limit() as power is simply V * I.
We used mW unit as defined by the IEEE 802.3-2022 standards.

set_current_limit() uses the voltage return by get_voltage() and the
desired power limit to calculate the current limit. get_voltage() callback
is then mandatory to set the power limit.

get_current_limit() callback is by default looking at a driver callback
and fallback to extracting the current limit from _pse_ethtool_get_status()
if the driver does not set its callback. We prefer let the user the choice
because ethtool_get_status return much more information than the current
limit.

expand pse status with c33_pw_limit_ranges to return the ranges available
to configure the power limit.

Reviewed-by: Sai Krishna 
Acked-by: Oleksij Rempel 
Signed-off-by: Kory Maincent 
Link: https://patch.msgid.link/20240704-feature_poe_power_cap-v6-4-320003204264@bootlin.com
Signed-off-by: Jakub Kicinski

net: ethtool: pse-pd: Expand C33 PSE status with class, power and extended state

2024-07-06T01:30:00+00:00

This update expands the status information provided by ethtool for PSE c33.
It includes details such as the detected class, current power delivered,
and extended state information.

Reviewed-by: Oleksij Rempel 
Signed-off-by: Kory Maincent 
Link: https://patch.msgid.link/20240704-feature_poe_power_cap-v6-1-320003204264@bootlin.com
Signed-off-by: Jakub Kicinski

net: pse-pd: Use EOPNOTSUPP error code instead of ENOTSUPP

2024-06-12T02:33:37+00:00

ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP as reported by
checkpatch script.

Fixes: 18ff0bcda6d1 ("ethtool: add interface to interact with Ethernet Power Equipment")
Reviewed-by: Andrew Lunn 
Acked-by: Oleksij Rempel 
Signed-off-by: Kory Maincent 
Link: https://lore.kernel.org/r/20240610083426.740660-1-kory.maincent@bootlin.com
Signed-off-by: Jakub Kicinski

net: pse-pd: Use regulator framework within PSE framework

2024-04-19T01:27:39+00:00

Integrate the regulator framework to the PSE framework for enhanced
access to features such as voltage, power measurement, and limits, which
are akin to regulators. Additionally, PSE features like port priorities
could potentially enhance the regulator framework. Note that this
integration introduces some implementation complexity, including wrapper
callbacks, but the potential benefits make it worthwhile.

Regulator are using enable counter with specific behavior.
Two calls to regulator_disable will trigger kernel warnings.
If the counter exceeds one, regulator_disable call won't disable the
PSE PI. These behavior isn't suitable for PSE control.
Added a boolean 'enabled' state to prevent multiple calls to
regulator_enable/disable. These calls will only be called from PSE
framework as it won't have any regulator children, therefore no mutex are
needed to safeguards this boolean.

regulator_get needs the consumer device pointer. Use PSE as regulator
provider and consumer device until we have RJ45 ports represented in
the Kernel.

Signed-off-by: Kory Maincent 
Reviewed-by: Andrew Lunn 
Link: https://lore.kernel.org/r/20240417-feature_poe-v9-10-242293fd1900@bootlin.com
Signed-off-by: Jakub Kicinski