linux-toradex.git/include/linux/qed, branch v6.17-rc6

net: qed: make 'qed_ll2_ops_pass' as __maybe_unused

2025-02-28T00:52:41+00:00

gcc warns about unused const variables even in header files when
building with W=1:

    In file included from include/linux/qed/qed_rdma_if.h:14,
                     from drivers/net/ethernet/qlogic/qed/qed_rdma.h:16,
                     from drivers/net/ethernet/qlogic/qed/qed_cxt.c:23:
    include/linux/qed/qed_ll2_if.h:270:33: error: 'qed_ll2_ops_pass' defined but not used [-Werror=unused-const-variable=]
      270 | static const struct qed_ll2_ops qed_ll2_ops_pass = {

This one is intentional, so mark it as __maybe_unused to it can be
included from a file that doesn't use this variable.

Signed-off-by: Arnd Bergmann 
Reviewed-by: Simon Horman 
Tested-by: Simon Horman  # build-tested
Link: https://patch.msgid.link/20250225200926.4057723-1-arnd@kernel.org
Signed-off-by: Jakub Kicinski

qed/qede: Remove unused declarations

2023-08-23T07:21:37+00:00

Commit 8cd160a29415 ("qede: convert to new udp_tunnel_nic infra")
removed qede_udp_tunnel_{add,del}() but not the declarations.
Commit 0ebcebbef1cc ("qed: Read device port count from the shmem")
removed qed_device_num_engines() but not its declaration.
Commit 1e128c81290a ("qed: Add support for hardware offloaded FCoE.")
declared but never implemented qed_fcoe_set_pf_params().

Signed-off-by: Yue Haibing 
Reviewed-by: Simon Horman 
Signed-off-by: David S. Miller

net: qed: fix typos in comments

2022-05-22T19:44:29+00:00

Spelling mistakes (triple letters) in comments.
Detected with the help of Coccinelle.

Signed-off-by: Julia Lawall 
Signed-off-by: David S. Miller

qed: Remove IP services API.

2022-04-22T22:15:23+00:00

qed_nvmetcp_ip_services.c and its corresponding header file were
introduced in commit 806ee7f81a2b ("qed: Add IP services APIs support")
but there's still no users for any of the functions they declare.
Since these files are effectively unused, let's just drop them.

Found by code inspection. Compile-tested only.

Signed-off-by: Guillaume Nault 
Link: https://lore.kernel.org/r/351ac8c847980e22850eb390553f8cc0e1ccd0ce.1650545051.git.gnault@redhat.com
Signed-off-by: Jakub Kicinski

qed*: esl priv flag support through ethtool

2021-12-04T02:24:21+00:00

ESL(Enhanced System Lockdown) was designed to lock PCI adapter firmware
images and prevent changes to critical non-volatile configuration data
so that uncontrolled, malicious or unintentional modification to the
adapters are avoided, ensuring it's operational state. Once this feature is
enabled, the device is locked, rejecting any modification to non-volatile
images. Once unlocked, the protection is off such that firmware and
non-volatile configurations may be altered.

Driver just reflects the capability and status of this through
the ethtool private flag.

Signed-off-by: Manish Chopra 
Signed-off-by: Prabhakar Kushwaha 
Signed-off-by: Alok Prasad 
Signed-off-by: Ariel Elior 
Signed-off-by: Jakub Kicinski

qed*: enhance tx timeout debug info

2021-12-04T02:24:20+00:00

This patch add some new qed APIs to query status block
info and report various data to MFW on tx timeout event

Along with that it enhances qede to dump more debug logs
(not just specific to the queue which was reported by stack)
on tx timeout which includes various other basic metadata about
all tx queues and other info (like status block etc.)

Signed-off-by: Manish Chopra 
Signed-off-by: Prabhakar Kushwaha 
Signed-off-by: Alok Prasad 
Signed-off-by: Ariel Elior 
Signed-off-by: Jakub Kicinski

ethernet: constify references to netdev->dev_addr in drivers

2021-10-14T16:22:11+00:00

This big patch sprinkles const on local variables and
function arguments which may refer to netdev->dev_addr.

Commit 406f42fa0d3c ("net-next: When a bond have a massive amount
of VLANs...") introduced a rbtree for faster Ethernet address look
up. To maintain netdev->dev_addr in this tree we need to make all
the writes to it got through appropriate helpers.

Some of the changes here are not strictly required - const
is sometimes cast off but pointer is not used for writing.
It seems like it's still better to add the const in case
the code changes later or relevant -W flags get enabled
for the build.

No functional changes.

Link: https://lore.kernel.org/r/20211014142432.449314-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski

qed: Update the TCP active termination 2 MSL timer ("TIME_WAIT")

2021-10-04T11:55:49+00:00

Initialize 2 MSL timeout value used for the TCP TIME_WAIT state to
non-zero default.

This patch also removes magic number from qedi/qedi_main.c.

Reviewed-by: Manish Rangankar 
Signed-off-by: Nikolay Assa 
Signed-off-by: Ariel Elior 
Signed-off-by: Shai Malin 
Signed-off-by: Omkar Kulkarni 
Signed-off-by: Prabhakar Kushwaha 
Signed-off-by: David S. Miller

qed: Update TCP silly-window-syndrome timeout for iwarp, scsi

2021-10-04T11:55:49+00:00

Update TCP silly-window-syndrome timeout, for the cases where
initiator's small TCP window size prevents FW from transmitting
packets on the connection. Timeout causes FW to retransmit
window probes if needed, preventing I/O stall if initiator ignores
first window probe.

Reviewed-by: Manish Rangankar 
Signed-off-by: Nikolay Assa 
Signed-off-by: Ariel Elior 
Signed-off-by: Shai Malin 
Signed-off-by: Omkar Kulkarni 
Signed-off-by: Prabhakar Kushwaha 
Signed-off-by: David S. Miller

qed: Update qed_hsi.h for fw 8.59.1.0

2021-10-04T11:55:49+00:00

The qed_hsi.h has been updated to support new FW version 8.59.1.0 with
changes.
 - Updates FW HSI (Hardware Software interface) structures.
 - Addition/update in function declaration and defines as per HSI.
 - Add generic infrastructure for FW error reporting as part of
   common event queue handling.
 - Move malicious VF error reporting to FW error reporting
   infrastructure.
 - Move consolidation queue initialization from FW context to ramrod
   message.

qed_hsi.h header file changes lead to change in many files to ensure
compilation.

This patch also fixes the existing checkpatch warnings and few important
checks.

Signed-off-by: Ariel Elior 
Signed-off-by: Shai Malin 
Signed-off-by: Omkar Kulkarni 
Signed-off-by: Prabhakar Kushwaha 
Signed-off-by: David S. Miller