linux-toradex.git/include/linux/seq_file.h, branch v6.16-rc6

seq_file: Mark binary printing functions with __printf() attribute

2025-03-28T12:37:11+00:00

Binary printing functions are using printf() type of format, and compiler
is not happy about them as is:

fs/seq_file.c:418:35: error: function ‘seq_bprintf’ might be a candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format]

Fix the compilation errors by adding __printf() attribute.

Signed-off-by: Andy Shevchenko 
Reviewed-by: Kees Cook 
Reviewed-by: Petr Mladek 
Link: https://lore.kernel.org/r/20250321144822.324050-3-andriy.shevchenko@linux.intel.com
Signed-off-by: Petr Mladek

cpumask: cleanup core headers inclusion

2024-06-25T05:25:02+00:00

Many core headers include cpumask.h for nothing. Drop it.

Link: https://lkml.kernel.org/r/20240528005648.182376-6-yury.norov@gmail.com
Signed-off-by: Yury Norov 
Cc: Amit Daniel Kachhap 
Cc: Anna-Maria Behnsen 
Cc: Christoph Lameter 
Cc: Daniel Lezcano 
Cc: Dennis Zhou 
Cc: Frederic Weisbecker 
Cc: Johannes Weiner 
Cc: Juri Lelli 
Cc: Kees Cook 
Cc: Mathieu Desnoyers 
Cc: Paul E. McKenney 
Cc: Peter Zijlstra 
Cc: Rafael J. Wysocki 
Cc: Rasmus Villemoes 
Cc: Tejun Heo 
Cc: Thomas Gleixner 
Cc: Ulf Hansson 
Cc: Vincent Guittot 
Cc: Viresh Kumar 
Cc: Yury Norov 
Signed-off-by: Andrew Morton

seq_file: Optimize seq_puts()

2024-05-02T14:28:15+00:00

Most of seq_puts() usages are done with a string literal. In such cases,
the length of the string car be computed at compile time in order to save
a strlen() call at run-time. seq_putc() or seq_write() can then be used
instead.

This saves a few cycles.

To have an estimation of how often this optimization triggers:
   $ git grep seq_puts.*\" | wc -l
   3436

   $ git grep seq_puts.*\".\" | wc -l
   84

Signed-off-by: Christophe JAILLET 
Link: https://lore.kernel.org/r/a8589bffe4830dafcb9111e22acf06603fea7132.1713781332.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Christian Brauner 
The output for seq_putc() generation has also be checked and works.

seq_file: add helper macro to define attribute for rw file

2023-10-04T17:41:57+00:00

Patch series "Add helper macro DEFINE_SHOW_STORE_ATTRIBUTE() at
seq_file.c", v6.

We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute
for read-only file, but we found many of drivers also want a helper macro
for read-write file too.

So we add this helper macro to reduce duplicated code.


This patch (of 3):

We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute
for read-only file, but many of drivers want a helper macro for read-write
file too.

So we add DEFINE_SHOW_STORE_ATTRIBUTE() helper to reduce duplicated code.

Link: https://lkml.kernel.org/r/20230905024835.43219-1-yangxingui@huawei.com
Link: https://lkml.kernel.org/r/20230905024835.43219-2-yangxingui@huawei.com
Signed-off-by: Luo Jiaxing 
Co-developed-by: Xingui Yang 
Signed-off-by: Xingui Yang 
Reviewed-by: Andy Shevchenko 
Cc: Al Viro 
Cc: Animesh Manna 
Cc: Anshuman Gupta 
Cc: Damien Le Moal 
Cc: Felipe Balbi 
Cc: Greg Kroah-Hartman 
Cc: Himanshu Madhani 
Cc: James Bottomley 
Cc: John Garry 
Cc: Martin K. Petersen 
Cc: Uma Shankar 
Cc: Xiang Chen 
Cc: Zeng Tao 
Signed-off-by: Andrew Morton

seq_file: seq_show_option_n() is used for precise sizes

2023-07-27T15:48:12+00:00

When seq_show_option_n() is used, it is for non-string memory that
happens to be printable bytes. As such, we must use memcpy() to copy the
bytes and then explicitly NUL-terminate the result.

Cc: Andy Shevchenko 
Cc: Andrew Morton 
Cc: Al Viro 
Cc: Muchun Song 
Reviewed-by: Andy Shevchenko 
Link: https://lore.kernel.org/r/20230726215957.never.619-kees@kernel.org
Signed-off-by: Kees Cook

rxrpc: Fix locking issue

2022-05-22T20:03:01+00:00

There's a locking issue with the per-netns list of calls in rxrpc.  The
pieces of code that add and remove a call from the list use write_lock()
and the calls procfile uses read_lock() to access it.  However, the timer
callback function may trigger a removal by trying to queue a call for
processing and finding that it's already queued - at which point it has a
spare refcount that it has to do something with.  Unfortunately, if it puts
the call and this reduces the refcount to 0, the call will be removed from
the list.  Unfortunately, since the _bh variants of the locking functions
aren't used, this can deadlock.

================================
WARNING: inconsistent lock state
5.18.0-rc3-build4+ #10 Not tainted
--------------------------------
inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage.
ksoftirqd/2/25 [HC0[0]:SC1[1]:HE1:SE0] takes:
ffff888107ac4038 (&rxnet->call_lock){+.?.}-{2:2}, at: rxrpc_put_call+0x103/0x14b
{SOFTIRQ-ON-W} state was registered at:
...
 Possible unsafe locking scenario:

       CPU0
       ----
  lock(&rxnet->call_lock);
  
    lock(&rxnet->call_lock);

 *** DEADLOCK ***

1 lock held by ksoftirqd/2/25:
 #0: ffff8881008ffdb0 ((&call->timer)){+.-.}-{0:0}, at: call_timer_fn+0x5/0x23d

Changes
=======
ver #2)
 - Changed to using list_next_rcu() rather than rcu_dereference() directly.

Fixes: 17926a79320a ("[AF_RXRPC]: Provide secure RxRPC sockets for use by userspace and kernel both")
Signed-off-by: David Howells 
cc: Marc Dionne 
cc: linux-afs@lists.infradead.org
Signed-off-by: David S. Miller

seq_file: fix NULL pointer arithmetic warning

2022-02-01T16:31:55+00:00

Implement conditional logic in order to replace NULL pointer arithmetic.

The use of NULL pointer arithmetic was pointed out by clang with the
following warning:

fs/kernfs/file.c:128:15: warning: performing pointer arithmetic on a
null pointer has undefined behavior [-Wnull-pointer-arithmetic]
                return NULL + !*ppos;
                       ~~~~ ^
fs/seq_file.c:559:14: warning: performing pointer arithmetic on a
null pointer has undefined behavior [-Wnull-pointer-arithmetic]
        return NULL + (*pos == 0);

Signed-off-by: Maíra Canal 
Signed-off-by: Al Viro

proc: remove PDE_DATA() completely

2022-01-22T06:33:37+00:00

Remove PDE_DATA() completely and replace it with pde_data().

[akpm@linux-foundation.org: fix naming clash in drivers/nubus/proc.c]
[akpm@linux-foundation.org: now fix it properly]

Link: https://lkml.kernel.org/r/20211124081956.87711-2-songmuchun@bytedance.com
Signed-off-by: Muchun Song 
Acked-by: Christian Brauner 
Cc: Alexey Dobriyan 
Cc: Alexey Gladkov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

seq_file: fix passing wrong private data

2021-11-09T18:02:52+00:00

DEFINE_PROC_SHOW_ATTRIBUTE() is supposed to be used to define a series
of functions and variables to register proc file easily. And the users
can use proc_create_data() to pass their own private data and get it
via seq->private in the callback. Unfortunately, the proc file system
use PDE_DATA() to get private data instead of inode->i_private. So fix
it. Fortunately, there only one user of it which does not pass any
private data, so this bug does not break any in-tree codes.

Link: https://lkml.kernel.org/r/20211029032638.84884-1-songmuchun@bytedance.com
Fixes: 97a32539b956 ("proc: convert everything to "struct proc_ops"")
Signed-off-by: Muchun Song 
Cc: Andy Shevchenko 
Cc: Stephen Rothwell 
Cc: Florent Revest 
Cc: Alexey Dobriyan 
Cc: Christian Brauner 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

seq_file: move seq_escape() to a header

2021-11-09T18:02:52+00:00

Move seq_escape() to the header as inliner, for a small kernel text size
reduction.

Link: https://lkml.kernel.org/r/20211001122917.67228-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Andy Shevchenko 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds