linux-toradex.git/include/linux/sunrpc, branch v2.6.20.21

Fix recently introduced problem with shutting down a busy NFS server.

2007-03-09T18:50:21+00:00

When the last thread of nfsd exits, it shuts down all related sockets.
It currently uses svc_close_socket to do this, but that only is
immediately effective if the socket is not SK_BUSY.

If the socket is busy - i.e. if a request has arrived that has not yet
been processes - svc_close_socket is not effective and the shutdown
process spins.

So create a new svc_force_close_socket which removes the SK_BUSY flag
is set and then calls svc_close_socket.

Also change some open-codes loops in svc_destroy to use
list_for_each_entry_safe.

Signed-off-by: Neil Brown 
Signed-off-by: Greg Kroah-Hartman

knfsd: Fix a race in closing NFSd connections.

2007-03-09T18:50:18+00:00

If you lose this race, it can iput a socket inode twice and you
get a BUG in fs/inode.c

When I added the option for user-space to close a socket,
I added some cruft to svc_delete_socket so that I could call
that function when closing a socket per user-space request.

This was the wrong thing to do.  I should have just set SK_CLOSE
and let normal mechanisms do the work.

Not only wrong, but buggy.  The locking is all wrong and it openned
up a race where-by a socket could be closed twice.

So this patch:
  Introduces svc_close_socket which sets SK_CLOSE then either leave
  the close up to a thread, or calls svc_delete_socket if it can
  get SK_BUSY.

  Adds a bias to sk_busy which is removed when SK_DEAD is set,
  This avoid races around shutting down the socket.

  Changes several 'spin_lock' to 'spin_lock_bh' where the _bh 
  was missing.

Bugzilla-url: http://bugzilla.kernel.org/show_bug.cgi?id=7916

Signed-off-by: Neil Brown 
Signed-off-by: Greg Kroah-Hartman

[PATCH] knfsd: fix an NFSD bug with full sized, non-page-aligned reads

2007-01-26T21:50:59+00:00

NFSd assumes that largest number of pages that will be needed for a
request+response is 2+N where N pages is the size of the largest permitted
read/write request.  The '2' are 1 for the non-data part of the request, and 1
for the non-data part of the reply.

However, when a read request is not page-aligned, and we choose to use
->sendfile to send it directly from the page cache, we may need N+1 pages to
hold the whole reply.  This can overflow and array and cause an Oops.

This patch increases size of the array for holding pages by one and makes sure
that entry is NULL when it is not in use.

Signed-off-by: Neil Brown 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] NFS: Fix Oops in rpc_call_sync()

2007-01-24T20:31:06+00:00

Fix the Oops in http://bugzilla.linux-nfs.org/show_bug.cgi?id=138
We shouldn't be calling rpc_release_task() for tasks that are not active.

Signed-off-by: Trond Myklebust 
Signed-off-by: Linus Torvalds

Merge branch 'master' of /home/trondmy/kernel/linux-2.6/ into merge_linus

2006-12-07T21:35:17+00:00

Merge branch 'master' of /home/trondmy/kernel/linux-2.6/ into merge_linus

2006-12-07T20:48:15+00:00

Conflicts:

	include/linux/sunrpc/xprt.h
	net/sunrpc/xprtsock.c
Fix up conflicts with the workqueue changes.

[PATCH] lockdep: name some old style locks

2006-12-07T16:39:36+00:00

Name some of the remaning 'old_style_spin_init' locks

Signed-off-by: Peter Zijlstra 
Acked-by: Ingo Molnar 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

SUNRPC: Remove pprintk() from net/sunrpc/xprt.c

2006-12-06T15:46:55+00:00

These appear to be deprecated.  Removing them also gets rid of some sparse
noise.

Signed-off-by: Chuck Lever 
Signed-off-by: Trond Myklebust

SUNRPC: Rename skb_reader_t and friends

2006-12-06T15:46:52+00:00

Clean-up:  hch suggested that the RPC client shouldn't pollute the name
space used by the generic skb manipulation routines in net/core/skbuff.c.

Rename a couple of types in xdr.h to adhere to this convention.

Signed-off-by: Chuck Lever 
Signed-off-by: Trond Myklebust

SUNRPC: skb_read_bits is the same as xs_tcp_copy_data

2006-12-06T15:46:52+00:00

Clean-up: eliminate xs_tcp_copy_data -- it's exactly the same logic as the
common routine skb_read_bits.  The UDP and TCP socket read code now share
the same routine for copying data into an xdr_buf.

Now that skb_read_bits() is exported, rename it to avoid confusing it with
a generic skb_* function.  As these functions are XDR-specific, they should
not have names that suggest they are of generic use.  Also rename
skb_read_and_csum_bits() to be consistent.

Signed-off-by: Chuck Lever 
Signed-off-by: Trond Myklebust