linux-toradex.git/include/linux/sunrpc, branch v4.12-rc4

nfsd: Revert "nfsd: check for oversized NFSv2/v3 arguments"

2017-05-16T20:16:30+00:00

This reverts commit 51f567777799 "nfsd: check for oversized NFSv2/v3
arguments", which breaks support for NFSv3 ACLs.

That patch was actually an earlier draft of a fix for the problem that
was eventually fixed by e6838a29ecb "nfsd: check for oversized NFSv2/v3
arguments".  But somehow I accidentally left this earlier draft in the
branch that was part of my 2.12 pull request.

Reported-by: Eryu Guan 
Cc: stable@vger.kernel.org
Signed-off-by: J. Bruce Fields

NFSv4: Fix callback server shutdown

2017-04-27T22:00:16+00:00

We want to use kthread_stop() in order to ensure the threads are
shut down before we tear down the nfs_callback_info in nfs_callback_down.

Tested-and-reviewed-by: Kinglong Mee 
Reported-by: Kinglong Mee 
Fixes: bb6aeba736ba9 ("NFSv4.x: Switch to using svc_set_num_threads()...")
Signed-off-by: Trond Myklebust 
Signed-off-by: J. Bruce Fields

svcrdma: Clean out old XDR encoders

2017-04-25T21:25:56+00:00

Clean up: These have been replaced and are no longer used.

Signed-off-by: Chuck Lever 
Reviewed-by: Sagi Grimberg 
Signed-off-by: J. Bruce Fields

svcrdma: Remove the req_map cache

2017-04-25T21:25:55+00:00

req_maps are no longer used by the send path and can thus be removed.

Signed-off-by: Chuck Lever 
Reviewed-by: Sagi Grimberg 
Signed-off-by: J. Bruce Fields

svcrdma: Remove unused RDMA Write completion handler

2017-04-25T21:25:55+00:00

Clean up. All RDMA Write completions are now handled by
svc_rdma_wc_write_ctx.

Signed-off-by: Chuck Lever 
Signed-off-by: J. Bruce Fields

svcrdma: Reduce size of sge array in struct svc_rdma_op_ctxt

2017-04-25T21:25:55+00:00

The sge array in struct svc_rdma_op_ctxt is no longer used for
sending RDMA Write WRs. It need only accommodate the construction of
Send and Receive WRs. The maximum inline size is the largest payload
it needs to handle now.

Signed-off-by: Chuck Lever 
Reviewed-by: Sagi Grimberg 
Signed-off-by: J. Bruce Fields

svcrdma: Clean up RPC-over-RDMA backchannel reply processing

2017-04-25T21:25:55+00:00

Replace C structure-based XDR decoding with pointer arithmetic.
Pointer arithmetic is considered more portable.

Signed-off-by: Chuck Lever 
Signed-off-by: J. Bruce Fields

svcrdma: Clean up RDMA_ERROR path

2017-04-25T21:25:55+00:00

Now that svc_rdma_sendto has been renovated, svc_rdma_send_error can
be refactored to reduce code duplication and remove C structure-
based XDR encoding. It is also relocated to the source file that
contains its only caller.

This is a refactoring change only.

Signed-off-by: Chuck Lever 
Reviewed-by: Sagi Grimberg 
Signed-off-by: J. Bruce Fields

svcrdma: Use rdma_rw API in RPC reply path

2017-04-25T21:25:55+00:00

The current svcrdma sendto code path posts one RDMA Write WR at a
time. Each of these Writes typically carries a small number of pages
(for instance, up to 30 pages for mlx4 devices). That means a 1MB
NFS READ reply requires 9 ib_post_send() calls for the Write WRs,
and one for the Send WR carrying the actual RPC Reply message.

Instead, use the new rdma_rw API. The details of Write WR chain
construction and memory registration are taken care of in the RDMA
core. svcrdma can focus on the details of the RPC-over-RDMA
protocol. This gives three main benefits:

1. All Write WRs for one RDMA segment are posted in a single chain.
As few as one ib_post_send() for each Write chunk.

2. The Write path can now use FRWR to register the Write buffers.
If the device's maximum page list depth is large, this means a
single Write WR is needed for each RPC's Write chunk data.

3. The new code introduces support for RPCs that carry both a Write
list and a Reply chunk. This combination can be used for an NFSv4
READ where the data payload is large, and thus is removed from the
Payload Stream, but the Payload Stream is still larger than the
inline threshold.

Signed-off-by: Chuck Lever 
Signed-off-by: J. Bruce Fields

svcrdma: Introduce local rdma_rw API helpers

2017-04-25T21:25:55+00:00

The plan is to replace the local bespoke code that constructs and
posts RDMA Read and Write Work Requests with calls to the rdma_rw
API. This shares code with other RDMA-enabled ULPs that manages the
gory details of buffer registration and posting Work Requests.

Some design notes:

 o The structure of RPC-over-RDMA transport headers is flexible,
   allowing multiple segments per Reply with arbitrary alignment,
   each with a unique R_key. Write and Send WRs continue to be
   built and posted in separate code paths. However, one whole
   chunk (with one or more RDMA segments apiece) gets exactly
   one ib_post_send and one work completion.

 o svc_xprt reference counting is modified, since a chain of
   rdma_rw_ctx structs generates one completion, no matter how
   many Write WRs are posted.

 o The current code builds the transport header as it is construct-
   ing Write WRs. I've replaced that with marshaling of transport
   header data items in a separate step. This is because the exact
   structure of client-provided segments may not align with the
   components of the server's reply xdr_buf, or the pages in the
   page list. Thus parts of each client-provided segment may be
   written at different points in the send path.

Signed-off-by: Chuck Lever 
Signed-off-by: J. Bruce Fields