linux-toradex.git/include/linux/sunrpc, branch v5.1-rc1

SUNRPC: Micro-optimise when the task is known not to be sleeping

2019-03-10T18:08:19+00:00

In cases where we know the task is not sleeping, try to optimise
away the indirect call to task->tk_action() by replacing it with
a direct call.
Only change tail calls, to allow gcc to perform tail call
elimination.

Signed-off-by: Trond Myklebust

NFSv4/flexfiles: Abort I/O early if the layout segment was invalidated

2019-03-01T21:20:16+00:00

If a layout segment gets invalidated while a pNFS I/O operation
is queued for transmission, then we ideally want to abort
immediately. This is particularly the case when there is a large
number of I/O related RPCs queued in the RPC layer, and the layout
segment gets invalidated due to an ENOSPC error, or an EACCES (because
the client was fenced). We may end up forced to spam the MDS with a
lot of otherwise unnecessary LAYOUTERRORs after that I/O fails.

Signed-off-by: Trond Myklebust

SUNRPC: Fix an Oops in udp_poll()

2019-02-26T11:33:02+00:00

udp_poll() checks the struct file for the O_NONBLOCK flag, so we must not
call it with a NULL file pointer.

Fixes: 0ffe86f48026 ("SUNRPC: Use poll() to fix up the socket requeue races")
Signed-off-by: Trond Myklebust

SUNRPC: Add rpc_auth::au_ralign field

2019-02-14T16:48:36+00:00

Currently rpc_inline_rcv_pages() uses au_rslack to estimate the
size of the upper layer reply header. This is fine for auth flavors
where au_verfsize == au_rslack.

However, some auth flavors have more going on. krb5i for example has
two more words after the verifier, and another blob following the
RPC message. The calculation involving au_rslack pushes the upper
layer reply header too far into the rcv_buf.

au_rslack is still valuable: it's the amount of buffer space needed
for the reply, and is used when allocating the reply buffer. We'll
keep that.

But, add a new field that can be used to properly estimate the
location of the upper layer header in each RPC reply, based on the
auth flavor in use.

Signed-off-by: Chuck Lever 
Signed-off-by: Anna Schumaker

SUNRPC: Make AUTH_SYS and AUTH_NULL set au_verfsize

2019-02-14T16:17:47+00:00

au_verfsize will be needed for a non-flavor-specific computation
in a subsequent patch.

Signed-off-by: Chuck Lever 
Signed-off-by: Anna Schumaker

SUNRPC: Introduce rpc_prepare_reply_pages()

2019-02-14T15:04:37+00:00

prepare_reply_buffer() and its NFSv4 equivalents expose the details
of the RPC header and the auth slack values to upper layer
consumers, creating a layering violation, and duplicating code.

Remedy these issues by adding a new RPC client API that hides those
details from upper layers in a common helper function.

Signed-off-by: Chuck Lever 
Signed-off-by: Anna Schumaker

SUNRPC: Remove xdr_buf_trim()

2019-02-14T14:39:34+00:00

The key action of xdr_buf_trim() is that it shortens buf->len, the
length of the xdr_buf's content. The other actions -- shortening the
head, pages, and tail components -- are actually not necessary. In
particular, changing the size of those components can corrupt the
RPC message contained in the buffer. This is an accident waiting to
happen rather than a current bug, as far as we know.

Signed-off-by: Chuck Lever 
Acked-by: Bruce Fields 
Signed-off-by: Anna Schumaker

SUNRPC: Use struct xdr_stream when decoding RPC Reply header

2019-02-14T14:11:18+00:00

Modernize and harden the code path that parses an RPC Reply
message.

Signed-off-by: Chuck Lever 
Signed-off-by: Anna Schumaker

SUNRPC: Clean up rpc_verify_header()

2019-02-13T18:54:37+00:00

- Recover some instruction count because I'm about to introduce a
  few xdr_inline_decode call sites
- Replace dprintk() call sites with trace points
- Reduce the hot path so it fits in fewer cachelines

I've also renamed it rpc_decode_header() to match everything else
in the RPC client.

Signed-off-by: Chuck Lever 
Signed-off-by: Anna Schumaker

SUNRPC: Use struct xdr_stream when constructing RPC Call header

2019-02-13T18:45:17+00:00

Modernize and harden the code path that constructs each RPC Call
message.

Signed-off-by: Chuck Lever 
Signed-off-by: Anna Schumaker