linux-toradex.git/include/linux/thermal.h, branch v5.16-rc3

thermal: Spelling s/scallbacks/callbacks/

2021-08-14T13:43:28+00:00

Fix a misspelling of the word "callbacks".

Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Daniel Lezcano 
Link: https://lore.kernel.org/r/ae38372996a23bb67769e2d62ca170ae9457c4df.1626261946.git.geert+renesas@glider.be

thermal/core: Fix thermal_cooling_device_register() prototype

2021-08-14T13:40:26+00:00

There are two pairs of declarations for thermal_cooling_device_register()
and thermal_of_cooling_device_register(), and only one set was changed
in a recent patch, so the other one now causes a compile-time warning:

drivers/net/wireless/mediatek/mt76/mt7915/init.c: In function 'mt7915_thermal_init':
drivers/net/wireless/mediatek/mt76/mt7915/init.c:134:48: error: passing argument 1 of 'thermal_cooling_device_register' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
  134 |         cdev = thermal_cooling_device_register(wiphy_name(wiphy), phy,
      |                                                ^~~~~~~~~~~~~~~~~
In file included from drivers/net/wireless/mediatek/mt76/mt7915/init.c:7:
include/linux/thermal.h:407:39: note: expected 'char *' but argument is of type 'const char *'
  407 | thermal_cooling_device_register(char *type, void *devdata,
      |                                 ~~~~~~^~~~

Change the dummy helper functions to have the same arguments as the
normal version.

Fixes: f991de53a8ab ("thermal: make device_register's type argument const")
Signed-off-by: Arnd Bergmann 
Reviewed-by: Jean-Francois Dagenais 
Signed-off-by: Daniel Lezcano 
Link: https://lore.kernel.org/r/20210722090717.1116748-1-arnd@kernel.org

thermal/core: Remove thermal_notify_framework

2021-04-22T11:14:09+00:00

thermal_notify_framework just updates for a single trip point where as
thermal_zone_device_update does other bookkeeping like updating the
temperature of the thermal zone and setting the next trip point. The only
driver that was using thermal_notify_framework was updated in the previous
patch to use thermal_zone_device_update instead. Since there are no users
for thermal_notify_framework remove it.

Signed-off-by: Thara Gopinath 
Signed-off-by: Daniel Lezcano 
Link: https://lore.kernel.org/r/20210122023406.3500424-3-thara.gopinath@linaro.org

thermal/drivers/core: Use a char pointer for the cooling device name

2021-03-15T03:46:25+00:00

We want to have any kind of name for the cooling devices as we do no
longer want to rely on auto-numbering. Let's replace the cooling
device's fixed array by a char pointer to be allocated dynamically
when registering the cooling device, so we don't limit the length of
the name.

Rework the error path at the same time as we have to rollback the
allocations in case of error.

Tested with a dummy device having the name:
 "Llanfairpwllgwyngyllgogerychwyrndrobwllllantysiliogogogoch"

A village on the island of Anglesey (Wales), known to have the longest
name in Europe.

Signed-off-by: Daniel Lezcano 
Reviewed-by: Lukasz Luba 
Tested-by: Ido Schimmel 
Link: https://lore.kernel.org/r/20210314111333.16551-1-daniel.lezcano@linaro.org

thermal/core: Make cooling device state change private

2021-01-19T21:31:10+00:00

The change of the cooling device state should be used by the governor
or at least by the core code, not by the drivers themselves.

Remove the API usage and move the function declaration to the internal
headers.

Signed-off-by: Daniel Lezcano 
Acked-by: Guenter Roeck 
Acked-by: Zhang Rui 
Link: https://lore.kernel.org/r/20210118173824.9970-1-daniel.lezcano@linaro.org

thermal/core: Remove ms based delay fields

2021-01-19T21:23:49+00:00

The code does no longer use the ms unit based fields to set the
delays as they are replaced by the jiffies.

Remove them and replace their user to use the jiffies version instead.

Cc: Thara Gopinath 
Signed-off-by: Daniel Lezcano 
Reviewed-by: Lukasz Luba 
Reviewed-by: Peter Kästle 
Acked-by: Hans de Goede 
Link: https://lore.kernel.org/r/20201216220337.839878-3-daniel.lezcano@linaro.org

thermal/core: Precompute the delays from msecs to jiffies

2021-01-19T21:23:38+00:00

The delays are stored in ms units and when the polling function is
called this delay is converted into jiffies at each call.

Instead of doing the conversion again and again, compute the jiffies
at init time and use the value directly when setting the polling.

Cc: Thara Gopinath 
Signed-off-by: Daniel Lezcano 
Reviewed-by: Lukasz Luba 
Reviewed-by: Thara Gopinath 
Link: https://lore.kernel.org/r/20201216220337.839878-1-daniel.lezcano@linaro.org

thermal/core: Remove unused macro THERMAL_TRIPS_NONE

2021-01-19T21:23:32+00:00

The macro THERMAL_TRIPS_NONE is no longer used, remove it.

Signed-off-by: Daniel Lezcano 
Reviewed-by: Thara Gopinath 
Link: https://lore.kernel.org/r/20201214233811.485669-6-daniel.lezcano@linaro.org

thermal/core: Remove the 'forced_passive' option

2021-01-19T21:22:45+00:00

The code was reorganized in 2012 with the commit 0c01ebbfd3caf1.

The main change is a loop on the trip points array and a unconditional
call to the throttle() ops of the governors for each of them even if
the trip temperature is not reached yet.

With this change, the 'forced_passive' is no longer checked in the
thermal_zone_device_update() function but in the step wise governor's
throttle() callback.

As the force_passive does no belong to the trip point array, the
thermal_zone_device_update() can not compare with the specified
passive temperature, thus does not detect the passive limit has been
crossed. Consequently, throttle() is never called and the
'forced_passive' branch is unreached.

In addition, the default processor cooling device is not automatically
bound to the thermal zone if there is not passive trip point, thus the
'forced_passive' can not operate.

If there is an active trip point, then the throttle function will be
called to mitigate at this temperature and the 'forced_passive' will
override the mitigation of the active trip point in this case but with
the default cooling device bound to the thermal zone, so usually a
fan, and that is not a passive cooling effect.

Given the regression exists since more than 8 years, nobody complained
and at the best of my knowledge there is no bug open in
https://bugzilla.kernel.org, it is reasonable to say it is unused.

Remove the 'forced_passive' related code.

Signed-off-by: Daniel Lezcano 
Reviewed-by: Thara Gopinath 
Link: https://lore.kernel.org/r/20201214233811.485669-1-daniel.lezcano@linaro.org

thermal/core: Remove notify ops

2021-01-07T16:48:56+00:00

With the removal of the notifys user in a previous patches, the ops is no
longer needed, remove it.

Signed-off-by: Daniel Lezcano 
Reviewed-by: Lukasz Luba 
Link: https://lore.kernel.org/r/20201210121514.25760-5-daniel.lezcano@linaro.org