linux-toradex.git/include/linux/usb/cdc_ncm.h, branch v3.14.3

net: cdc_ncm: fix control message ordering

2014-03-18T19:32:32+00:00

This is a context modified revert of commit 6a9612e2cb22
("net: cdc_ncm: remove ncm_parm field") which introduced
a NCM specification violation, causing setup errors for
some devices. These errors resulted in the device and
host disagreeing about shared settings, with complete
failure to communicate as the end result.

The NCM specification require that many of the NCM specific
control reuests are sent only while the NCM Data Interface
is in alternate setting 0. Reverting the commit ensures that
we follow this requirement.

Fixes: 6a9612e2cb22 ("net: cdc_ncm: remove ncm_parm field")
Reported-and-tested-by: Pasi Kärkkäinen 
Reported-by: Thomas Schäfer 
Signed-off-by: Bjørn Mork 
Signed-off-by: David S. Miller

net: cdc_ncm: Export cdc_ncm_{tx, rx}_fixup functions for re-use

2013-11-05T20:21:25+00:00

Some drivers implementing NCM-like protocols, may re-use those functions, as is
the case in the huawei_cdc_ncm driver.
Export them via EXPORT_SYMBOL_GPL, in accordance with how other functions have
been exported.

Signed-off-by: Enrico Mioso 
Signed-off-by: Bjørn Mork 
Signed-off-by: David S. Miller

net: cdc_ncm: drop "extern" from header declarations

2013-11-02T06:02:04+00:00

Cc: Alexey Orishko 
Signed-off-by: Bjørn Mork 
Signed-off-by: David S. Miller

net: cdc_ncm: remove descriptor pointers

2013-11-02T06:02:02+00:00

header_desc was completely unused and union_desc was never used
outside cdc_ncm_bind_common.

Cc: Alexey Orishko 
Signed-off-by: Bjørn Mork 
Signed-off-by: David S. Miller

net: cdc_ncm: remove ncm_parm field

2013-11-02T06:02:02+00:00

Moving the call to cdc_ncm_setup() after the endpoint
setup removes the last remaining reference to ncm_parm
outside cdc_ncm_setup.

Collecting all the ncm_parm based calculations in
cdc_ncm_setup improves readability.

Cc: Alexey Orishko 
Signed-off-by: Bjørn Mork 
Signed-off-by: David S. Miller

net: cdc_ncm: remove tx_speed and rx_speed fields

2013-11-02T06:02:02+00:00

These fields are only used to prevent printing the same speeds
multiple times if we receive multiple identical speed notifications.

The value of these printk's is questionable, and even more so when
we filter out some of the notifications sent us by the firmware. If
we are going to print any of these, then we should print them all.

Removing little used fields is a bonus.

Cc: Alexey Orishko 
Signed-off-by: Bjørn Mork 
Signed-off-by: David S. Miller

net: cdc_ncm: remove unused udev field

2013-11-02T06:02:02+00:00

We already use the usbnet udev field everywhere this could have
been used.

Cc: Alexey Orishko 
Signed-off-by: Bjørn Mork 
Signed-off-by: David S. Miller

net: cdc_ncm: remove redundant netdev field

2013-11-02T06:02:02+00:00

Too many pointers back and forth are likely to confuse developers,
creating subtle bugs whenever we forget to syncronize them all.

As a usbnet driver, we should stick with the standard struct
usbnet fields as much as possible.  The netdevice is one such
field.

Cc: Greg Suarez 
Cc: Alexey Orishko 
Signed-off-by: Bjørn Mork 
Signed-off-by: David S. Miller

net: cdc_ncm: remove redundant endpoint pointers

2013-11-02T06:02:01+00:00

No need to duplicate stuff already in the common usbnet
struct.  We still need to keep our special find_endpoints
function because we need explicit control over the selected
altsetting.

Cc: Alexey Orishko 
Signed-off-by: Bjørn Mork 
Signed-off-by: David S. Miller

net: cdc_ncm: remove redundant "intf" field

2013-11-02T06:02:01+00:00

This is always a duplicate of the "control" field. It causes
confusion wrt intf_data updates and cleanups.

Cc: Alexey Orishko 
Signed-off-by: Bjørn Mork 
Signed-off-by: David S. Miller