linux-toradex.git/include/media/media-device.h, branch v4.9.122

[media] media: Move media_device link_notify operation to an ops structure

2016-09-09T14:20:09+00:00

This will allow adding new operations without increasing the
media_device structure size for drivers that don't implement any media
device operation.

Signed-off-by: Laurent Pinchart 
Signed-off-by: Sakari Ailus 
Acked-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

[media] docs-rst: improve the kAPI documentation for the mediactl

2016-09-09T12:28:55+00:00

There are several issues on the documentation:
  - the media.h header were not properly referenced;
  - verbatim expressions were not properly marked as such;
  - struct member references were wrong;
  - some notes were not using the right markup;
  - a comment that were moved to the kernel-doc markup were
    duplicated as a comment inside the struct media_entity;
  - some args were not pointing to the struct they're using;
  - macros weren't documented.

Signed-off-by: Mauro Carvalho Chehab

[media] doc-rst: Fix conversion for MC core functions

2016-07-17T17:02:44+00:00

There were lots of issues at the media controller side,
after the conversion:

- Some documentation at the header files weren't using the
  kernel-doc start block;

- Now, the C files with the exported symbols also need to be
  added. So, all headers need to be included twice: one to
  get the structs/enums/.. and another one for the functions;

- Notes should use the ReST tag, as kernel-doc doesn't
  recognizes it anymore;

- Identation needs to be fixed, as ReST uses it to identify
  when a format "tag" ends.

- Fix the cross-references at the media controller description.

Signed-off-by: Mauro Carvalho Chehab

[media] doc-rst: Convert media API to rst

2016-07-17T17:02:41+00:00

Move the contents of the media section at
DocBooks/DocBook/device-drivers.tmpl to a new ReST book.

For now, the contents is kept as-is. Next patches will fix
the warnings and add cross-references that were removed due to
the conversion.

Signed-off-by: Mauro Carvalho Chehab

[media] media-device: dynamically allocate struct media_devnode

2016-06-15T20:57:24+00:00

struct media_devnode is currently embedded at struct media_device.

While this works fine during normal usage, it leads to a race
condition during devnode unregister. the problem is that drivers
assume that, after calling media_device_unregister(), the struct
that contains media_device can be freed. This is not true, as it
can't be freed until userspace closes all opened /dev/media devnodes.

In other words, if the media devnode is still open, and media_device
gets freed, any call to an ioctl will make the core to try to access
struct media_device, with will cause an use-after-free and even GPF.

Fix this by dynamically allocating the struct media_devnode and only
freeing it when it is safe.

Signed-off-by: Mauro Carvalho Chehab 
Signed-off-by: Mauro Carvalho Chehab

[media] media: Improve documentation for link_setup/link_modify

2016-04-20T16:16:14+00:00

Those callbacks are called with the media_device.graph_mutex held.

Add a note about that, as the code called by those notifiers should
not be touching in the mutex.

Acked-by: Sakari Ailus 
Acked-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

[media] media-device: get rid of the spinlock

2016-04-20T16:12:02+00:00

Right now, the lock schema for media_device struct is messy,
since sometimes, it is protected via a spin lock, while, for
media graph traversal, it is protected by a mutex.

Solve this conflict by always using a mutex.

As a side effect, this prevents a bug when the media notifiers
is called at atomic context, while running the notifier callback:

 BUG: sleeping function called from invalid context at mm/slub.c:1289
 in_atomic(): 1, irqs_disabled(): 0, pid: 3479, name: modprobe
 4 locks held by modprobe/3479:
 #0:  (&dev->mutex){......}, at: [] __driver_attach+0xa3/0x160
 #1:  (&dev->mutex){......}, at: [] __driver_attach+0xb1/0x160
 #2:  (register_mutex#5){+.+.+.}, at: [] usb_audio_probe+0x257/0x1c90 [snd_usb_audio]
 #3:  (&(&mdev->lock)->rlock){+.+.+.}, at: [] media_device_register_entity+0x1cb/0x700 [media]
 CPU: 2 PID: 3479 Comm: modprobe Not tainted 4.5.0-rc3+ #49
 Hardware name:                  /NUC5i7RYB, BIOS RYBDWi35.86A.0350.2015.0812.1722 08/12/2015
 0000000000000000 ffff8803b3f6f288 ffffffff81933901 ffff8803c4bae000
 ffff8803c4bae5c8 ffff8803b3f6f2b0 ffffffff811c6af5 ffff8803c4bae000
 ffffffff8285d7f6 0000000000000509 ffff8803b3f6f2f0 ffffffff811c6ce5
 Call Trace:
 [] dump_stack+0x85/0xc4
 [] ___might_sleep+0x245/0x3a0
 [] __might_sleep+0x95/0x1a0
 [] kmem_cache_alloc_trace+0x20e/0x300
 [] ? media_add_link+0x4d/0x140 [media]
 [] media_add_link+0x4d/0x140 [media]
 [] media_create_pad_link+0xa1/0x600 [media]
 [] au0828_media_graph_notify+0x173/0x360 [au0828]
 [] ? media_gobj_create+0x1ba/0x480 [media]
 [] media_device_register_entity+0x3ab/0x700 [media]

Reviewed-by: Javier Martinez Canillas 
Acked-by: Sakari Ailus 
Acked-by: Hans Verkuil 
Signed-off-by: Mauro Carvalho Chehab

[media] media-device: make topology_version u64

2016-04-06T12:39:16+00:00

The uAPI defines it with 64 bits. Let's change the Kernel
implementation too.

Signed-off-by: Mauro Carvalho Chehab

[media] media-device: Fix a comment

2016-04-06T12:38:31+00:00

The comment is for the wrong function. Fix it.

Reviewed-by: Javier Martinez Canillas 
Signed-off-by: Mauro Carvalho Chehab

[media] media: Always keep a graph walk large enough around

2016-03-03T15:17:28+00:00

Re-create the graph walk object as needed in order to have one large enough
available for all entities in the graph.

This enumeration is used for pipeline power management in the future.

[mchehab@osg.samsung.com: fix documentation bug:
 " warning: bad line: graph_mutex"]

Signed-off-by: Sakari Ailus 
Signed-off-by: Mauro Carvalho Chehab