linux-toradex.git/include/net/act_api.h, branch v6.12-rc4

net/sched: Add helper macros with module names

2024-02-02T18:57:55+00:00

The macros are preparation for adding module aliases en mass in a
separate commit.
Although it would be tempting to create aliases like cls-foo for name
cls_foo, this could not be used because modprobe utilities treat '-' and
'_' interchangeably.
In the end, the naming follows pattern of proto modules in linux/net.h.

Signed-off-by: Michal Koutný 
Acked-by: Jamal Hadi Salim 
Reviewed-by: Jiri Pirko 
Link: https://lore.kernel.org/r/20240201130943.19536-2-mkoutny@suse.com
Signed-off-by: Jakub Kicinski

net/sched: simplify tc_action_load_ops parameters

2024-01-07T14:58:26+00:00

Instead of using two bools derived from a flags passed as arguments to
the parent function of tc_action_load_ops, just pass the flags itself
to tc_action_load_ops to simplify its parameters.

Reviewed-by: Jiri Pirko 
Signed-off-by: Pedro Tammela 
Acked-by: Jamal Hadi Salim 
Signed-off-by: David S. Miller

net/sched: introduce ACT_P_BOUND return code

2024-01-04T02:36:24+00:00

Bound actions always return '0' and as of today we rely on '0'
being returned in order to properly skip bound actions in
tcf_idr_insert_many. In order to further improve maintainability,
introduce the ACT_P_BOUND return code.

Actions are updated to return 'ACT_P_BOUND' instead of plain '0'.
tcf_idr_insert_many is then updated to check for 'ACT_P_BOUND'.

Signed-off-by: Pedro Tammela 
Acked-by: Jamal Hadi Salim 
Link: https://lore.kernel.org/r/20231229132642.1489088-1-pctammela@mojatatu.com
Signed-off-by: Jakub Kicinski

net/sched: act_api: skip idr replace on bound actions

2023-12-14T01:53:59+00:00

tcf_idr_insert_many will replace the allocated -EBUSY pointer in
tcf_idr_check_alloc with the real action pointer, exposing it
to all operations. This operation is only needed when the action pointer
is created (ACT_P_CREATED). For actions which are bound to (returned 0),
the pointer already resides in the idr making such operation a nop.

Even though it's a nop, it's still not a cheap operation as internally
the idr code walks the idr and then does a replace on the appropriate slot.
So if the action was bound, better skip the idr replace entirely.

Signed-off-by: Pedro Tammela 
Acked-by: Jamal Hadi Salim 
Reviewed-by: Vlad Buslov 
Link: https://lore.kernel.org/r/20231211181807.96028-3-pctammela@mojatatu.com
Signed-off-by: Jakub Kicinski

net/sched: Rename user cookie and act cookie

2023-02-21T00:46:10+00:00

struct tc_action->act_cookie is a user defined cookie,
and the related struct flow_action_entry->act_cookie is
used as an handle similar to struct flow_cls_offload->cookie.

Rename tc_action->act_cookie to user_cookie, and
flow_action_entry->act_cookie to cookie so their names
would better fit their usage.

Signed-off-by: Paul Blakey 
Reviewed-by: Marcelo Ricardo Leitner 
Signed-off-by: Jakub Kicinski

net/sched: move struct action_ops definition out of ifdef

2022-12-09T09:18:07+00:00

The type definition should be visible even in configurations not using
CONFIG_NET_CLS_ACT.

Signed-off-by: Pedro Tammela 
Reviewed-by: Jamal Hadi Salim 
Reviewed-by: Victor Nogueira 
Signed-off-by: David S. Miller

act_skbedit: skbedit queue mapping for receive queue

2022-10-25T08:32:40+00:00

Add support for skbedit queue mapping action on receive
side. This is supported only in hardware, so the skip_sw
flag is enforced. This enables offloading filters for
receive queue selection in the hardware using the
skbedit action. Traffic arrives on the Rx queue requested
in the skbedit action parameter. A new tc action flag
TCA_ACT_FLAGS_AT_INGRESS is introduced to identify the
traffic direction the action queue_mapping is requested
on during filter addition. This is used to disallow
offloading the skbedit queue mapping action on transmit
side.

Example:
$tc filter add dev $IFACE ingress protocol ip flower dst_ip $DST_IP\
 action skbedit queue_mapping $rxq_id skip_sw

Reviewed-by: Sridhar Samudrala 
Signed-off-by: Amritha Nambiar 
Signed-off-by: Paolo Abeni

net: sched: act: move global static variable net_id to tc_action_ops

2022-09-09T07:24:41+00:00

Each tc action module has a corresponding net_id, so put net_id directly
into the structure tc_action_ops.

Signed-off-by: Zhengchao Shao 
Acked-by: Jamal Hadi Salim 
Signed-off-by: David S. Miller

net/sched: act_api: Add extack to offload_act_setup() callback

2022-04-08T12:45:43+00:00

The callback is used by various actions to populate the flow action
structure prior to offload. Pass extack to this callback so that the
various actions will be able to report accurate error messages to user
space.

Signed-off-by: Ido Schimmel 
Reviewed-by: Petr Machata 
Signed-off-by: David S. Miller

flow_offload: validate flags of filter and actions

2021-12-19T14:08:48+00:00

Add process to validate flags of filter and actions when adding
a tc filter.

We need to prevent adding filter with flags conflicts with its actions.

Signed-off-by: Baowen Zheng 
Signed-off-by: Louis Peens 
Signed-off-by: Simon Horman 
Acked-by: Jamal Hadi Salim 
Signed-off-by: David S. Miller