linux-toradex.git/include/net/devlink.h, branch v5.1-rc1

devlink: Add support for direct reporter health state update

2019-03-04T19:00:43+00:00

It is possible that a reporter state will be updated due to a recover flow
which is not triggered by a devlink health related operation, but as a side
effect of some other operation in the system.

Expose devlink health API for a direct update of a reporter status.

Move devlink_health_reporter_state enum definition to devlink.h so it could
be used from drivers as a parameter of devlink_health_reporter_state_update.

In addition, add trace_devlink_health_reporter_state_update to provide user
notification for reporter state change.

Signed-off-by: Eran Ben Elisha 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

devlink: create a special NDO for getting the devlink instance

2019-02-26T16:49:05+00:00

Instead of iterating over all devlink ports add a NDO which
will return the devlink instance from the driver.

v2: add the netdev_to_devlink() helper (Michal)
v3: check that devlink has ops (Florian)
v4: hold devlink_mutex (Jiri)

Suggested-by: Jiri Pirko 
Signed-off-by: Jakub Kicinski 
Reviewed-by: Florian Fainelli 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

net: devlink: turn devlink into a built-in

2019-02-26T16:49:05+00:00

Being able to build devlink as a module causes growing pains.
First all drivers had to add a meta dependency to make sure
they are not built in when devlink is built as a module.  Now
we are struggling to invoke ethtool compat code reliably.

Make devlink code built-in, users can still not build it at
all but the dynamically loadable module option is removed.

Signed-off-by: Jakub Kicinski 
Reviewed-by: Florian Fainelli 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

ethtool: add compat for flash update

2019-02-17T23:27:38+00:00

If driver does not support ethtool flash update operation
call into devlink.

Signed-off-by: Jakub Kicinski 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

devlink: add flash update command

2019-02-17T23:27:38+00:00

Add devlink flash update command. Advanced NICs have firmware
stored in flash and often cryptographically secured. Updating
that flash is handled by management firmware. Ethtool has a
flash update command which served us well, however, it has two
shortcomings:
 - it takes rtnl_lock unnecessarily - really flash update has
   nothing to do with networking, so using a networking device
   as a handle is suboptimal, which leads us to the second one:
 - it requires a functioning netdev - in case device enters an
   error state and can't spawn a netdev (e.g. communication
   with the device fails) there is no netdev to use as a handle
   for flashing.

Devlink already has the ability to report the firmware versions,
now with the ability to update the firmware/flash we will be
able to recover devices in bad state.

To enable updates of sub-components of the FW allow passing
component name.  This name should correspond to one of the
versions reported in devlink info.

v1: - replace target id with component name (Jiri).

Signed-off-by: Jakub Kicinski 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

Revert "devlink: Add a generic wake_on_lan port parameter"

2019-02-12T17:13:22+00:00

This reverts commit b639583f9e36d044ac1b13090ae812266992cbac.

As per discussion with Jakub Kicinski and Michal Kubecek,
this will be better addressed by soon-too-come ethtool netlink
API with additional indication that given configuration request
is supposed to be persisted.

Also, remove the parameter support from bnxt_en driver.

Cc: Jiri Pirko 
Cc: Michael Chan 
Cc: Michal Kubecek 
Suggested-by: Jakub Kicinski 
Signed-off-by: Vasundhara Volam 
Signed-off-by: David S. Miller

devlink: add a generic board.manufacture version name

2019-02-12T04:39:56+00:00

At Jiri's suggestion add a generic "board.manufacture"
version identifier.

Signed-off-by: Jakub Kicinski 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

devlink: publish params only after driver init is done

2019-02-08T23:02:49+00:00

Currently, user can do dump or get of param values right after the
devlink params are registered. However the driver may not be initialized
which is an issue. The same problem happens during notification
upon param registration. Allow driver to publish devlink params
whenever it is ready to handle get() ops. Note that this cannot
be resolved by init reordering, as the "driverinit" params have
to be available before the driver is initialized (it needs the param
values there).

Signed-off-by: Jiri Pirko 
Cc: Michael Chan 
Cc: Tariq Toukan 
Signed-off-by: Ido Schimmel 
Signed-off-by: David S. Miller

devlink: Add health report functionality

2019-02-07T18:34:28+00:00

Upon error discover, every driver can report it to the devlink health
mechanism via devlink_health_report function, using the appropriate
reporter registered to it. Driver can pass error specific context which
will be delivered to it as part of the dump / recovery callbacks.

Once an error is reported, devlink health will do the following actions:
* A log is being send to the kernel trace events buffer
* Health status and statistics are being updated for the reporter instance
* Object dump is being taken and stored at the reporter instance (as long
  as there is no other dump which is already stored)
* Auto recovery attempt is being done. Depends on:
  - Auto Recovery configuration
  - Grace period vs. Time since last recover

Signed-off-by: Eran Ben Elisha 
Reviewed-by: Moshe Shemesh 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller

devlink: Add health reporter create/destroy functionality

2019-02-07T18:34:28+00:00

Devlink health reporter is an instance for reporting, diagnosing and
recovering from run time errors discovered by the reporters.
Define it's data structure and supported operations.
In addition, expose devlink API to create and destroy a reporter.
Each devlink instance will hold it's own reporters list.

As part of the allocation, driver shall provide a set of callbacks which
will be used by devlink in order to handle health reports and user
commands related to this reporter. In addition, driver is entitled to
provide some priv pointer, which can be fetched from the reporter by
devlink_health_reporter_priv function.

For each reporter, devlink will hold a metadata of statistics,
dump msg and status.

For passing dumps and diagnose data to the user-space, it will use devlink
fmsg API.

Signed-off-by: Eran Ben Elisha 
Reviewed-by: Moshe Shemesh 
Acked-by: Jiri Pirko 
Signed-off-by: David S. Miller