linux-toradex.git/include/net/flow_keys.h, branch v3.14.3

flow_dissector: factor out the ports extraction in skb_flow_get_ports

2013-10-03T19:36:37+00:00

Factor out the code that extracts the ports from skb_flow_dissect and
add a new function skb_flow_get_ports which can be re-used.

Suggested-by: Veaceslav Falico 
Signed-off-by: Nikolay Aleksandrov 
Acked-by: Eric Dumazet 
Reviewed-by: Veaceslav Falico 
Signed-off-by: David S. Miller

flow.h/flow_keys.h: Remove extern from function prototypes

2013-09-20T18:49:33+00:00

There are a mix of function prototypes with and without extern
in the kernel sources.  Standardize on not using extern for
function prototypes.

Function prototypes don't need to be written with extern.
extern is assumed by the compiler.  Its use is as unnecessary as
using auto to declare automatic/local variables in a block.

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

flow_keys: include thoff into flow_keys for later usage

2013-03-20T16:14:36+00:00

In skb_flow_dissect(), we perform a dissection of a skbuff. Since we're
doing the work here anyway, also store thoff for a later usage, e.g. in
the BPF filter.

Suggested-by: Eric Dumazet 
Signed-off-by: Daniel Borkmann 
Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

flow_dissector: use a 64bit load/store

2011-11-29T18:17:03+00:00

Le lundi 28 novembre 2011 à 19:06 -0500, David Miller a écrit :
> From: Dimitris Michailidis 
> Date: Mon, 28 Nov 2011 08:25:39 -0800
>
> >> +bool skb_flow_dissect(const struct sk_buff *skb, struct flow_keys
> >> *flow)
> >> +{
> >> +	int poff, nhoff = skb_network_offset(skb);
> >> +	u8 ip_proto;
> >> +	u16 proto = skb->protocol;
> >
> > __be16 instead of u16 for proto?
>
> I'll take care of this when I apply these patches.

( CC trimmed )

Thanks David !

Here is a small patch to use one 64bit load/store on x86_64 instead of
two 32bit load/stores.

[PATCH net-next] flow_dissector: use a 64bit load/store

gcc compiler is smart enough to use a single load/store if we
memcpy(dptr, sptr, 8) on x86_64, regardless of
CONFIG_CC_OPTIMIZE_FOR_SIZE

In IP header, daddr immediately follows saddr, this wont change in the
future. We only need to make sure our flow_keys (src,dst) fields wont
break the rule.

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

net: introduce skb_flow_dissect()

2011-11-29T00:09:07+00:00

We use at least two flow dissectors in network stack, with known
limitations and code duplication.

Introduce skb_flow_dissect() to factorize this, highly inspired from
existing dissector from __skb_get_rxhash()

Note : We extensively use skb_header_pointer(), this permits us to not
touch skb at all.

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller