linux-toradex.git/include/net/ip.h, branch v3.2.59

inet: fix addr_len/msg->msg_namelen assignment in recv_error and rxpmtu functions

2014-01-03T04:33:33+00:00

[ Upstream commit 85fbaa75037d0b6b786ff18658ddf0b4014ce2a4 ]

Commit bceaa90240b6019ed73b49965eac7d167610be69 ("inet: prevent leakage
of uninitialized memory to user in recv syscalls") conditionally updated
addr_len if the msg_name is written to. The recv_error and rxpmtu
functions relied on the recvmsg functions to set up addr_len before.

As this does not happen any more we have to pass addr_len to those
functions as well and set it to the size of the corresponding sockaddr
length.

This broke traceroute and such.

Fixes: bceaa90240b6 ("inet: prevent leakage of uninitialized memory to user in recv syscalls")
Reported-by: Brad Spengler 
Reported-by: Tom Labanowski
Cc: mpb 
Cc: David S. Miller 
Cc: Eric Dumazet 
Signed-off-by: Hannes Frederic Sowa 
Signed-off-by: David S. Miller 
Signed-off-by: Ben Hutchings

ip: generate unique IP identificator if local fragmentation is allowed

2013-10-26T20:06:08+00:00

[ Upstream commit 703133de331a7a7df47f31fb9de51dc6f68a9de8 ]

If local fragmentation is allowed, then ip_select_ident() and
ip_select_ident_more() need to generate unique IDs to ensure
correct defragmentation on the peer.

For example, if IPsec (tunnel mode) has to encrypt large skbs
that have local_df bit set, then all IP fragments that belonged
to different ESP datagrams would have used the same identificator.
If one of these IP fragments would get lost or reordered, then
peer could possibly stitch together wrong IP fragments that did
not belong to the same datagram. This would lead to a packet loss
or data corruption.

Signed-off-by: Ansis Atteka 
Signed-off-by: David S. Miller 
Signed-off-by: Ben Hutchings

ipv4: tcp: fix TOS value in ACK messages sent from TIME_WAIT

2011-10-24T07:06:21+00:00

There is a long standing bug in linux tcp stack, about ACK messages sent
on behalf of TIME_WAIT sockets.

In the IP header of the ACK message, we choose to reflect TOS field of
incoming message, and this might break some setups.

Example of things that were broken :
  - Routing using TOS as a selector
  - Firewalls
  - Trafic classification / shaping

We now remember in timewait structure the inet tos field and use it in
ACK generation, and route lookup.

Notes :
 - We still reflect incoming TOS in RST messages.
 - We could extend MuraliRaja Muniraju patch to report TOS value in
netlink messages for TIME_WAIT sockets.
 - A patch is needed for IPv6

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

macvlan: handle fragmented multicast frames

2011-10-19T03:22:07+00:00

Fragmented multicast frames are delivered to a single macvlan port,
because ip defrag logic considers other samples are redundant.

Implement a defrag step before trying to send the multicast frame.

Reported-by: Ben Greear 
Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

ipv4: Add ip_defrag() agent IP_DEFRAG_AF_PACKET.

2011-07-06T05:34:52+00:00

Elide the ICMP on frag queue timeouts unconditionally for
this user.

Signed-off-by: David S. Miller

net: Fix build failures due to ip_is_fragment()

2011-06-24T04:28:52+00:00

It needs to be available even when CONFIG_INET is not set.

Reported-by: Stephen Rothwell 
Reported-by: Randy Dunlap 
Signed-off-by: David S. Miller

ip: introduce ip_is_fragment helper inline function

2011-06-22T03:33:34+00:00

There are enough instances of this:

    iph->frag_off & htons(IP_MF | IP_OFFSET)

that a helper function is probably warranted.

Signed-off-by: Paul Gortmaker 
Signed-off-by: David S. Miller

inetpeer: remove unused list

2011-06-09T00:05:30+00:00

Andi Kleen and Tim Chen reported huge contention on inetpeer
unused_peers.lock, on memcached workload on a 40 core machine, with
disabled route cache.

It appears we constantly flip peers refcnt between 0 and 1 values, and
we must insert/remove peers from unused_peers.list, holding a contended
spinlock.

Remove this list completely and perform a garbage collection on-the-fly,
at lookup time, using the expired nodes we met during the tree
traversal.

This removes a lot of code, makes locking more standard, and obsoletes
two sysctls (inet_peer_gc_mintime and inet_peer_gc_maxtime). This also
removes two pointers in inet_peer structure.

There is still a false sharing effect because refcnt is in first cache
line of object [were the links and keys used by lookups are located], we
might move it at the end of inet_peer structure to let this first cache
line mostly read by cpus.

Signed-off-by: Eric Dumazet 
CC: Andi Kleen 
CC: Tim Chen 
Signed-off-by: David S. Miller

ipv4: Pass explicit daddr arg to ip_send_reply().

2011-05-10T20:32:46+00:00

This eliminates an access to rt->rt_src.

Signed-off-by: David S. Miller

ipv4: Pass flow key down into ip_append_*().

2011-05-09T04:24:07+00:00

This way rt->rt_dst accesses are unnecessary.

Signed-off-by: David S. Miller