linux-toradex.git/include/net/ip_fib.h, branch v4.11-rc3

ipv4: fib: Add events for FIB replace and append

2017-02-10T16:32:13+00:00

The FIB notification chain currently uses the NLM_F_{REPLACE,APPEND}
flags to signal routes being replaced or appended.

Instead of using netlink flags for in-kernel notifications we can simply
introduce two new events in the FIB notification chain. This has the
added advantage of making the API cleaner, thereby making it clear that
these events should be supported by listeners of the notification chain.

Signed-off-by: Ido Schimmel 
Signed-off-by: Jiri Pirko 
CC: Patrick McHardy 
Signed-off-by: David S. Miller

ipv4: fib: Notify about nexthop status changes

2017-02-08T20:25:18+00:00

When a multipath route is hit the kernel doesn't consider nexthops that
are DEAD or LINKDOWN when IN_DEV_IGNORE_ROUTES_WITH_LINKDOWN is set.
Devices that offload multipath routes need to be made aware of nexthop
status changes. Otherwise, the device will keep forwarding packets to
non-functional nexthops.

Add the FIB_EVENT_NH_{ADD,DEL} events to the fib notification chain,
which notify capable devices when they should add or delete a nexthop
from their tables.

Cc: Roopa Prabhu 
Cc: David Ahern 
Cc: Andy Gospodarek 
Signed-off-by: Ido Schimmel 
Signed-off-by: Jiri Pirko 
Reviewed-by: Andy Gospodarek 
Signed-off-by: David S. Miller

net: ipv4: make fib_select_default static

2017-01-06T20:57:50+00:00

fib_select_default has a single caller within the same file.
Make it static.

Signed-off-by: David Ahern 
Signed-off-by: David S. Miller

ipv4: fib: Replay events when registering FIB notifier

2016-12-04T00:29:35+00:00

Commit b90eb7549499 ("fib: introduce FIB notification infrastructure")
introduced a new notification chain to notify listeners (f.e., switchdev
drivers) about addition and deletion of routes.

However, upon registration to the chain the FIB tables can already be
populated, which means potential listeners will have an incomplete view
of the tables.

Solve that by dumping the FIB tables and replaying the events to the
passed notification block. The dump itself is done using RCU in order
not to starve consumers that need RTNL to make progress.

The integrity of the dump is ensured by reading the FIB change sequence
counter before and after the dump under RTNL. This allows us to avoid
the problematic situation in which the dumping process sends a ENTRY_ADD
notification following ENTRY_DEL generated by another process holding
RTNL.

Callers of the registration function may pass a callback that is
executed in case the dump was inconsistent with current FIB tables.

The number of retries until a consistent dump is achieved is set to a
fixed number to prevent callers from looping for long periods of time.
In case current limit proves to be problematic in the future, it can be
easily converted to be configurable using a sysctl.

Signed-off-by: Ido Schimmel 
Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

ipv4: fib: Add fib_info_hold() helper

2016-12-04T00:29:35+00:00

As explained in the previous commit, modules are going to need to take a
reference on fib info and then drop it using fib_info_put().

Add the fib_info_hold() helper to make the code more readable and also
symmetric with fib_info_put().

Signed-off-by: Ido Schimmel 
Suggested-by: Jiri Pirko 
Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

ipv4: Restore fib_trie_flush_external function and fix call ordering

2016-11-16T18:24:50+00:00

The patch that removed the FIB offload infrastructure was a bit too
aggressive and also removed code needed to clean up us splitting the table
if additional rules were added.  Specifically the function
fib_trie_flush_external was called at the end of a new rule being added to
flush the foreign trie entries from the main trie.

I updated the code so that we only call fib_trie_flush_external on the main
table so that we flush the entries for local from main.  This way we don't
call it for every rule change which is what was happening previously.

Fixes: 347e3b28c1ba2 ("switchdev: remove FIB offload infrastructure")
Reported-by: Eric Dumazet 
Cc: Jiri Pirko 
Signed-off-by: Alexander Duyck 
Acked-by: Eric Dumazet 
Signed-off-by: David S. Miller

switchdev: remove FIB offload infrastructure

2016-09-28T08:48:00+00:00

Since this is now taken care of by FIB notifier, remove the code, with
all unused dependencies.

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

fib: introduce FIB info offload flag helpers

2016-09-28T08:48:00+00:00

These helpers are to be used in case someone offloads the FIB entry. The
result is that if the entry is offloaded to at least one device, the
offload flag is set.

Signed-off-by: Jiri Pirko 
Reviewed-by: Ido Schimmel 
Signed-off-by: David S. Miller

fib: introduce FIB notification infrastructure

2016-09-28T08:48:00+00:00

This allows to pass information about added/deleted FIB entries/rules to
whoever is interested. This is done in a very similar way as devinet
notifies address additions/removals.

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

net: Don't delete routes in different VRFs

2016-09-06T20:56:13+00:00

When deleting an IP address from an interface, there is a clean-up of
routes which refer to this local address. However, there was no check to
see that the VRF matched. This meant that deletion wasn't confined to
the VRF it should have been.

To solve this, a new field has been added to fib_info to hold a table
id. When removing fib entries corresponding to a local ip address, this
table id is also used in the comparison.

The table id is populated when the fib_info is created. This was already
done in some places, but not in ip_rt_ioctl(). This has now been fixed.

Fixes: 021dd3b8a142 ("net: Add routes to the table associated with the device")
Acked-by: David Ahern 
Tested-by: David Ahern 
Signed-off-by: Mark Tomlinson 
Signed-off-by: David S. Miller