linux-toradex.git/include/net/llc.h, branch v5.0

llc: avoid blocking in llc_sap_close()

2018-09-13T16:04:58+00:00

llc_sap_close() is called by llc_sap_put() which
could be called in BH context in llc_rcv(). We can't
block in BH.

There is no reason to block it here, kfree_rcu() should
be sufficient.

Signed-off-by: Cong Wang 
Signed-off-by: David S. Miller

llc: use refcount_inc_not_zero() for llc_sap_find()

2018-08-07T22:54:00+00:00

llc_sap_put() decreases the refcnt before deleting sap
from the global list. Therefore, there is a chance
llc_sap_find() could find a sap with zero refcnt
in this global list.

Close this race condition by checking if refcnt is zero
or not in llc_sap_find(), if it is zero then it is being
removed so we can just treat it as gone.

Reported-by: 
Signed-off-by: Cong Wang 
Signed-off-by: David S. Miller

net, llc: convert llc_sap.refcnt from atomic_t to refcount_t

2017-07-04T21:35:15+00:00

refcount_t type and corresponding API should be
used instead of atomic_t when the variable is used as
a reference counter. This allows to avoid accidental
refcounter overflows that might lead to use-after-free
situations.

Signed-off-by: Elena Reshetova 
Signed-off-by: Hans Liljestrand 
Signed-off-by: Kees Cook 
Signed-off-by: David Windsor 
Signed-off-by: David S. Miller

llc: make lock static

2014-01-04T01:56:48+00:00

The llc_sap_list_lock does not need to be global, only acquired
in core.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

llc*.h: Remove extern from function prototypes

2013-09-21T18:01:38+00:00

There are a mix of function prototypes with and without extern
in the kernel sources.  Standardize on not using extern for
function prototypes.

Function prototypes don't need to be written with extern.
extern is assumed by the compiler.  Its use is as unnecessary as
using auto to declare automatic/local variables in a block.

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

llc: Remove stray reference to sysctl_llc_station_ack_timeout.

2012-09-17T17:13:24+00:00

Signed-off-by: David S. Miller

llc2: Fix silent failure of llc_station_init()

2012-08-14T23:51:18+00:00

llc_station_init() creates and processes an event skb with no effect
other than to change the state from DOWN to UP.  Allocation failure is
reported, but then ignored by its caller, llc2_init().  Remove this
possibility by simply initialising the state as UP.

Signed-off-by: Ben Hutchings 
Signed-off-by: David S. Miller

atomic: use

2011-07-26T23:49:47+00:00

This allows us to move duplicated code in 
(atomic_inc_not_zero() for now) to 

Signed-off-by: Arun Sharma 
Reviewed-by: Eric Dumazet 
Cc: Ingo Molnar 
Cc: David Miller 
Cc: Eric Dumazet 
Acked-by: Mike Frysinger 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

llc: convert llc_sap_list to RCU

2009-12-27T04:46:28+00:00

Signed-off-by: Octavian Purdila 
Signed-off-by: David S. Miller

llc: replace the socket list with a local address based hash

2009-12-27T04:45:32+00:00

For the cases where a lot of interfaces are used in conjunction with a
lot of LLC sockets bound to the same SAP, the iteration of the socket
list becomes prohibitively expensive.

Replacing the list with a a local address based hash significantly
improves the bind and listener lookup operations as well as the
datagram delivery.

Connected sockets delivery is also improved, but this patch does not
address the case where we have lots of sockets with the same local
address connected to different remote addresses.

In order to keep the socket sanity checks alive and fast a socket
counter was added to the SAP structure.

Signed-off-by: Octavian Purdila 
Signed-off-by: David S. Miller