linux-toradex.git/include/net/llc_pdu.h, branch v5.0

net: llc: fix order of evaluation in llc_conn_ac_inc_vr_by_1

2014-01-02T03:22:43+00:00

Function llc_conn_ac_inc_vr_by_1() evaluates via macro
PDU_GET_NEXT_Vr() into ...

  llc_sk(sk)->vR = ++llc_sk(sk)->vR & 0xffffffffffffff7f

... but the order in which the side effects take place is
undefined because there is no intervening sequence point.

As llc_sk(sk)->vR is written in llc_sk(sk)->vR (assignment
left-hand side) and written in ++llc_sk(sk)->vR & 0xffffffffffffff7f
this might possibly yield undefined behavior.

The final value of llc_sk(sk)->vR is ambiguous, because,
depending on the order of expression evaluation, the
increment may occur before, after, or interleaved with
the assignment. In C, evaluating such an expression yields
undefined behavior.

Since we're doing the increment via PDU_GET_NEXT_Vr() macro
and the only place it is being used is from
llc_conn_ac_inc_vr_by_1(), in order to increment vR by 1
with a follow-up optimized modulo, rewrite the expression
into ((vR + 1) & CONST) in order to fix this.

Signed-off-by: Daniel Borkmann 
Cc: Arnaldo Carvalho de Melo 
Cc: Stephen Hemminger 
Signed-off-by: David S. Miller

llc*.h: Remove extern from function prototypes

2013-09-21T18:01:38+00:00

There are a mix of function prototypes with and without extern
in the kernel sources.  Standardize on not using extern for
function prototypes.

Function prototypes don't need to be written with extern.
extern is assumed by the compiler.  Its use is as unnecessary as
using auto to declare automatic/local variables in a block.

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

net: delete all instances of special processing for token ring

2012-05-16T00:14:35+00:00

We are going to delete the Token ring support.  This removes any
special processing in the core networking for token ring, (aside
from net/tr.c itself), leaving the drivers and remaining tokenring
support present but inert.

The mass removal of the drivers and net/tr.c will be in a separate
commit, so that the history of these files that we still care
about won't have the giant deletion tied into their history.

Signed-off-by: Paul Gortmaker

bonding,llc: Fix structure sizeof incompatibility for some PDUs

2011-05-13T19:13:24+00:00

With some combinations of arch/compiler (e.g. arm-linux-gcc) the sizeof
operator on structure returns value greater than expected. In cases when the
structure is used for mapping PDU fields it may lead to unexpected results
(such as holes and alignment problems in skb data). __packed prevents this
undesired behavior.

Signed-off-by: Vitalii Demianets 
Signed-off-by: David S. Miller

[LLC]: skb allocation size for responses

2008-04-01T04:02:47+00:00

Allocate the skb for llc responses with the received packet size by
using the size adjustable llc_frame_alloc.
Don't allocate useless extra payload.
Cleanup magic numbers.

So, this fixes oops.
Reported by Jim Westfall:
kernel: skb_over_panic: text:c0541fc7 len:1000 put:997 head:c166ac00 data:c166ac2f tail:0xc166b017 end:0xc166ac80 dev:eth0
kernel: ------------[ cut here ]------------
kernel: kernel BUG at net/core/skbuff.c:95!

Signed-off-by: Joonwoo Park 
Acked-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[SK_BUFF]: Introduce skb_network_header()

2007-04-26T05:24:59+00:00

For the places where we need a pointer to the network header, it is still legal
to touch skb->nh.raw directly if just adding to, subtracting from or setting it
to another layer header.

Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[SK_BUFF]: Introduce skb_reset_network_header(skb)

2007-04-26T05:24:46+00:00

For the common, open coded 'skb->nh.raw = skb->data' operation, so that we can
later turn skb->nh.raw into a offset, reducing the size of struct sk_buff in
64bit land while possibly keeping it as a pointer on 32bit.

This one touches just the most simple case, next will handle the slightly more
"complex" cases.

Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[LLC]: Kill llc_set_pdu_hdr

2007-04-26T05:24:42+00:00

We'll have skb_reset_network_header soon.

Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[LLC]: anotations

2006-12-03T05:21:23+00:00

Signed-off-by: Al Viro 
Signed-off-by: David S. Miller

[LLC]: Fix typo

2005-11-15T05:58:18+00:00

Signed-off-by: Jochen Friedrich 
Acked-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller