linux-toradex.git/include/net/nexthop.h, branch v5.10-rc2

nexthop: Remove NEXTHOP_EVENT_ADD

2020-09-15T23:31:11+00:00

Not used anywhere.

Signed-off-by: Ido Schimmel 
Suggested-by: David Ahern 
Signed-off-by: David S. Miller

nexthop: Remove unused function declaration from header file

2020-09-15T23:31:03+00:00

Not used or implemented anywhere.

Signed-off-by: Ido Schimmel 
Reviewed-by: David Ahern 
Signed-off-by: David S. Miller

vxlan: Remove access to nexthop group struct

2020-06-10T20:20:20+00:00

vxlan driver should be using helpers to access nexthop struct
internals. Remove open check if whether nexthop is multipath in
favor of the existing nexthop_is_multipath helper. Add a new
helper, nexthop_has_v4, to cover the need to check has_v4 in
a group.

Fixes: 1274e1cc4226 ("vxlan: ecmp support for mac fdb entries")
Cc: Roopa Prabhu 
Signed-off-by: David Ahern 
Signed-off-by: David S. Miller

nexthop: Fix fdb labeling for groups

2020-06-10T20:18:40+00:00

fdb nexthops are marked with a flag. For standalone nexthops, a flag was
added to the nh_info struct. For groups that flag was added to struct
nexthop when it should have been added to the group information. Fix
by removing the flag from the nexthop struct and adding a flag to nh_group
that mirrors nh_info and is really only a caching of the individual types.
Add a helper, nexthop_is_fdb, for use by the vxlan code and fixup the
internal code to use the flag from either nh_info or nh_group.

v2
- propagate fdb_nh in remove_nh_grp_entry

Fixes: 38428d68719c ("nexthop: support for fdb ecmp nexthops")
Cc: Roopa Prabhu 
Signed-off-by: David Ahern 
Signed-off-by: David S. Miller

Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net

2020-06-01T00:48:46+00:00

xdp_umem.c had overlapping changes between the 64-bit math fix
for the calculation of npgs and the removal of the zerocopy
memory type which got rid of the chunk_size_nohdr member.

The mlx5 Kconfig conflict is a case where we just take the
net-next copy of the Kconfig entry dependency as it takes on
the ESWITCH dependency by one level of indirection which is
what the 'net' conflicting change is trying to ensure.

Signed-off-by: David S. Miller

ipv4: nexthop version of fib_info_nh_uses_dev

2020-05-26T23:06:07+00:00

Similar to the last path, need to fix fib_info_nh_uses_dev for
external nexthops to avoid referencing multiple nh_grp structs.
Move the device check in fib_info_nh_uses_dev to a helper and
create a nexthop version that is called if the fib_info uses an
external nexthop.

Fixes: 430a049190de ("nexthop: Add support for nexthop groups")
Signed-off-by: David Ahern 
Acked-by: Nikolay Aleksandrov 
Signed-off-by: David S. Miller

ipv4: Refactor nhc evaluation in fib_table_lookup

2020-05-26T23:06:07+00:00

FIB lookups can return an entry that references an external nexthop.
While walking the nexthop struct we do not want to make multiple calls
into the nexthop code which can result in 2 different structs getting
accessed - one returning the number of paths the rest of the loop
seeing a different nh_grp struct. If the nexthop group shrunk, the
result is an attempt to access a fib_nh_common that does not exist for
the new nh_grp struct but did for the old one.

To fix that move the device evaluation code to a helper that can be
used for inline fib_nh path as well as external nexthops.

Update the existing check for fi->nh in fib_table_lookup to call a
new helper, nexthop_get_nhc_lookup, which walks the external nexthop
with a single rcu dereference.

Fixes: 430a049190de ("nexthop: Add support for nexthop groups")
Signed-off-by: David Ahern 
Acked-by: Nikolay Aleksandrov 
Signed-off-by: David S. Miller

nexthop: Expand nexthop_is_multipath in a few places

2020-05-26T23:06:07+00:00

I got too fancy consolidating checks on multipath type. The result
is that path lookups can access 2 different nh_grp structs as exposed
by Nik's torture tests. Expand nexthop_is_multipath within nexthop.h to
avoid multiple, nh_grp dereferences and make decisions based on the
consistent struct.

Only 2 places left using nexthop_is_multipath are within IPv6, both
only check that the nexthop is a multipath for a branching decision
which are acceptable.

Fixes: 430a049190de ("nexthop: Add support for nexthop groups")
Signed-off-by: David Ahern 
Acked-by: Nikolay Aleksandrov 
Signed-off-by: David S. Miller

nexthops: don't modify published nexthop groups

2020-05-26T23:06:06+00:00

We must avoid modifying published nexthop groups while they might be
in use, otherwise we might see NULL ptr dereferences. In order to do
that we allocate 2 nexthoup group structures upon nexthop creation
and swap between them when we have to delete an entry. The reason is
that we can't fail nexthop group removal, so we can't handle allocation
failure thus we move the extra allocation on creation where we can
safely fail and return ENOMEM.

Fixes: 430a049190de ("nexthop: Add support for nexthop groups")
Signed-off-by: Nikolay Aleksandrov 
Signed-off-by: David Ahern 
Signed-off-by: David S. Miller

nexthop: add support for notifiers

2020-05-22T21:00:38+00:00

This patch adds nexthop add/del notifiers. To be used by
vxlan driver in a later patch. Could possibly be used by
switchdev drivers in the future.

Signed-off-by: Roopa Prabhu 
Signed-off-by: David S. Miller