linux-toradex.git/include/rdma, branch v4.18-rc4

Merge tag 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma

2018-06-20T22:22:30+00:00

Pull rdma fixes from Jason Gunthorpe:
 "Here are eight fairly small fixes collected over the last two weeks.

  Regression and crashing bug fixes:

   - mlx4/5: Fixes for issues found from various checkers

   - A resource tracking and uverbs regression in the core code

   - qedr: NULL pointer regression found during testing

   - rxe: Various small bugs"

* tag 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma:
  IB/rxe: Fix missing completion for mem_reg work requests
  RDMA/core: Save kernel caller name when creating CQ using ib_create_cq()
  IB/uverbs: Fix ordering of ucontext check in ib_uverbs_write
  IB/mlx4: Fix an error handling path in 'mlx4_ib_rereg_user_mr()'
  RDMA/qedr: Fix NULL pointer dereference when running over iWARP without RDMA-CM
  IB/mlx5: Fix return value check in flow_counters_set_data()
  IB/mlx5: Fix memory leak in mlx5_ib_create_flow
  IB/rxe: avoid double kfree skb

RDMA/core: Save kernel caller name when creating CQ using ib_create_cq()

2018-06-18T17:32:58+00:00

Few kernel applications like SCST-iSER create CQ using ib_create_cq(),
where accessing CQ structures using rdma restrack tool leads to below NULL
pointer dereference. This patch saves caller kernel module name similar to
ib_alloc_cq().

BUG: unable to handle kernel NULL pointer dereference at           (null)
IP: [] skip_spaces+0x30/0x30
PGD 738bac067 PUD 8533f0067 PMD 0
Oops: 0000 [#1] SMP
R10: ffff88017fc03300 R11: 0000000000000246 R12: 0000000000000000
R13: ffff88082fa5a668 R14: ffff88017475a000 R15: 0000000000000000
FS:  00002b32726582c0(0000) GS:ffff88087fc40000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000000000 CR3: 00000008491a1000 CR4: 00000000003607e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 [] ? fill_res_name_pid+0x7c/0x90 [ib_core]
 [] fill_res_cq_entry+0xef/0x170 [ib_core]
 [] res_get_common_dumpit+0x3c4/0x480 [ib_core]
 [] nldev_res_get_cq_dumpit+0x13/0x20 [ib_core]
 [] netlink_dump+0x117/0x2e0
 [] __netlink_dump_start+0x1ab/0x230
 [] ibnl_rcv_msg+0x11d/0x1f0 [ib_core]
 [] ? nldev_res_get_mr_dumpit+0x20/0x20 [ib_core]
 [] ? rdma_nl_multicast+0x30/0x30 [ib_core]
 [] netlink_rcv_skb+0xa9/0xc0
 [] ibnl_rcv+0x98/0xb0 [ib_core]
 [] netlink_unicast+0xf2/0x1b0
 [] netlink_sendmsg+0x31f/0x6a0
 [] sock_sendmsg+0xb0/0xf0
 [] ? _raw_spin_unlock_bh+0x1e/0x20
 [] ? release_sock+0x118/0x170
 [] SYSC_sendto+0x121/0x1c0
 [] ? sock_alloc_file+0xa0/0x140
 [] ? __fd_install+0x25/0x60
 [] SyS_sendto+0xe/0x10
 [] system_call_fastpath+0x16/0x1b
RIP  [] skip_spaces+0x30/0x30
RSP 
CR2: 0000000000000000

Cc: 
Fixes: f66c8ba4c9fa ("RDMA/core: Save kernel caller name when creating PD and CQ objects")
Reviewed-by: Steve Wise 
Signed-off-by: Potnuri Bharat Teja 
Reviewed-by: Leon Romanovsky 
Signed-off-by: Jason Gunthorpe

Convert infiniband uverbs to struct_size

2018-06-12T23:19:22+00:00

The flows were hidden from the C compiler; expose them as a zero-length
array to allow struct_size to work.

Signed-off-by: Matthew Wilcox 
Signed-off-by: Kees Cook

RDMA/restrack: Change SPDX tag to properly reflect license

2018-06-05T20:04:20+00:00

Resource tracking is supposed to be dual licensed: GPL-2.0 and
OpenIB, but the SPDX tag was not compliant to it. Update the tag to
properly reflect license.

Fixes: 02d8883f520e ("RDMA/restrack: Add general infrastructure to track RDMA resources")
Signed-off-by: Leon Romanovsky 
Signed-off-by: Jason Gunthorpe

RDMA/core: introduce check masks for T10-PI offload

2018-06-04T15:19:24+00:00

T10-PI offload capability is currently supported in iSER protocol only,
and the definition of the HCA protection information checks are missing
from the core layer. Add those definition to avoid code duplication in
other drivers (such iSER target and NVMeoF).

Reviewed-by: Christoph Hellwig 
Reviewed-by: Sagi Grimberg 
Reviewed-by: Martin K. Petersen 
Signed-off-by: Max Gurtovoy 
Signed-off-by: Jason Gunthorpe

Merge tag 'verbs_flow_counters' of git://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git into for-next

2018-06-04T14:48:11+00:00

Pull verbs counters series from Leon Romanovsky:

====================
Verbs flow counters support

This series comes to allow user space applications to monitor real time
traffic activity and events of the verbs objects it manages, e.g.: ibv_qp,
ibv_wq, ibv_flow.

The API enables generic counters creation and define mapping to
association with a verbs object, the current mlx5 driver is using this API
for flow counters.

With this API, an application can monitor the entire life cycle of object
activity, defined here as a static counters attachment.  This API also
allows dynamic counters monitoring of measurement points for a partial
period in the verbs object life cycle.

In addition it presents the implementation of the generic counters
interface.

This will be achieved by extending flow creation by adding a new flow
count specification type which allows the user to associate a previously
created flow counters using the generic verbs counters interface to the
created flow, once associated the user could read statistics by using the
read function of the generic counters interface.

The API includes:
1. create and destroyed API of a new counters objects
2. read the counters values from HW

Note:
Attaching API to allow application to define the measurement points per
objects is a user space only API and this data is passed to kernel when
the counted object (e.g. flow) is created with the counters object.
===================

* tag 'verbs_flow_counters':
  IB/mlx5: Add counters read support
  IB/mlx5: Add flow counters read support
  IB/mlx5: Add flow counters binding support
  IB/mlx5: Add counters create and destroy support
  IB/uverbs: Add support for flow counters
  IB/core: Add support for flow counters
  IB/core: Support passing uhw for create_flow
  IB/uverbs: Add read counters support
  IB/core: Introduce counters read verb
  IB/uverbs: Add create/destroy counters support
  IB/core: Introduce counters object and its create/destroy
  IB/uverbs: Add an ib_uobject getter to ioctl() infrastructure
  net/mlx5: Export flow counter related API
  net/mlx5: Use flow counter pointer as input to the query function

IB/core: Add support for flow counters

2018-06-02T04:33:56+00:00

A counters object could be attached to flow on creation by providing the
counter specification action.

General counters description which count packets and bytes are introduced,
downstream patches from this series will use them as part of flow counters
binding.

In addition, increase number of flow specifications supported layers to 10
upon adding count specification and for the previously added drop
specification.

Reviewed-by: Yishai Hadas 
Signed-off-by: Raed Salem 
Signed-off-by: Leon Romanovsky 
Signed-off-by: Jason Gunthorpe

IB/core: Support passing uhw for create_flow

2018-06-02T04:33:55+00:00

This is required when user-space drivers need to pass extra information
regarding how to handle this flow steering specification.

Reviewed-by: Yishai Hadas 
Signed-off-by: Matan Barak 
Signed-off-by: Boris Pismenny 
Signed-off-by: Leon Romanovsky 
Signed-off-by: Jason Gunthorpe

IB/core: Introduce counters read verb

2018-06-02T04:33:54+00:00

The user supplies counters instance and a reference to an output array of
uint64_t.  The driver reads the hardware counters values and writes them
to the output index location in the user supplied array.  All counters
values are represented as uint64_t types.

To be able to successfully read the data the counters must be first bound
to an IB object.

Downstream patches will present binding method for flow counters.

Reviewed-by: Yishai Hadas 
Signed-off-by: Raed Salem 
Signed-off-by: Leon Romanovsky 
Signed-off-by: Jason Gunthorpe

IB/core: Introduce counters object and its create/destroy

2018-06-02T04:33:54+00:00

A verbs application may need to get statistics and info on various aspects
of a verb object (e.g. Flow, QP, ...), in general case the application
will state which object's counters its interested in (we refer to this
action as attach), bind this new counters object to the appropriate verb
object and on later stage read their values using the counters object.

This series introduces a general API for counters object that may
accumulate any ib object counters type, bound and read on demand.

Counters instance is allocated on an IB context and belongs to that
context.  Upon successful creation the counters can be bound to a verbs
object so that hardware counter instances can be created and read.

Downstream patches in this series will introduce the attach, bind and the
read functionality.

Counters instance can be de-allocated, upon successful destruction the
related hardware resources are released.

Prior to destroy call the user must first make sure that the counters is
not being used by any IB object, e.g. not attached to any of its counted
type otherwise an EBUSY error is invoked.

Reviewed-by: Yishai Hadas 
Signed-off-by: Raed Salem 
Signed-off-by: Leon Romanovsky 
Signed-off-by: Jason Gunthorpe