linux-toradex.git/include/scsi/libsas.h, branch v6.4

scsi: libsas: Change the coding style of sas_discover_sata()

2022-12-30T16:59:10+00:00

The coding style where calling this interface is inconsistent with other
interfaces for SATA devices. The standard style for other SATA interfaces
is like:

    #ifdefine CONFIG_SCSI_SAS_ATA
    void sas_ata_task_abort(struct sas_task *task);
    #else
    static inline void sas_ata_task_abort(struct sas_task *task)
    {
    }
    #endif

And the callers does not have to do things like "#ifdefine CONFIG_SCSI_SAS_ATA"
and may call the interface directly. So follow the standard style here.

Cc: John Garry 
Signed-off-by: Jason Yan 
Reviewed-by: Jack Wang 
Reviewed-by: John Garry 
Signed-off-by: Martin K. Petersen

scsi: libsas: Add sas_task_find_rq()

2022-10-22T03:02:51+00:00

blk-mq already provides a unique tag per request. Some libsas LLDDs - like
hisi_sas - already use this tag as the unique per-I/O HW tag.

Add a common function to provide the request associated with a sas_task for
all libsas LLDDs.

Signed-off-by: John Garry 
Link: https://lore.kernel.org/r/1666091763-11023-2-git-send-email-john.garry@huawei.com
Reviewed-by: Jack Wang 
Reviewed-by: Jason Yan 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Martin K. Petersen

scsi: libsas: Introduce sas_find_attached_phy_id() helper

2022-10-18T03:28:09+00:00

LLDDs are all implementing their own attached phy ID finding code.  Factor
it out to libsas.

Signed-off-by: Jason Yan 
Link: https://lore.kernel.org/r/20220928070130.3657183-3-yanaijie@huawei.com
Reviewed-by: Jack Wang 
Reviewed-by: Damien Le Moal 
Reviewed-by: John Garry 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

scsi: libsas: Make sas_{alloc, alloc_slow, free}_task() private

2022-10-18T02:37:45+00:00

We have no users outside libsas any longer, so make sas_alloc_task(),
sas_alloc_slow_task(), and sas_free_task() private.

Signed-off-by: John Garry 
Link: https://lore.kernel.org/r/1665998435-199946-8-git-send-email-john.garry@huawei.com
Tested-by: Damien Le Moal 
Tested-by: Niklas Cassel  # pm80xx
Reviewed-by: Jason Yan 
Signed-off-by: Martin K. Petersen

scsi: libsas: Introduce struct smp_rps_resp

2022-06-10T17:08:06+00:00

Similarly to sas report general and discovery responses, define the
structure struct smp_rps_resp to handle SATA PHY report responses using a
structure with a size that is exactly equal to the sas defined response
size.

With this change, struct smp_resp becomes unused and is removed.

Link: https://lore.kernel.org/r/20220609022456.409087-4-damien.lemoal@opensource.wdc.com
Reviewed-by: John Garry 
Signed-off-by: Damien Le Moal 
Signed-off-by: Martin K. Petersen

scsi: hisi_sas: Use libsas internal abort support

2022-03-15T03:33:24+00:00

Use the common libsas internal abort functionality.

In addition, this driver has special handling for internal abort timeouts -
specifically whether to reset the controller in that instance, so extend
the API for that.

Timeout is now increased to 20 * Hz from 6 * Hz.

We also retry for failure now, but this should not make a difference.

Link: https://lore.kernel.org/r/1647001432-239276-5-git-send-email-john.garry@huawei.com
Tested-by: Damien Le Moal 
Acked-by: Jack Wang 
Signed-off-by: John Garry 
Signed-off-by: Martin K. Petersen

scsi: libsas: Add sas_execute_internal_abort_dev()

2022-03-15T03:33:23+00:00

Add support for a "device" variant of internal abort, which will abort all
pending I/Os for a specific device.

Link: https://lore.kernel.org/r/1647001432-239276-3-git-send-email-john.garry@huawei.com
Tested-by: Damien Le Moal 
Acked-by: Jack Wang 
Signed-off-by: John Garry 
Signed-off-by: Martin K. Petersen

scsi: libsas: Add sas_execute_internal_abort_single()

2022-03-15T03:33:23+00:00

The internal abort feature is common to hisi_sas and pm8001 HBAs, and the
driver support is similar also, so add a common handler.

Two modes of operation will be supported:

 - single: Abort a single tagged command

 - device: Abort all commands associated with a specific domain device

A new protocol is added, SAS_PROTOCOL_INTERNAL_ABORT, so the common queue
command API may be re-used.

Only add "single" support as a first step.

Link: https://lore.kernel.org/r/1647001432-239276-2-git-send-email-john.garry@huawei.com
Tested-by: Damien Le Moal 
Acked-by: Jack Wang 
Signed-off-by: John Garry 
Signed-off-by: Martin K. Petersen

scsi: libsas: Make sas_notify_{phy,port}_event() return void

2022-02-28T02:48:29+00:00

Nobody checks the return codes, so make them return void. Indeed, if the
LLDD cannot send an event, nothing much can be done in the LLDD about it.

Also remove prototype for sas_notify_phy_event() in sas_internal.h, which
should not be there.

Link: https://lore.kernel.org/r/1645786656-221630-2-git-send-email-john.garry@huawei.com
Reviewed-by: Xiang Chen 
Reviewed-by: Damien Le Moal 
Signed-off-by: John Garry 
Signed-off-by: Martin K. Petersen

scsi: libsas: Add sas_execute_ata_cmd()

2022-02-23T02:11:02+00:00

Add a function to execute an ATA command using the TMF code, and use in the
hisi_sas driver. That driver needs to be able to issue the command on a
specific phy, so add an interface for that.

With that, hisi_sas_exec_internal_tmf_task() may be deleted.

Link: https://lore.kernel.org/r/1645534259-27068-19-git-send-email-john.garry@huawei.com
Tested-by: Yihang Li 
Tested-by: Damien Le Moal 
Reviewed-by: Christoph Hellwig 
Signed-off-by: John Garry 
Signed-off-by: Martin K. Petersen