linux-toradex.git/include/scsi/scsi_cmnd.h, branch v3.14.50

[SCSI] improved eh timeout handler

2013-12-19T15:39:02+00:00

When a command runs into a timeout we need to send an 'ABORT TASK'
TMF. This is typically done by the 'eh_abort_handler' LLDD callback.

Conceptually, however, this function is a normal SCSI command, so
there is no need to enter the error handler.

This patch implements a new scsi_abort_command() function which
invokes an asynchronous function scsi_eh_abort_handler() to
abort the commands via the usual 'eh_abort_handler'.

If abort succeeds the command is either retried or terminated,
depending on the number of allowed retries. However, 'eh_eflags'
records the abort, so if the retry would fail again the
command is pushed onto the error handler without trying to
abort it (again); it'll be cleared up from SCSI EH.

[hare: smatch detected stray switch fixed]
Signed-off-by: Hannes Reinecke 
Signed-off-by: James Bottomley

[SCSI] Shorten the path length of scsi_cmd_to_driver()

2012-10-09T11:04:42+00:00

This patch tries to shorten the path length of scsi_cmd_to_driver(). As only
REQ_TYPE_BLOCK_PC commands can be submitted without a driver, so we could
avoid the related NULL checking, as long as we make sure we don't use it for
REQ_TYPE_BLOCK_PC type commands. Plus, this fixes a bug where you get
different behaviors from REQ_TYPE_BLOCK_PC commands when a driver is and isn't
attached.

Signed-off-by: Li Zhong 
Reviewed-by: Martin K. Petersen 
Signed-off-by: James Bottomley

[SCSI] Fix NULL dereferences in scsi_cmd_to_driver

2012-07-08T08:40:51+00:00

Avoid crashing if the private_data pointer happens to be NULL. This has
been seen sometimes when a host reset happens, notably when there are
many LUNs:

host3: Assigned Port ID 0c1601
scsi host3: libfc: Host reset succeeded on port (0c1601)
BUG: unable to handle kernel NULL pointer dereference at 0000000000000350
IP: [] scsi_send_eh_cmnd+0x58/0x3a0

Process scsi_eh_3 (pid: 4144, threadinfo ffff88030920c000, task ffff880326b160c0)
Stack:
 000000010372e6ba 0000000000000282 000027100920dca0 ffffffffa0038ee0
 0000000000000000 0000000000030003 ffff88030920dc80 ffff88030920dc80
 00000002000e0000 0000000a00004000 ffff8803242f7760 ffff88031326ed80
Call Trace:
 [] ? lock_timer_base+0x70/0x70
 [] scsi_eh_tur+0x3e/0xc0
 [] scsi_eh_test_devices+0x76/0x170
 [] scsi_eh_host_reset+0x85/0x160
 [] scsi_eh_ready_devs+0x91/0x110
 [] scsi_unjam_host+0xed/0x1f0
 [] scsi_error_handler+0x1a8/0x200
 [] ? scsi_unjam_host+0x1f0/0x1f0
 [] kthread+0x9e/0xb0
 [] kernel_thread_helper+0x4/0x10
 [] ? kthread_freezable_should_stop+0x70/0x70
 [] ? gs_change+0x13/0x13
Code: 25 28 00 00 00 48 89 45 c8 31 c0 48 8b 87 80 00 00 00 48 8d b5 60 ff ff ff 89 d1 48 89 fb 41 89 d6 4c 89 fa 48 8b 80 b8 00 00 00
 <48> 8b 80 50 03 00 00 48 8b 00 48 89 85 38 ff ff ff 48 8b 07 4c
RIP  [] scsi_send_eh_cmnd+0x58/0x3a0
 RSP 
CR2: 0000000000000350


Signed-off-by: Mark Rustad 
Tested-by: Marcus Dennis 
Cc: 
Signed-off-by: James Bottomley

SCSI: Fix error handling when no ULD is attached

2012-04-15T18:08:53+00:00

Commit 18a4d0a22ed6 ("[SCSI] Handle disk devices which can not process
medium access commands") introduced a bug in which we would attempt to
dereference the scsi driver even when the device had no ULD attached.

Ensure that a driver is registered and make the driver accessor function
more resilient to errors during device discovery.

Reported-by: Elric Fu 
Reported-by: Bart Van Assche 
Signed-off-by: Martin K. Petersen 
Signed-off-by: Linus Torvalds

[SCSI] Handle disk devices which can not process medium access commands

2012-02-19T16:14:52+00:00

We have experienced several devices which fail in a fashion we do not
currently handle gracefully in SCSI. After a failure these devices will
respond to the SCSI primary command set (INQUIRY, TEST UNIT READY, etc.)
but any command accessing the storage medium will time out.

The following patch adds an callback that can be used by upper level
drivers to inspect the results of an error handling command. This in
turn has been used to implement additional checking in the SCSI disk
driver.

If a medium access command fails twice but TEST UNIT READY succeeds both
times in the subsequent error handling we will offline the device. The
maximum number of failed commands required to take a device offline can
be tweaked in sysfs.

Also add a new error flag to scsi_debug which allows this scenario to be
easily reproduced.

[jejb: fix up integer parsing to use kstrtouint]
Signed-off-by: Martin K. Petersen 
Signed-off-by: James Bottomley

[SCSI] Correctly set the scsi host/msg/status bytes

2012-02-19T14:08:59+00:00

Resubmitting as my previous post had format issues and did not go llinux-scsi.
This patch changes the function to set_msg_byte, set_host_byte and
set_driver_byte to correctly set the corresponding bytes appropriately.

It will reset the original setting and correctly set it to the new value.  The
previous OR operation does not always set it back to new value. Look at patch
2/2 for an example.

Signed-off-by: Babu Moger 
Signed-off-by: James Bottomley

[SCSI] Deprecate SCSI_PROT_*_CONVERT operations

2009-10-02T14:46:25+00:00

The checksum format is orthogonal to whether the protection information
is being passed on beyond the HBA or not.  It is perfectly valid to use
a non-T10 CRC with WRITE_STRIP and READ_INSERT.

Consequently it no longer makes sense to explicitly refer to the
conversion in the protection operation.  Update sd_dif and lpfc
accordingly.

Signed-off-by: Martin K. Petersen 
Acked-by: Ihab Hamadi 
Signed-off-by: James Bottomley

block: convert to pos and nr_sectors accessors

2009-05-11T07:50:54+00:00

With recent cleanups, there is no place where low level driver
directly manipulates request fields.  This means that the 'hard'
request fields always equal the !hard fields.  Convert all
rq->sectors, nr_sectors and current_nr_sectors references to
accessors.

While at it, drop superflous blk_rq_pos() < 0 test in swim.c.

[ Impact: use pos and nr_sectors accessors ]

Signed-off-by: Tejun Heo 
Acked-by: Geert Uytterhoeven 
Tested-by: Grant Likely 
Acked-by: Grant Likely 
Tested-by: Adrian McMenamin 
Acked-by: Adrian McMenamin 
Acked-by: Mike Miller 
Cc: James Bottomley 
Cc: Bartlomiej Zolnierkiewicz 
Cc: Borislav Petkov 
Cc: Sergei Shtylyov 
Cc: Eric Moore 
Cc: Alan Stern 
Cc: FUJITA Tomonori 
Cc: Pete Zaitcev 
Cc: Stephen Rothwell 
Cc: Paul Clements 
Cc: Tim Waugh 
Cc: Jeff Garzik 
Cc: Jeremy Fitzhardinge 
Cc: Alex Dubov 
Cc: David Woodhouse 
Cc: Martin Schwidefsky 
Cc: Dario Ballabio 
Cc: David S. Miller 
Cc: Rusty Russell 
Cc: unsik Kim 
Cc: Laurent Vivier 
Signed-off-by: Jens Axboe

[SCSI] Make scsi.h independent of the rest of the scsi includes

2009-03-12T17:58:13+00:00

This allows it to compile and be used on the ps3 platform that wants
to use the #define values in scsi.h without actually having
CONFIG_SCSI set.

Signed-off-by: James Bottomley

block: unify request timeout handling

2008-10-09T06:56:13+00:00

Right now SCSI and others do their own command timeout handling.
Move those bits to the block layer.

Instead of having a timer per command, we try to be a bit more clever
and simply have one per-queue. This avoids the overhead of having to
tear down and setup a timer for each command, so it will result in a lot
less timer fiddling.

Signed-off-by: Mike Anderson 
Signed-off-by: Jens Axboe