linux-toradex.git/include/scsi/scsi_dbg.h, branch v4.9.21

scsi: remove scsi_show_sense_hdr()

2015-12-02T21:36:14+00:00

Last caller is gone, so remove it.

Signed-off-by: Hannes Reinecke 
Reviewed-by: Bart Van Assche 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Martin K. Petersen 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

scsi: Conditionally compile in constants.c

2015-01-09T14:44:31+00:00

Instead of having constants.c littered with ifdef statements we should
be moving dummy functions into the header and condintionally compile in
constants.c if selected. And update the Kconfig description to reflect
the actual size difference.

Suggested-by: Christoph Hellwig 
Tested-by: Robert Elliott 
Reviewed-by: Robert Elliott 
Signed-off-by: Hannes Reinecke 
Signed-off-by: Christoph Hellwig

scsi: use per-cpu buffer for formatting scsi_print_result()

2015-01-09T14:44:31+00:00

Convert scsi_print_result() to use the per-cpu buffer for decoding the
command result and disposition.

Tested-by: Robert Elliott 
Reviewed-by: Robert Elliott 
Signed-off-by: Hannes Reinecke 
Signed-off-by: Christoph Hellwig

scsi: use external buffer for command logging

2015-01-09T14:44:29+00:00

Use an external buffer for __scsi_print_command() and move command
logging over to use the per-cpu logging buffer.  With that we can
guarantee the command always will always be formatted in one line.
So we can even print out a variable length command correctly across
several lines. Finally rename __scsi_print_command() to
__scsi_format_comment() to better reflect the functionality.

Tested-by: Robert Elliott 
Reviewed-by: Robert Elliott 
Signed-off-by: Hannes Reinecke 
Signed-off-by: Christoph Hellwig

scsi: simplify scsi_log_(send|completion)

2014-11-12T10:16:05+00:00

Simplify scsi_log_(send|completion) by externalizing
scsi_mlreturn_string() and always print the command address.

Signed-off-by: Hannes Reinecke 
Reviewed-by: Robert Elliott 
Signed-off-by: Christoph Hellwig

scsi: remove scsi_show_result()

2014-11-12T10:16:05+00:00

Open-code scsi_print_result in sd.c, and cleanup logging to
not print duplicate informations.
Also remove the call to scsi_show_result() in ufshcd.c
to be consistent with other callers of scsi_execute().

With that we can remove scsi_show_result in constants.c

Signed-off-by: Hannes Reinecke 
Reviewed-by: Robert Elliott 
Signed-off-by: Christoph Hellwig

scsi: separate out scsi_(host|driver)byte_string()

2014-11-12T10:16:04+00:00

Export functions for later use.

Signed-off-by: Hannes Reinecke 
Reviewed-by: Robert Elliott 
Signed-off-by: Christoph Hellwig

scsi: repurpose the last argument from print_opcode_name()

2014-11-12T10:16:03+00:00

print_opcode_name() was only ever called with a '0' argument
from LLDDs and ULDs which were _not_ supporting variable length
CDBs, so the 'if' clause was never triggered.
Instead we should be using the last argument to specify
the cdb length to avoid accidental overflow when reading
the cdb buffer.

Signed-off-by: Hannes Reinecke 
Reviewed-by: Robert Elliott 
Signed-off-by: Christoph Hellwig

scsi: remove scsi_print_status()

2014-11-12T10:16:02+00:00

Last caller is gone, so we can remove it.

Signed-off-by: Hannes Reinecke 
Reviewed-by: Robert Elliott 
Signed-off-by: Christoph Hellwig

scsi: use sdev as argument for sense code printing

2014-11-12T10:15:58+00:00

We should be using the standard dev_printk() variants for
sense code printing.

[hch: remove __scsi_print_sense call in xen-scsiback, Acked by Juergen]
[hch: folded bracing fix from Dan Carpenter]
Signed-off-by: Hannes Reinecke 
Reviewed-by: Robert Elliott 
Signed-off-by: Christoph Hellwig