linux-toradex.git/include/target/target_core_backend.h, branch v4.11

target: allow ALUA setup for some passthrough backends

2017-03-18T21:47:25+00:00

This patch allows passthrough backends to use the core/base LIO
ALUA setup and state checks, but still handle the execution of
commands.

This will allow the target_core_user module to execute STPG and RTPG
in userspace, and not have to duplicate the ALUA state checks, path
information (needed so we can check if command is executable on
specific paths) and setup (rtslib sets/updates the configfs ALUA
interface like it does for iblock or file).

For STPG, the target_core_user userspace daemon, tcmu-runner will
still execute the STPG, and to update the core/base LIO state it
will use the existing configfs interface. For RTPG, tcmu-runner
will loop over configfs and/or cache the state.

Signed-off-by: Mike Christie 
Signed-off-by: Nicholas Bellinger

target: Minimize #include directives

2016-12-09T18:22:28+00:00

Remove superfluous #include directives from the include/target/*.h
files. Add missing #include directives to other *.h and *.c files.
Use forward declarations for structures where possible. This
change reduces the build time for make M=drivers/target on my
laptop from 27.1s to 18.7s or by about 30%.

Signed-off-by: Bart Van Assche 
Cc: Christoph Hellwig 
Cc: Bryant G. Ly

target: Fix max_unmap_lba_count calc overflow

2016-07-20T07:58:36+00:00

max_discard_sectors only 32bits, and some non scsi backend
devices will set this to the max 0xffffffff, so we can end up
overflowing during the max_unmap_lba_count calculation.

This fixes a regression caused by my patch:

commit 8a9ebe717a133ba7bc90b06047f43cc6b8bcb8b3
Author: Mike Christie 
Date:   Mon Jan 18 14:09:27 2016 -0600

    target: Fix WRITE_SAME/DISCARD conversion to linux 512b sectors

which can result in extra discards being sent to due the overflow
causing max_unmap_lba_count to be smaller than what the backing
device can actually support.

Signed-off-by: Mike Christie 
Reviewed-by: Bart Van Assche 
Cc: stable@vger.kernel.org
Signed-off-by: Nicholas Bellinger

target: enhance and export target_alloc_sgl/target_free_sgl

2016-05-13T17:37:19+00:00

The SRP target driver will need to allocate and chain it's own SGLs soon.
For this export target_alloc_sgl, and add a new argument to it so that it
can allocate an additional chain entry that doesn't point to a page.  Also
export transport_free_sgl after renaming it to target_free_sgl to free
these SGLs again.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Bart Van Assche 
Signed-off-by: Doug Ledford

target: Fix WRITE_SAME/DISCARD conversion to linux 512b sectors

2016-01-30T03:29:34+00:00

In a couple places we are not converting to/from the Linux
block layer 512 bytes sectors.

1.

The request queue values and what we do are a mismatch of
things:

max_discard_sectors - This is in linux block layer 512 byte
sectors. We are just copying this to max_unmap_lba_count.

discard_granularity - This is in bytes. We are converting it
to Linux block layer 512 byte sectors.

discard_alignment - This is in bytes. We are just copying
this over.

The problem is that the core LIO code exports these values in
spc_emulate_evpd_b0 and we use them to test request arguments
in sbc_execute_unmap, but we never convert to the block size
we export to the initiator. If we are not using 512 byte sectors
then we are exporting the wrong values or are checks are off.
And, for the discard_alignment/bytes case we are just plain messed
up.

2.

blkdev_issue_discard's start and number of sector arguments
are supposed to be in linux block layer 512 byte sectors. We are
currently passing in the values we get from the initiator which
might be based on some other sector size.

There is a similar problem in iblock_execute_write_same where
the bio functions want values in 512 byte sectors but we are
passing in what we got from the initiator.

Signed-off-by: Mike Christie 
Cc: stable@vger.kernel.org # 3.10+
Signed-off-by: Nicholas Bellinger

target: Return descriptor format sense data in case the LU spans 64bit sectors

2015-07-24T05:54:21+00:00

In case a LU spans 64bit sectors, fixed size sense data information
field is only 32 bits which means the sector information will be truncated.

Thus, if the LU spans 64bit sectors, use descriptor format sense data to
correctly report sector information.

Reported-by: Christoph Hellwig 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Martin K. Petersen 
Signed-off-by: Sagi Grimberg 
Signed-off-by: Nicholas Bellinger

target: implement WRITE_SAME with UNMAP bit using ->execute_unmap

2015-06-23T07:43:46+00:00

Signed-off-by: Christoph Hellwig 
Reviewed-by: Andy Grover 
Signed-off-by: Nicholas Bellinger

target: simplify UNMAP handling

2015-06-23T07:43:44+00:00

Move a little more processing into the core code, and lift the previous
do_unmap callback into the sbc_ops structure.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Andy Grover 
Signed-off-by: Nicholas Bellinger

target: simplify backend attribute implementation

2015-06-01T07:25:38+00:00

Consolidate the implementation of the backend attributes in a single file
and single function per attribute show/store function instead of splitting
it into multiple functions in multiple files.

Also use the proper strto* helpers for exposed data types, add macros to
implement the store methods for the most common data types and share the
show methods between the two different attribute implementations.

(Fix bogus store_pi_prot_format flag=0 return value - nab)

Signed-off-by: Christoph Hellwig 
Signed-off-by: Nicholas Bellinger

target: consolidate backend attribute implementations

2015-06-01T07:25:36+00:00

Provide a common sets of dev_attrib attributes for all devices using the
generic SPC/SBC parsers, and a second one with the minimal required read-only
attributes for passthrough devices.  The later is only used by pscsi for now,
but will be wired up for the full-passthrough TCMU use case as well.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Nicholas Bellinger