linux-toradex.git/include/target/target_core_fabric.h, branch v4.4.10

target/qla2xxx: Honor max_data_sg_nents I/O transfer limit

2015-09-11T07:31:39+00:00

This patch adds an optional fabric driver provided SGL limit
that target-core will honor as it's own internal I/O maximum
transfer length limit, as exposed by EVPD=0xb0 block limits
parameters.

This is required for handling cases when host I/O transfer
length exceeds the requested EVPD block limits maximum
transfer length. The initial user of this logic is qla2xxx,
so that we can avoid having to reject I/Os from some legacy
FC hosts where EVPD=0xb0 parameters are not honored.

When se_cmd payload length exceeds the provided limit in
target_check_max_data_sg_nents() code, se_cmd->data_length +
se_cmd->prot_length are reset with se_cmd->residual_count
plus underflow bit for outgoing TFO response callbacks.
It also checks for existing CDB level underflow + overflow
and recalculates final residual_count as necessary.

Note this patch currently assumes 1:1 mapping of PAGE_SIZE
per struct scatterlist entry.

Reported-by: Craig Watson 
Cc: Craig Watson 
Tested-by: Himanshu Madhani 
Cc: Roland Dreier 
Cc: Arun Easi 
Cc: Giridhar Malavali 
Cc: Andrew Vasquez 
Cc: Christoph Hellwig 
Cc: Hannes Reinecke 
Cc: Martin K. Petersen 
Signed-off-by: Nicholas Bellinger

tcm_loop: Send I_T_NEXUS_LOSS_OCCURRED UA

2015-07-24T05:08:22+00:00

If the virtual SAS link is set to 'offline' we should be
queueing an I_T_NEXUS_LOSS_OCCURRED UA.

Signed-off-by: Hannes Reinecke 
Signed-off-by: Nicholas Bellinger

target: use 64-bit LUNs

2015-06-16T06:26:01+00:00

As we're now using a list to hold the LUNs the target core
can now converted to use 64-bit LUNs internally.

Signed-off-by: Hannes Reinecke 
Signed-off-by: Nicholas Bellinger

target: Drop unnecessary core_tpg_register TFO parameter

2015-06-16T06:23:22+00:00

This patch drops unnecessary target_core_fabric_ops parameter usage
for core_tpg_register() during fabric driver TFO->fabric_make_tpg()
se_portal_group creation callback execution.

Instead, use the existing se_wwn->wwn_tf->tf_ops pointer to ensure
fabric driver is really using the same TFO provided at module_init
time.

Also go ahead and drop the forward TFO declarations tree-wide, and
handling the special case for iscsi-target discovery TPG.

Cc: Christoph Hellwig 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Nicholas Bellinger

target: Convert se_portal_group->tpg_lun_list[] to RCU hlist

2015-06-01T07:24:33+00:00

This patch converts the fixed size se_portal_group->tpg_lun_list[]
to use modern RCU with hlist_head in order to support an arbitary
number of se_lun ports per target endpoint.

It includes dropping core_tpg_alloc_lun() from core_dev_add_lun(),
and calling it directly from target_fabric_make_lun() to allocate
a new se_lun.  And add a new target_fabric_port_release() configfs
item callback to invoke kfree_rcu() to release memory during
se_lun->lun_group shutdown.

Also now that se_node_acl->lun_entry_hlist is using RCU, convert
existing tpg_lun_lock to struct mutex so core_tpg_add_node_to_devs()
can perform RCU updater logic without releasing ->tpg_lun_mutex.

Also, drop core_tpg_clear_object_luns() and it's single consumer
in iscsi-target, which is duplicating TPG LUN shutdown logic and
is current code results in a NOP.

Finally, sbp-target and xen-scsiback fabric driver conversions are
included, which are required due to the non-standard way they use
->tpg_lun_hlist.

Reviewed-by: Hannes Reinecke 
Cc: Christoph Hellwig 
Cc: Sagi Grimberg 
Cc: Paul E. McKenney 
Cc: Chris Boot 
Signed-off-by: Nicholas Bellinger

target: remove ->put_session method

2015-05-31T05:42:40+00:00

The only instance of ->put_session is in qla2xxx, and was added by commit
aaf68b ("tcm_qla2xxx: Convert to TFO->put_session() usage") with the following
description:

    This patch converts tcm_qla2xxx code to use an internal kref_put() for
    se_session->sess_kref in order to ensure that qla_hw_data->hardware_lock
    can be held while calling qlt_unreg_sess() for the final put.

But these day we're already holding the hardware lock over qlt_unreg_sess in
the ->close_session callback, so we're fine without this method.

(Re-add missing tcm_qla2xxx_release_session + drop put_session usage - nab)

Signed-off-by: Christoph Hellwig 
Acked-by: Himanshu Madhani 
Signed-off-by: Nicholas Bellinger

target: Move task tag into struct se_cmd + support 64-bit tags

2015-05-31T05:42:31+00:00

Simplify target core and target drivers by storing the task tag
a.k.a. command identifier inside struct se_cmd.

For several transports (e.g. SRP) tags are 64 bits wide.
Hence add support for 64-bit tags.

(Fix core_tmr_abort_task conversion spec warnings - nab)
(Fix up usb-gadget to use 16-bit tags - HCH + bart)

Signed-off-by: Bart Van Assche 
Cc: Christoph Hellwig 
Cc: Andy Grover 
Cc: Sagi Grimberg 
Cc: 
Cc: Felipe Balbi 
Cc: Michael S. Tsirkin 
Cc: Juergen Gross 
Signed-off-by: Nicholas Bellinger

target: move transport ID handling to the core

2015-05-31T05:42:30+00:00

Now that struct se_portal_group contains a protocol identifier field we can
take all the code to format an parse protocol identifiers in CDBs into common
code instead of leaving this to low-level drivers.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Nicholas Bellinger

target: remove the get_fabric_proto_ident method

2015-05-31T05:42:30+00:00

Now that we store the protocol identifier in the tpg structure we don't
need this method.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Nicholas Bellinger

target: change core_tpg_register prototype

2015-05-31T05:42:27+00:00

Remove the unneeded fabric_ptr argument, and change the type argument
to pass in a SPC protocol identifier.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Nicholas Bellinger