linux-toradex.git/include/target, branch v3.6-rc2

target: Allow for target_submit_cmd() returning errors

2012-07-18T00:05:05+00:00

We want it to be possible for target_submit_cmd() to return errors up
to its fabric module callers.  For now just update the prototype to
return an int, and update all callers to handle non-zero return values
as an error.

This is immediately useful for tcm_qla2xxx to fix a long-standing active
I/O session shutdown race, but tcm_fc, usb-gadget, and sbp-target the
fabric maintainers need to check + ACK that handling a target_submit_cmd()
failure due to session shutdown does not introduce regressions

(nab: Respin against for-next after initial NACK + update docbook comment +
      fix double se_cmd init in exception path for usb-gadget)

Cc: Chad Dupuis 
Cc: Arun Easi 
Cc: Chris Boot 
Cc: Stefan Richter 
Cc: Mark Rustad 
Cc: Sebastian Andrzej Siewior 
Cc: Felipe Balbi 
Cc: Andy Grover 
Signed-off-by: Roland Dreier 
Signed-off-by: Nicholas Bellinger

target: Add generation of LOGICAL BLOCK ADDRESS OUT OF RANGE

2012-07-17T00:35:35+00:00

Many SCSI commands are defined to return a CHECK CONDITION / ILLEGAL
REQUEST with ASC set to LOGICAL BLOCK ADDRESS OUT OF RANGE if the
initiator sends a command that accesses a too-big LBA.  Add an enum
value and case entries so that target code can return this status.

Signed-off-by: Roland Dreier 
Cc: stable@vger.kernel.org
Signed-off-by: Nicholas Bellinger

target: Remove se_session.sess_wait_list

2012-07-17T00:35:27+00:00

Since we set se_session.sess_tearing_down and stop new commands from
being added to se_session.sess_cmd_list before we wait for commands to
finish when freeing a session, there's no need for a separate
sess_wait_list -- if we let new commands be added to sess_cmd_list
after setting sess_tearing_down, that would be a bug that breaks the
logic of waiting in-flight commands.

Also rename target_splice_sess_cmd_list() to
target_sess_cmd_list_set_waiting(), since we are no longer splicing
onto a separate list.

Signed-off-by: Roland Dreier 
Signed-off-by: Nicholas Bellinger

target: Un-export target_get_sess_cmd()

2012-07-17T00:35:25+00:00

There are no in-tree users of target_get_sess_cmd() outside of
target_core_transport.c.  Any new code should use the higher-level
target_submit_cmd() interface.  So let's un-export target_get_sess_cmd()
and make it static to the one file where it's actually used.

(nab: Fix up minor fuzz to for-next)

Signed-off-by: Roland Dreier 
Signed-off-by: Nicholas Bellinger

target: replace the processing thread with a TMR work queue

2012-07-17T00:35:21+00:00

The last functionality of the target processing thread is offloading possibly
long running task management requests from the submitter context.  To keep
TMR semantics the same we need a single threaded ordered queue, which can
be provided by a per-device workqueue with the right flags.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Nicholas Bellinger

target: remove transport_generic_handle_cdb_map

2012-07-17T00:35:21+00:00

Remove this command submission path which is not used by any in-tree driver.
This also removes the now unused new_cmd_map fabtric method, which a few
drivers implemented despite never calling transport_generic_handle_cdb_map.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Nicholas Bellinger

target: remove transport_generic_handle_data

2012-07-17T00:35:20+00:00

Signed-off-by: Christoph Hellwig 
Signed-off-by: Nicholas Bellinger

target: remove transport_generic_process_write

2012-07-17T00:35:16+00:00

Just call target_execute_cmd directly.  Also, convert loopback, sbp,
usb-gadget to use the newly exported target_execute_cmd().

Signed-off-by: Christoph Hellwig 
Signed-off-by: Nicholas Bellinger

target: move unmap to struct spc_ops

2012-07-17T00:35:14+00:00

Having all the unmap payload parsing in the backed is a bit ugly, but until
more drivers support it and we can find a good interface for all of them
that seems the way to go.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Nicholas Bellinger

target: move write_same to struct spc_ops

2012-07-17T00:34:41+00:00

Add spc_ops->execute_write_same() caller for ->execute_cmd() setup,
and update IBLOCK backends to use it.

(nab: add export of spc_get_write_same_sectors symbol)
(roland: Carry forward: Fix range calculation in WRITE SAME emulation
         when num blocks == 0)

Signed-off-by: Christoph Hellwig 
Signed-off-by: Nicholas Bellinger