linux-toradex.git/include/trace/events/rpcrdma.h, branch v5.0

xprtrdma: Prevent leak of rpcrdma_rep objects

2019-01-02T17:05:19+00:00

If a reply has been processed but the RPC is later retransmitted
anyway, the req->rl_reply field still contains the only pointer to
the old rpcrdma rep. When the next reply comes in, the reply handler
will stomp on the rl_reply field, leaking the old rep.

A trace event is added to capture such leaks.

This problem seems to be worsened by the restructuring of the RPC
Call path in v4.20. Fully addressing this issue will require at
least a re-architecture of the disconnect logic, which is not
appropriate during -rc.

Signed-off-by: Chuck Lever 
Signed-off-by: Anna Schumaker

xprtrdma: Trace mapping, alloc, and dereg failures

2019-01-02T17:05:18+00:00

These are rare, but can be helpful at tracking down DMAR and other
problems.

Signed-off-by: Chuck Lever 
Signed-off-by: Anna Schumaker

xprtrdma: Add trace points for calls to transport switch methods

2019-01-02T17:05:18+00:00

Name them "trace_xprtrdma_op_*" so they can be easily enabled as a
group. No trace point is added where the generic layer already has
observability.

Signed-off-by: Chuck Lever 
Signed-off-by: Anna Schumaker

xprtrdma: Clean up of xprtrdma chunk trace points

2019-01-02T17:05:18+00:00

The chunk-related trace points capture nearly the same information
as the MR-related trace points.

Also, rename them so globbing can be used to enable or disable
these trace points more easily.

Signed-off-by: Chuck Lever 
Signed-off-by: Anna Schumaker

xprtrdma: Refactor Receive accounting

2019-01-02T17:05:16+00:00

Clean up: Divide the work cleanly:

- rpcrdma_wc_receive is responsible only for RDMA Receives
- rpcrdma_reply_handler is responsible only for RPC Replies
- the posted send and receive counts both belong in rpcrdma_ep

Signed-off-by: Chuck Lever 
Signed-off-by: Anna Schumaker

xprtrdma: Squelch a sparse warning

2018-10-03T18:35:17+00:00

linux/include/trace/events/rpcrdma.h:501:1: warning: expression using sizeof bool
linux/include/trace/events/rpcrdma.h:501:1: warning: odd constant _Bool cast (ffffffffffffffff becomes 1)

Fixes: ab03eff58eb5 ("xprtrdma: Add trace points in RPC Call ... ")
Signed-off-by: Chuck Lever 
Signed-off-by: Anna Schumaker

xprtrdma: Rename rpcrdma_qp_async_error_upcall

2018-10-03T13:14:57+00:00

Clean up: Use a function name that is consistent with the RDMA core
API and with other consumers. Because this is a function that is
invoked from outside the rpcrdma.ko module, add an appropriate
documenting comment.

Signed-off-by: Chuck Lever 
Signed-off-by: Anna Schumaker

xprtrdma: Rename rpcrdma_conn_upcall

2018-10-02T20:14:05+00:00

Clean up: Use a function name that is consistent with the RDMA core
API and with other consumers. Because this is a function that is
invoked from outside the rpcrdma.ko module, add an appropriate
documenting comment.

Signed-off-by: Chuck Lever 
Signed-off-by: Anna Schumaker

xprtrdma: Name MR trace events consistently

2018-10-02T19:55:36+00:00

Clean up the names of trace events related to MRs so that it's
easy to enable these with a glob.

Signed-off-by: Chuck Lever 
Signed-off-by: Anna Schumaker

xprtrdma: Explicitly resetting MRs is no longer necessary

2018-10-02T19:48:12+00:00

When a memory operation fails, the MR's driver state might not match
its hardware state. The only reliable recourse is to dereg the MR.
This is done in ->ro_recover_mr, which then attempts to allocate a
fresh MR to replace the released MR.

Since commit e2ac236c0b651 ("xprtrdma: Allocate MRs on demand"),
xprtrdma dynamically allocates MRs. It can add more MRs whenever
they are needed.

That makes it possible to simply release an MR when a memory
operation fails, instead of "recovering" it. It will automatically
be replaced by the on-demand MR allocator.

This commit is a little larger than I wanted, but it replaces
->ro_recover_mr, rb_recovery_lock, rb_recovery_worker, and the
rb_stale_mrs list with a generic work queue.

Since MRs are no longer orphaned, the mrs_orphaned metric is no
longer used.

Signed-off-by: Chuck Lever 
Signed-off-by: Anna Schumaker