linux-toradex.git/include/uapi/linux/l2tp.h, branch v5.1-rc1

l2tp: ignore L2TP_ATTR_MTU

2018-08-03T17:03:57+00:00

This attribute's handling is broken. It can only be used when creating
Ethernet pseudo-wires, in which case its value can be used as the
initial MTU for the l2tpeth device.
However, when handling update requests, L2TP_ATTR_MTU only modifies
session->mtu. This value is never propagated to the l2tpeth device.
Dump requests also return the value of session->mtu, which is not
synchronised anymore with the device MTU.

The same problem occurs if the device MTU is properly updated using the
generic IFLA_MTU attribute. In this case, session->mtu is not updated,
and L2TP_ATTR_MTU will report an invalid value again when dumping the
session.

It does not seem worthwhile to complexify l2tp_eth.c to synchronise
session->mtu with the device MTU. Even the ip-l2tp manpage advises to
use 'ip link' to initialise the MTU of l2tpeth devices (iproute2 does
not handle L2TP_ATTR_MTU at all anyway). So let's just ignore it
entirely.

Signed-off-by: Guillaume Nault 
Signed-off-by: David S. Miller

l2tp: drop ->mru from struct l2tp_session

2018-07-27T20:34:53+00:00

This field is not used.

Treat PPPIOC*MRU the same way as PPPIOC*FLAGS: "get" requests return 0,
while "set" requests vadidate the user supplied pointer but discard its
value.

Signed-off-by: Guillaume Nault 
Signed-off-by: David S. Miller

l2tp: ignore L2TP_ATTR_VLAN_ID netlink attribute

2018-07-27T20:34:53+00:00

The value of this attribute is never used.

Signed-off-by: Guillaume Nault 
Signed-off-by: David S. Miller

l2tp: ignore L2TP_ATTR_DATA_SEQ netlink attribute

2018-07-27T20:34:53+00:00

The value of this attribute is never used.

Signed-off-by: Guillaume Nault 
Signed-off-by: David S. Miller

l2tp: mark L2TP_ATTR_L2SPEC_LEN as not used

2018-01-19T20:00:49+00:00

Reviewed-by: Guillaume Nault 
Tested-by: Guillaume Nault 
Signed-off-by: Lorenzo Bianconi 
Signed-off-by: David S. Miller

l2tp: adjust comments about L2TPv3 offsets

2018-01-08T19:22:42+00:00

The "offset" option has been removed by
commit 900631ee6a26 ("l2tp: remove configurable payload offset").

Signed-off-by: Guillaume Nault 
Acked-by: James Chapman 
Signed-off-by: David S. Miller

l2tp: add comment in API header that L2TP_ATTR_OFFSET is not used

2018-01-05T16:03:26+00:00

Signed-off-by: James Chapman 
Signed-off-by: David S. Miller

l2tp: revert "l2tp: add peer_offset parameter"

2018-01-05T16:03:04+00:00

Revert commit f15bc54eeecd ("l2tp: add peer_offset parameter"). This
is removed because it is adding another configurable offset and
configurable offsets are being removed.

Signed-off-by: James Chapman 
Signed-off-by: David S. Miller

l2tp: add peer_offset parameter

2017-12-27T17:11:51+00:00

Introduce peer_offset parameter in order to add the capability
to specify two different values for payload offset on tx/rx side.
If just offset is provided by userspace use it for rx side as well
in order to maintain compatibility with older l2tp versions

Signed-off-by: Lorenzo Bianconi 
Signed-off-by: David S. Miller

License cleanup: add SPDX license identifier to uapi header files with no license

2017-11-02T10:19:54+00:00

Many user space API headers are missing licensing information, which
makes it hard for compliance tools to determine the correct license.

By default are files without license information under the default
license of the kernel, which is GPLV2.  Marking them GPLV2 would exclude
them from being included in non GPLV2 code, which is obviously not
intended. The user space API headers fall under the syscall exception
which is in the kernels COPYING file:

   NOTE! This copyright does *not* cover user programs that use kernel
   services by normal system calls - this is merely considered normal use
   of the kernel, and does *not* fall under the heading of "derived work".

otherwise syscall usage would not be possible.

Update the files which contain no license information with an SPDX
license identifier.  The chosen identifier is 'GPL-2.0 WITH
Linux-syscall-note' which is the officially assigned identifier for the
Linux syscall exception.  SPDX license identifiers are a legally binding
shorthand, which can be used instead of the full boiler plate text.

This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.  See the previous patch in this series for the
methodology of how this patch was researched.

Reviewed-by: Kate Stewart 
Reviewed-by: Philippe Ombredanne 
Reviewed-by: Thomas Gleixner 
Signed-off-by: Greg Kroah-Hartman