linux-toradex.git/include/uapi/linux/l2tp.h, branch v5.10-rc3

l2tp: report rx cookie discards in netlink get

2020-09-29T20:26:36+00:00

When an L2TPv3 session receives a data frame with an incorrect cookie
l2tp_core logs a warning message and bumps a stats counter to reflect
the fact that the packet has been dropped.

However, the stats counter in question is missing from the l2tp_netlink
get message for tunnel and session instances.

Include the statistic in the netlink get response.

Signed-off-by: Tom Parkin 
Signed-off-by: David S. Miller

l2tp: remove tunnel and session debug flags field

2020-08-22T19:44:37+00:00

The l2tp subsystem now uses standard kernel logging APIs for
informational and warning messages, and tracepoints for debug
information.

Now that the tunnel and session debug flags are unused, remove the field
from the core structures.

Various system calls (in the case of l2tp_ppp) and netlink messages
handle the getting and setting of debug flags.  To avoid userspace
breakage don't modify the API of these calls; simply ignore set
requests, and send dummy data for get requests.

Signed-off-by: Tom Parkin 
Signed-off-by: David S. Miller

l2tp: ignore L2TP_ATTR_MTU

2018-08-03T17:03:57+00:00

This attribute's handling is broken. It can only be used when creating
Ethernet pseudo-wires, in which case its value can be used as the
initial MTU for the l2tpeth device.
However, when handling update requests, L2TP_ATTR_MTU only modifies
session->mtu. This value is never propagated to the l2tpeth device.
Dump requests also return the value of session->mtu, which is not
synchronised anymore with the device MTU.

The same problem occurs if the device MTU is properly updated using the
generic IFLA_MTU attribute. In this case, session->mtu is not updated,
and L2TP_ATTR_MTU will report an invalid value again when dumping the
session.

It does not seem worthwhile to complexify l2tp_eth.c to synchronise
session->mtu with the device MTU. Even the ip-l2tp manpage advises to
use 'ip link' to initialise the MTU of l2tpeth devices (iproute2 does
not handle L2TP_ATTR_MTU at all anyway). So let's just ignore it
entirely.

Signed-off-by: Guillaume Nault 
Signed-off-by: David S. Miller

l2tp: drop ->mru from struct l2tp_session

2018-07-27T20:34:53+00:00

This field is not used.

Treat PPPIOC*MRU the same way as PPPIOC*FLAGS: "get" requests return 0,
while "set" requests vadidate the user supplied pointer but discard its
value.

Signed-off-by: Guillaume Nault 
Signed-off-by: David S. Miller

l2tp: ignore L2TP_ATTR_VLAN_ID netlink attribute

2018-07-27T20:34:53+00:00

The value of this attribute is never used.

Signed-off-by: Guillaume Nault 
Signed-off-by: David S. Miller

l2tp: ignore L2TP_ATTR_DATA_SEQ netlink attribute

2018-07-27T20:34:53+00:00

The value of this attribute is never used.

Signed-off-by: Guillaume Nault 
Signed-off-by: David S. Miller

l2tp: mark L2TP_ATTR_L2SPEC_LEN as not used

2018-01-19T20:00:49+00:00

Reviewed-by: Guillaume Nault 
Tested-by: Guillaume Nault 
Signed-off-by: Lorenzo Bianconi 
Signed-off-by: David S. Miller

l2tp: adjust comments about L2TPv3 offsets

2018-01-08T19:22:42+00:00

The "offset" option has been removed by
commit 900631ee6a26 ("l2tp: remove configurable payload offset").

Signed-off-by: Guillaume Nault 
Acked-by: James Chapman 
Signed-off-by: David S. Miller

l2tp: add comment in API header that L2TP_ATTR_OFFSET is not used

2018-01-05T16:03:26+00:00

Signed-off-by: James Chapman 
Signed-off-by: David S. Miller

l2tp: revert "l2tp: add peer_offset parameter"

2018-01-05T16:03:04+00:00

Revert commit f15bc54eeecd ("l2tp: add peer_offset parameter"). This
is removed because it is adding another configurable offset and
configurable offsets are being removed.

Signed-off-by: James Chapman 
Signed-off-by: David S. Miller