linux-toradex.git/include/ufs, branch v6.11-rc6

scsi: ufs: core: Add a quirk for handling broken LSDBS field in controller capabilities register

2024-08-17T01:09:17+00:00

'Legacy Queue & Single Doorbell Support (LSDBS)' field in the controller
capabilities register is supposed to report whether the legacy single
doorbell mode is supported in the controller or not. But some controllers
report '1' in this field which corresponds to 'LSDB not supported', but
they indeed support LSDB. So let's add a quirk to handle those controllers.

If the quirk is enabled by the controller driver, then LSDBS register field
will be ignored and legacy single doorbell mode is assumed to be enabled
always.

Tested-by: Amit Pundir 
Signed-off-by: Manivannan Sadhasivam 
Link: https://lore.kernel.org/r/20240816-ufs-bug-fix-v3-1-e6fe0e18e2a3@linaro.org
Reviewed-by: Bart Van Assche 
Signed-off-by: Martin K. Petersen

scsi: ufs: core: Check LSDBS cap when !mcq

2024-07-16T02:51:06+00:00

If the user sets use_mcq_mode to 0, the host will try to activate the LSDB
mode unconditionally even when the LSDBS of device HCI cap is 1. This makes
commands time out and causes device probing to fail.

To prevent that problem, check the LSDBS cap when MCQ is not supported.

Signed-off-by: Kyoungrul Kim 
Link: https://lore.kernel.org/r/20240709232520epcms2p8ebdb5c4fccc30a6221390566589bf122@epcms2p8
Reviewed-by: Bart Van Assche 
Signed-off-by: Martin K. Petersen

Merge patch series "Basic inline encryption support for ufs-exynos"

2024-07-11T02:33:34+00:00

Eric Biggers  says:

Add support for Flash Memory Protector (FMP), which is the inline
encryption hardware on Exynos and Exynos-based SoCs.

Specifically, add support for the "traditional FMP mode" that works on
many Exynos-based SoCs including gs101.  This is the mode that uses
"software keys" and is compatible with the upstream kernel's existing
inline encryption framework in the block and filesystem layers.  I
plan to add support for the wrapped key support on gs101 at a later
time.

Tested on gs101 (specifically Pixel 6) by running the 'encrypt' group
of xfstests on a filesystem mounted with the 'inlinecrypt' mount
option.

This patchset applies to v6.10-rc6, and it has no prerequisites that
aren't already upstream.

Link: https://lore.kernel.org/r/20240708235330.103590-1-ebiggers@kernel.org
Signed-off-by: Martin K. Petersen

scsi: ufs: core: Add UFSHCD_QUIRK_KEYS_IN_PRDT

2024-07-11T02:32:30+00:00

Since the nonstandard inline encryption support on Exynos SoCs requires
that raw cryptographic keys be copied into the PRDT, it is desirable to
zeroize those keys after each request to keep them from being left in
memory.  Therefore, add a quirk bit that enables the zeroization.

We could instead do the zeroization unconditionally.  However, using a
quirk bit avoids adding the zeroization overhead to standard devices.

Reviewed-by: Bart Van Assche 
Reviewed-by: Peter Griffin 
Signed-off-by: Eric Biggers 
Link: https://lore.kernel.org/r/20240708235330.103590-6-ebiggers@kernel.org
Reviewed-by: Alim Akhtar 
Signed-off-by: Martin K. Petersen

scsi: ufs: core: Add fill_crypto_prdt variant op

2024-07-11T02:32:30+00:00

Add a variant op to allow host drivers to initialize nonstandard
crypto-related fields in the PRDT.  This is needed to support inline
encryption on the "Exynos" UFS controller.

Note that this will be used together with the support for overriding the
PRDT entry size that was already added by commit ada1e653a5ea ("scsi: ufs:
core: Allow UFS host drivers to override the sg entry size").

Reviewed-by: Bart Van Assche 
Reviewed-by: Peter Griffin 
Signed-off-by: Eric Biggers 
Link: https://lore.kernel.org/r/20240708235330.103590-5-ebiggers@kernel.org
Reviewed-by: Alim Akhtar 
Signed-off-by: Martin K. Petersen

scsi: ufs: core: Add UFSHCD_QUIRK_BROKEN_CRYPTO_ENABLE

2024-07-11T02:32:30+00:00

Add UFSHCD_QUIRK_BROKEN_CRYPTO_ENABLE which tells the UFS core to not use
the crypto enable bit defined by the UFS specification.  This is needed to
support inline encryption on the "Exynos" UFS controller.

Reviewed-by: Bart Van Assche 
Reviewed-by: Peter Griffin 
Signed-off-by: Eric Biggers 
Link: https://lore.kernel.org/r/20240708235330.103590-4-ebiggers@kernel.org
Reviewed-by: Alim Akhtar 
Signed-off-by: Martin K. Petersen

scsi: ufs: core: Add UFSHCD_QUIRK_CUSTOM_CRYPTO_PROFILE

2024-07-11T02:32:29+00:00

Add UFSHCD_QUIRK_CUSTOM_CRYPTO_PROFILE which lets UFS host drivers
initialize the blk_crypto_profile themselves rather than have it be
initialized by ufshcd-core according to the UFSHCI standard.  This is
needed to support inline encryption on the "Exynos" UFS controller which
has a nonstandard interface.

Reviewed-by: Bart Van Assche 
Reviewed-by: Peter Griffin 
Signed-off-by: Eric Biggers 
Link: https://lore.kernel.org/r/20240708235330.103590-2-ebiggers@kernel.org
Reviewed-by: Alim Akhtar 
Signed-off-by: Martin K. Petersen

Merge patch series "UFS patches for kernel 6.11"

2024-07-11T02:26:08+00:00

Bart Van Assche  says:

Hi Martin,

Please consider this series of UFS driver patches for the next merge window.

Thank you,

Bart.

Link: https://lore.kernel.org/r/20240708211716.2827751-1-bvanassche@acm.org
Signed-off-by: Martin K. Petersen

scsi: ufs: mcq: Make .get_hba_mac() optional

2024-07-11T02:19:05+00:00

UFSHCI controllers that are compliant with the UFSHCI 4.0 standard report
the maximum number of supported commands in the controller capabilities
register. Use that value if .get_hba_mac == NULL.

Reviewed-by: Peter Wang 
Signed-off-by: Bart Van Assche 
Link: https://lore.kernel.org/r/20240708211716.2827751-11-bvanassche@acm.org
Reviewed-by: Manivannan Sadhasivam 
Signed-off-by: Martin K. Petersen

scsi: ufs: core: Inline is_mcq_enabled()

2024-07-11T02:19:05+00:00

Improve code readability by inlining is_mcq_enabled().

Cc: Peter Wang 
Cc: Manivannan Sadhasivam 
Signed-off-by: Bart Van Assche 
Link: https://lore.kernel.org/r/20240708211716.2827751-7-bvanassche@acm.org
Reviewed-by: Manivannan Sadhasivam 
Signed-off-by: Martin K. Petersen