linux-toradex.git/kernel/auditsc.c, branch v3.4.94

auditsc: audit_krule mask accesses need bounds checking

2014-06-16T20:45:46+00:00

commit a3c54931199565930d6d84f4c3456f6440aefd41 upstream.

Fixes an easy DoS and possible information disclosure.

This does nothing about the broken state of x32 auditing.

eparis: If the admin has enabled auditd and has specifically loaded
audit rules.  This bug has been around since before git.  Wow...

Signed-off-by: Andy Lutomirski 
Signed-off-by: Eric Paris 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

kernel-doc: fix new warnings in auditsc.c

2012-01-23T16:44:53+00:00

Fix new kernel-doc warnings in auditsc.c:

Warning(kernel/auditsc.c:1875): No description found for parameter 'success'
Warning(kernel/auditsc.c:1875): No description found for parameter 'return_code'
Warning(kernel/auditsc.c:1875): Excess function parameter 'pt_regs' description in '__audit_syscall_exit'

Signed-off-by: Randy Dunlap 
Cc: Al Viro 
Cc: Eric Paris 
Signed-off-by: Linus Torvalds

audit: no leading space in audit_log_d_path prefix

2012-01-17T21:17:04+00:00

audit_log_d_path() injects an additional space before the prefix,
which serves no purpose and doesn't mix well with other audit_log*()
functions that do not sneak extra characters into the log.

Signed-off-by: Kees Cook 
Signed-off-by: Eric Paris

audit: fix signedness bug in audit_log_execve_info()

2012-01-17T21:17:03+00:00

In the loop, a size_t "len" is used to hold the return value of
audit_log_single_execve_arg(), which returns -1 on error.  In that
case the error handling (len <= 0) will be bypassed since "len" is
unsigned, and the loop continues with (p += len) being wrapped.
Change the type of "len" to signed int to fix the error handling.

	size_t len;
	...
	for (...) {
		len = audit_log_single_execve_arg(...);
		if (len <= 0)
			break;
		p += len;
	}

Signed-off-by: Xi Wang 
Signed-off-by: Eric Paris

audit: comparison on interprocess fields

2012-01-17T21:17:03+00:00

This allows audit to specify rules in which we compare two fields of a
process.  Such as is the running process uid != to the running process
euid?

Signed-off-by: Peter Moody 
Signed-off-by: Eric Paris

audit: implement all object interfield comparisons

2012-01-17T21:17:02+00:00

This completes the matrix of interfield comparisons between uid/gid
information for the current task and the uid/gid information for inodes.
aka I can audit based on differences between the euid of the process and
the uid of fs objects.

Signed-off-by: Peter Moody 
Signed-off-by: Eric Paris

audit: allow interfield comparison between gid and ogid

2012-01-17T21:17:02+00:00

Allow audit rules to compare the gid of the running task to the gid of the
inode in question.

Signed-off-by: Eric Paris

audit: complex interfield comparison helper

2012-01-17T21:17:02+00:00

Rather than code the same loop over and over implement a helper function which
uses some pointer magic to make it generic enough to be used numerous places
as we implement more audit interfield comparisons

Signed-off-by: Eric Paris

audit: allow interfield comparison in audit rules

2012-01-17T21:17:01+00:00

We wish to be able to audit when a uid=500 task accesses a file which is
uid=0.  Or vice versa.  This patch introduces a new audit filter type
AUDIT_FIELD_COMPARE which takes as an 'enum' which indicates which fields
should be compared.  At this point we only define the task->uid vs
inode->uid, but other comparisons can be added.

Signed-off-by: Eric Paris

audit: do not call audit_getname on error

2012-01-17T21:17:01+00:00

Just a code cleanup really.  We don't need to make a function call just for
it to return on error.  This also makes the VFS function even easier to follow
and removes a conditional on a hot path.

Signed-off-by: Eric Paris