linux-toradex.git/kernel/debug/kdb/kdb_bp.c, branch v6.7-rc3

kdb: Rename members of struct kdbtab_t

2021-07-27T16:05:06+00:00

Remove redundant prefix "cmd_" from name of members in struct kdbtab_t
for better readibility.

Suggested-by: Doug Anderson 
Signed-off-by: Sumit Garg 
Reviewed-by: Douglas Anderson 
Link: https://lore.kernel.org/r/20210712134620.276667-5-sumit.garg@linaro.org
Signed-off-by: Daniel Thompson

kdb: Simplify kdb commands registration

2021-03-19T16:51:59+00:00

Simplify kdb commands registration via using linked list instead of
static array for commands storage.

Signed-off-by: Sumit Garg 
Link: https://lore.kernel.org/r/20210224070827.408771-1-sumit.garg@linaro.org
Reviewed-by: Douglas Anderson 
[daniel.thompson@linaro.org: Removed a bunch of .cmd_minline = 0
initializers]
Signed-off-by: Daniel Thompson

kgdb: Honour the kprobe blocklist when setting breakpoints

2020-09-28T11:14:08+00:00

Currently kgdb has absolutely no safety rails in place to discourage or
prevent a user from placing a breakpoint in dangerous places such as
the debugger's own trap entry/exit and other places where it is not safe
to take synchronous traps.

Introduce a new config symbol KGDB_HONOUR_BLOCKLIST and modify the
default implementation of kgdb_validate_break_address() so that we use
the kprobe blocklist to prohibit instrumentation of critical functions
if the config symbol is set. The config symbol dependencies are set to
ensure that the blocklist will be enabled by default if we enable KGDB
and are compiling for an architecture where we HAVE_KPROBES.

Suggested-by: Peter Zijlstra 
Reviewed-by: Douglas Anderson 
Reviewed-by: Masami Hiramatsu 
Link: https://lore.kernel.org/r/20200927211531.1380577-2-daniel.thompson@linaro.org
Signed-off-by: Daniel Thompson

kdb: remove redundant assignment to pointer bp

2020-01-31T17:34:06+00:00

The point bp is assigned a value that is never read, it is being
re-assigned later to bp = &kdb_breakpoints[lowbp] in a for-loop.
Remove the redundant assignment.

Addresses-Coverity ("Unused value")
Signed-off-by: Colin Ian King 
Link: https://lore.kernel.org/r/20191128130753.181246-1-colin.king@canonical.com
Signed-off-by: Daniel Thompson

kdb: bl: don't use tab character in output

2018-01-25T14:41:22+00:00

The "bl" (list breakpoints) command prints a '\t' (tab) character
in its output, but on a console (video device), that just prints
some odd graphics character. Instead of printing a tab character,
just align the output with spaces.

Signed-off-by: Randy Dunlap 
Cc: Daniel Thompson 
Cc: Jason Wessel 
Cc: kgdb-bugreport@lists.sourceforge.net
Signed-off-by: Jason Wessel

mm/init: Add 'rodata=off' boot cmdline parameter to disable read-only kernel mappings

2016-02-22T07:51:37+00:00

It may be useful to debug writes to the readonly sections of memory,
so provide a cmdline "rodata=off" to allow for this. This can be
expanded in the future to support "log" and "write" modes, but that
will need to be architecture-specific.

This also makes KDB software breakpoints more usable, as read-only
mappings can now be disabled on any kernel.

Suggested-by: H. Peter Anvin 
Signed-off-by: Kees Cook 
Cc: Andy Lutomirski 
Cc: Arnd Bergmann 
Cc: Borislav Petkov 
Cc: Brian Gerst 
Cc: David Brown 
Cc: Denys Vlasenko 
Cc: Emese Revfy 
Cc: Linus Torvalds 
Cc: Mathias Krause 
Cc: Michael Ellerman 
Cc: PaX Team 
Cc: Peter Zijlstra 
Cc: Thomas Gleixner 
Cc: kernel-hardening@lists.openwall.com
Cc: linux-arch 
Link: http://lkml.kernel.org/r/1455748879-21872-3-git-send-email-keescook@chromium.org
Signed-off-by: Ingo Molnar

kdb: Categorize kdb commands (similar to SysRq categorization)

2014-11-11T15:31:52+00:00

This patch introduces several new flags to collect kdb commands into
groups (later allowing them to be optionally disabled).

This follows similar prior art to enable/disable magic sysrq
commands.

The commands have been categorized as follows:

Always on:  go (w/o args), env, set, help, ?, cpu (w/o args), sr,
            dmesg, disable_nmi, defcmd, summary, grephelp
Mem read:   md, mdr, mdp, mds, ef, bt (with args), per_cpu
Mem write:  mm
Reg read:   rd
Reg write:  go (with args), rm
Inspect:    bt (w/o args), btp, bta, btc, btt, ps, pid, lsmod
Flow ctrl:  bp, bl, bph, bc, be, bd, ss
Signal:     kill
Reboot:     reboot
All:        cpu, kgdb, (and all of the above), nmi_console

Signed-off-by: Daniel Thompson 
Cc: Jason Wessel 
Signed-off-by: Jason Wessel

kdb: Remove KDB_REPEAT_NONE flag

2014-11-11T15:31:52+00:00

Since we now treat KDB_REPEAT_* as flags, there is no need to
pass KDB_REPEAT_NONE. It's just the default behaviour when no
flags are specified.

Signed-off-by: Anton Vorontsov 
Signed-off-by: John Stultz 
Signed-off-by: Daniel Thompson 
Cc: Jason Wessel 
Signed-off-by: Jason Wessel

kdb: Rename kdb_register_repeat() to kdb_register_flags()

2014-11-11T15:31:51+00:00

We're about to add more options for commands behaviour, so let's give
a more generic name to the low-level kdb command registration function.

There are just various renames, no functional changes.

Signed-off-by: Anton Vorontsov 
Signed-off-by: John Stultz 
Signed-off-by: Daniel Thompson 
Cc: Jason Wessel 
Signed-off-by: Jason Wessel

kdb: replace strnicmp with strncasecmp

2014-10-14T00:18:25+00:00

The kernel used to contain two functions for length-delimited,
case-insensitive string comparison, strnicmp with correct semantics and
a slightly buggy strncasecmp.  The latter is the POSIX name, so strnicmp
was renamed to strncasecmp, and strnicmp made into a wrapper for the new
strncasecmp to avoid breaking existing users.

To allow the compat wrapper strnicmp to be removed at some point in the
future, and to avoid the extra indirection cost, do
s/strnicmp/strncasecmp/g.

Signed-off-by: Rasmus Villemoes 
Cc: Jason Wessel 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds