linux-toradex.git/kernel/exit.c, branch v2.6.21-rc2

[PATCH] pid: replace is_orphaned_pgrp with is_current_pgrp_orphaned

2007-02-12T17:48:32+00:00

Every call to is_orphaned_pgrp passed in process_group(current) which is racy
with respect to another thread changing our process group.  It didn't bite us
because we were dealing with integers and the worse we would get would be a
stale answer.

In switching the checks to use struct pid to be a little more efficient and
prepare the way for pid namespaces this race became apparent.

So I simplified the calls to the more specialized is_current_pgrp_orphaned so
I didn't have to worry about making logic changes to avoid the race.

Signed-off-by: Eric W. Biederman 
Cc: Alan Cox 
Cc: Oleg Nesterov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] pid: use struct pid for talking about process groups in exitc

2007-02-12T17:48:32+00:00

Modify has_stopped_jobs and will_become_orphan_pgrp to use struct pid based
process groups.  This reduces the number of hash tables looks ups and paves
the way for multiple pid spaces.

Signed-off-by: Eric W. Biederman 
Cc: Alan Cox 
Cc: Oleg Nesterov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] pid: make session_of_pgrp use struct pid instead of pid_t

2007-02-12T17:48:31+00:00

To properly implement a pid namespace I need to deal exclusively in terms of
struct pid, because pid_t values become ambiguous.

To this end session_of_pgrp is transformed to take and return a struct pid
pointer.  To avoid the need to worry about reference counting I now require my
caller to hold the appropriate locks.  Leaving callers repsonsible for
increasing the reference count if they need access to the result outside of
the locks.

Since session_of_pgrp currently only has one caller and that caller simply
uses only test the result for equality with another process group, the locking
change means I don't actually have to acquire the tasklist_lock at all.

tiocspgrp is also modified to take and release the lock.  The logic there is a
little more complicated but nothing I won't need when I convert pgrp of a tty
to a struct pid pointer.

Signed-off-by: Eric W. Biederman 
Cc: Alan Cox 
Cc: Oleg Nesterov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] close_files(): add scheduling point

2007-02-12T17:48:30+00:00

close_files() can sometimes take long enough to trigger the soft lockup
detector.

Cc: Eric Dumazet 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] Numerous fixes to kernel-doc info in source files.

2007-02-11T18:51:32+00:00

A variety of (mostly) innocuous fixes to the embedded kernel-doc content in
source files, including:

  * make multi-line initial descriptions single line
  * denote some function names, constants and structs as such
  * change erroneous opening '/*' to '/**' in a few places
  * reword some text for clarity

Signed-off-by: Robert P. J. Day 
Cc: "Randy.Dunlap" 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] namespaces: fix task exit disaster

2007-01-30T21:40:36+00:00

This is based on a patch by Eric W.  Biederman, who pointed out that pid
namespaces are still fake, and we only have one ever active.

So for the time being, we can modify any code which could access
tsk->nsproxy->pid_ns during task exit to just use &init_pid_ns instead,
and move the exit_task_namespaces call in do_exit() back above
exit_notify(), so that an exiting nfs server has a valid tsk->sighand to
work with.

Long term, pulling pid_ns out of nsproxy might be the cleanest solution.

Signed-off-by: Eric W. Biederman 

[ Eric's patch fixed to take care of free_pid() too ]

Signed-off-by: Serge E. Hallyn 
Signed-off-by: Linus Torvalds

Revert "[PATCH] namespaces: fix exit race by splitting exit"

2007-01-30T21:35:18+00:00

This reverts commit 7a238fcba0629b6f2edbcd37458bae56fcf36be5 in
preparation for a better and simpler fix proposed by Eric Biederman
(and fixed up by Serge Hallyn)

Acked-by: Serge E. Hallyn 
Signed-off-by: Linus Torvalds

[PATCH] namespaces: fix exit race by splitting exit

2007-01-30T16:26:44+00:00

Fix exit race by splitting the nsproxy putting into two pieces.  First
piece reduces the nsproxy refcount.  If we dropped the last reference, then
it puts the mnt_ns, and returns the nsproxy as a hint to the caller.  Else
it returns NULL.  The second piece of exiting task namespaces sets
tsk->nsproxy to NULL, and drops the references to other namespaces and
frees the nsproxy only if an nsproxy was passed in.

A little awkward and should probably be reworked, but hopefully it fixes
the NFS oops.

Signed-off-by: Serge E. Hallyn 
Cc: Herbert Poetzl 
Cc: Oleg Nesterov 
Cc: "Eric W. Biederman" 
Cc: Cedric Le Goater 
Cc: Daniel Hokka Zakrisson 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] restore ->pdeath_signal behaviour

2006-12-31T22:41:18+00:00

Commit b2b2cbc4b2a2f389442549399a993a8306420baf introduced a user-
visible change: ->pdeath_signal is sent only when the entire thread
group exits.

While this change is imho good, it may break things.  So restore the
old behaviour for now.

Signed-off-by: Oleg Nesterov 
To: Albert Cahalan 
Cc: Eric W. Biederman 
Cc: Andrew Morton 
Cc: Linus Torvalds 
Cc: Ingo Molnar 
Cc: Qi Yong 
Cc: Roland McGrath 
Signed-off-by: Linus Torvalds

[PATCH] Fix reparenting to the same thread group. (take 2)

2006-12-22T17:03:41+00:00

This patch fixes the case when we reparent to a different thread in the
same thread group.  This modifies the code so that we do not send
signals and do not change the signal to send to SIGCHLD unless we have
change the thread group of our parents.  It also suppresses sending
pdeath_sig in this cas as well since the result of geppid doesn't
change.

Thanks to Oleg for spotting my bug of only fixing this for non-ptraced
tasks.

Signed-off-by: Eric W. Biederman 
Cc: Mike Galbraith 
Cc: Albert Cahalan 
Cc: Andrew Morton 
Cc: Roland McGrath 
Cc: Ingo Molnar 
Cc: Coywolf Qi Hunt 
Acked-by: Oleg Nesterov 
Signed-off-by: Linus Torvalds