linux-toradex.git/kernel/fork.c, branch imx-android-r10.4

sched: Add a generic notifier when a task struct is about to be freed on Android

2011-02-12T07:47:05+00:00

This patch adds a notifier which can be used by subsystems that may
be interested in when a task has completely died and is about to
have it's last resource freed.
The Android lowmemory killer uses this to determine when a task
it has killed has finally given up its goods.

Signed-off-by: San Mehat

Revert "cpusets: randomize node rotor used in cpuset_mem_spread_node()"

2010-05-30T16:00:03+00:00

This reverts commit 0ac0c0d0f837c499afd02a802f9cf52d3027fa3b, which
caused cross-architecture build problems for all the wrong reasons.
IA64 already added its own version of __node_random(), but the fact is,
there is nothing architectural about the function, and the original
commit was just badly done. Revert it, since no fix is forthcoming.

Requested-by: Stephen Rothwell 
Signed-off-by: Linus Torvalds

pids: fix fork_idle() to setup ->pids correctly

2010-05-27T16:12:52+00:00

copy_process(pid => &init_struct_pid) doesn't do attach_pid/etc.

It shouldn't, but this means that the idle threads run with the wrong
pids copied from the caller's task_struct. In x86 case the caller is
either kernel_init() thread or keventd.

In particular, this means that after the series of cpu_up/cpu_down an
idle thread (which never exits) can run with .pid pointing to nowhere.

Change fork_idle() to initialize idle->pids[] correctly. We only set
.pid = &init_struct_pid but do not add .node to list, INIT_TASK() does
the same for the boot-cpu idle thread (swapper).

Signed-off-by: Oleg Nesterov 
Cc: Cedric Le Goater 
Cc: Dave Hansen 
Cc: Eric Biederman 
Cc: Herbert Poetzl 
Cc: Mathias Krause 
Acked-by: Roland McGrath 
Acked-by: Serge Hallyn 
Cc: Sukadev Bhattiprolu 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

proc: turn signal_struct->count into "int nr_threads"

2010-05-27T16:12:47+00:00

No functional changes, just s/atomic_t count/int nr_threads/.

With the recent changes this counter has a single user, get_nr_threads()
And, none of its callers need the really accurate number of threads, not
to mention each caller obviously races with fork/exit.  It is only used to
report this value to the user-space, except first_tid() uses it to avoid
the unnecessary while_each_thread() loop in the unlikely case.

It is a bit sad we need a word in struct signal_struct for this, perhaps
we can change get_nr_threads() to approximate the number of threads using
signal->live and kill ->nr_threads later.

[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Oleg Nesterov 
Cc: Alexey Dobriyan 
Cc: "Eric W. Biederman" 
Acked-by: Roland McGrath 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

check_unshare_flags: kill the bogus CLONE_SIGHAND/sig->count check

2010-05-27T16:12:47+00:00

check_unshare_flags(CLONE_SIGHAND) adds CLONE_THREAD to *flags_ptr if the
task is multithreaded to ensure unshare_thread() will fail.

Not only this is a bit strange way to return the error, this is absolutely
meaningless.  If signal->count > 1 then sighand->count must be also > 1,
and unshare_sighand() will fail anyway.

In fact, all CLONE_THREAD/SIGHAND/VM checks inside sys_unshare() do not
look right.  Fortunately this code doesn't really work anyway.

Signed-off-by: Oleg Nesterov 
Cc: Balbir Singh 
Acked-by: Roland McGrath 
Cc: Veaceslav Falico 
Cc: Stanislaw Gruszka 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

exit: move taskstats_tgid_free() from __exit_signal() to free_signal_struct()

2010-05-27T16:12:46+00:00

Move taskstats_tgid_free() from __exit_signal() to free_signal_struct().

This way signal->stats never points to nowhere and we can read ->stats
lockless.

Signed-off-by: Oleg Nesterov 
Cc: Balbir Singh 
Cc: Roland McGrath 
Cc: Veaceslav Falico 
Cc: Stanislaw Gruszka 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

kill the obsolete thread_group_cputime_free() helper

2010-05-27T16:12:46+00:00

Kill the empty thread_group_cputime_free() helper.  It was needed to free
the per-cpu data which we no longer have.

Signed-off-by: Oleg Nesterov 
Cc: Balbir Singh 
Cc: Roland McGrath 
Cc: Veaceslav Falico 
Cc: Stanislaw Gruszka 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

signals: make task_struct->signal immutable/refcountable

2010-05-27T16:12:46+00:00

We have a lot of problems with accessing task_struct->signal, it can
"disappear" at any moment.  Even current can't use its ->signal safely
after exit_notify().  ->siglock helps, but it is not convenient, not
always possible, and sometimes it makes sense to use task->signal even
after this task has already dead.

This patch adds the reference counter, sigcnt, into signal_struct.  This
reference is owned by task_struct and it is dropped in
__put_task_struct().  Perhaps it makes sense to export
get/put_signal_struct() later, but currently I don't see the immediate
reason.

Rename __cleanup_signal() to free_signal_struct() and unexport it.  With
the previous changes it does nothing except kmem_cache_free().

Change __exit_signal() to not clear/free ->signal, it will be freed when
the last reference to any thread in the thread group goes away.

Note:
	- when the last thead exits signal->tty can point to nowhere, see
	  the next patch.

	- with or without this patch signal_struct->count should go away,
	  or at least it should be "int nr_threads" for fs/proc. This will
	  be addressed later.

Signed-off-by: Oleg Nesterov 
Cc: Alan Cox 
Cc: Ingo Molnar 
Cc: Peter Zijlstra 
Acked-by: Roland McGrath 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

fork/exit: move tty_kref_put() outside of __cleanup_signal()

2010-05-27T16:12:46+00:00

tty_kref_put() has two callsites in copy_process() paths,

	1. if copy_process() suceeds it is called before we copy
	   signal->tty from parent

	2. otherwise it is called from __cleanup_signal() under
	   bad_fork_cleanup_signal: label

In both cases tty_kref_put() is not right and unneeded because we don't
have the balancing tty_kref_get().  Fortunately, this is harmless because
this can only happen without CLONE_THREAD, and in this case signal->tty
must be NULL.

Remove tty_kref_put() from copy_process() and __cleanup_signal(), and
change another caller of __cleanup_signal(), __exit_signal(), to call
tty_kref_put() by hand.

I hope this change makes sense by itself, but it is also needed to make
->signal refcountable.

Signed-off-by: Oleg Nesterov 
Acked-by: Alan Cox 
Acked-by: Roland McGrath 
Cc: Greg KH 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

cpusets: randomize node rotor used in cpuset_mem_spread_node()

2010-05-27T16:12:44+00:00

Some workloads that create a large number of small files tend to assign
too many pages to node 0 (multi-node systems).  Part of the reason is that
the rotor (in cpuset_mem_spread_node()) used to assign nodes starts at
node 0 for newly created tasks.

This patch changes the rotor to be initialized to a random node number of
the cpuset.

[akpm@linux-foundation.org: fix layout]
[Lee.Schermerhorn@hp.com: Define stub numa_random() for !NUMA configuration]
Signed-off-by: Jack Steiner 
Signed-off-by: Lee Schermerhorn 
Cc: Christoph Lameter 
Cc: Pekka Enberg 
Cc: Paul Menage 
Cc: Jack Steiner 
Cc: Robin Holt 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds