linux-toradex.git/kernel/kcsan/debugfs.c, branch v5.14-rc6

kcsan: Fix debugfs initcall return type

2021-05-18T17:58:02+00:00

clang with CONFIG_LTO_CLANG points out that an initcall function should
return an 'int' due to the changes made to the initcall macros in commit
3578ad11f3fb ("init: lto: fix PREL32 relocations"):

kernel/kcsan/debugfs.c:274:15: error: returning 'void' from a function with incompatible result type 'int'
late_initcall(kcsan_debugfs_init);
~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
include/linux/init.h:292:46: note: expanded from macro 'late_initcall'
 #define late_initcall(fn)               __define_initcall(fn, 7)

Fixes: e36299efe7d7 ("kcsan, debugfs: Move debugfs file creation out of early init")
Cc: stable 
Reviewed-by: Greg Kroah-Hartman 
Reviewed-by: Marco Elver 
Reviewed-by: Nathan Chancellor 
Reviewed-by: Miguel Ojeda 
Signed-off-by: Arnd Bergmann 
Signed-off-by: Paul E. McKenney

kcsan: Add missing license and copyright headers

2021-03-08T22:27:43+00:00

Adds missing license and/or copyright headers for KCSAN source files.

Signed-off-by: Marco Elver 
Signed-off-by: Paul E. McKenney

kcsan, debugfs: Move debugfs file creation out of early init

2021-03-08T22:27:43+00:00

Commit 56348560d495 ("debugfs: do not attempt to create a new file
before the filesystem is initalized") forbids creating new debugfs files
until debugfs is fully initialized.  This means that KCSAN's debugfs
file creation, which happened at the end of __init(), no longer works.
And was apparently never supposed to work!

However, there is no reason to create KCSAN's debugfs file so early.
This commit therefore moves its creation to a late_initcall() callback.

Cc: "Rafael J. Wysocki" 
Cc: stable 
Fixes: 56348560d495 ("debugfs: do not attempt to create a new file before the filesystem is initalized")
Reviewed-by: Greg Kroah-Hartman 
Signed-off-by: Marco Elver 
Signed-off-by: Paul E. McKenney

kcsan: Optimize debugfs stats counters

2020-08-24T22:10:23+00:00

Remove kcsan_counter_inc/dec() functions, as they perform no other
logic, and are no longer needed.

This avoids several calls in kcsan_setup_watchpoint() and
kcsan_found_watchpoint(), as well as lets the compiler warn us about
potential out-of-bounds accesses as the array's size is known at all
usage sites at compile-time.

Signed-off-by: Marco Elver 
Signed-off-by: Paul E. McKenney

kcsan: Use pr_fmt for consistency

2020-08-24T22:10:23+00:00

Use the same pr_fmt throughout for consistency. [ The only exception is
report.c, where the format must be kept precisely as-is. ]

Signed-off-by: Marco Elver 
Signed-off-by: Paul E. McKenney

kcsan: Remove debugfs test command

2020-08-24T22:10:22+00:00

Remove the debugfs test command, as it is no longer needed now that we
have the KUnit+Torture based kcsan-test module. This is to avoid
confusion around how KCSAN should be tested, as only the kcsan-test
module is maintained.

Signed-off-by: Marco Elver 
Signed-off-by: Paul E. McKenney

kcsan: Simplify constant string handling

2020-08-24T22:10:22+00:00

Simplify checking prefixes and length calculation of constant strings.
For the former, the kernel provides str_has_prefix(), and the latter we
should just use strlen("..") because GCC and Clang have optimizations
that optimize these into constants.

No functional change intended.

Signed-off-by: Marco Elver 
Signed-off-by: Paul E. McKenney

kcsan: Simplify debugfs counter to name mapping

2020-08-24T22:10:21+00:00

Simplify counter ID to name mapping by using an array with designated
inits. This way, we can turn a run-time BUG() into a compile-time static
assertion failure if a counter name is missing.

No functional change intended.

Signed-off-by: Marco Elver 
Signed-off-by: Paul E. McKenney

kcsan: Use GFP_ATOMIC under spin lock

2020-04-27T18:10:10+00:00

A spin lock is held in insert_report_filterlist(), so the krealloc()
should use GFP_ATOMIC.  This commit therefore makes this change.

Reviewed-by: Marco Elver 
Signed-off-by: Wei Yongjun 
Signed-off-by: Paul E. McKenney

kcsan: Introduce scoped ASSERT_EXCLUSIVE macros

2020-04-14T00:18:13+00:00

Introduce ASSERT_EXCLUSIVE_*_SCOPED(), which provide an intuitive
interface to use the scoped-access feature, without having to explicitly
mark the start and end of the desired scope. Basing duration of the
checks on scope avoids accidental misuse and resulting false positives,
which may be hard to debug. See added comments for usage.

The macros are implemented using __attribute__((__cleanup__(func))),
which is supported by all compilers that currently support KCSAN.

Suggested-by: Boqun Feng 
Suggested-by: Paul E. McKenney 
Signed-off-by: Marco Elver 
Signed-off-by: Paul E. McKenney