linux-toradex.git/kernel/kfifo.c, branch v2.6.34.15

kfifo: Don't use integer as NULL pointer

2010-02-16T23:11:08+00:00

This patch fixes following sparse warnings:

include/linux/kfifo.h:127:25: warning: Using plain integer as NULL pointer
kernel/kfifo.c:83:21: warning: Using plain integer as NULL pointer

Signed-off-by: Anton Vorontsov 
Acked-by: Stefani Seibold 
Signed-off-by: Greg Kroah-Hartman

kfifo: Make kfifo_initialized work after kfifo_free

2010-02-16T23:11:06+00:00

After kfifo rework it's no longer possible to reliably know if kfifo is
usable, since after kfifo_free(), kfifo_initialized() would still return
true. The correct behaviour is needed for at least FHCI USB driver.

This patch fixes the issue by resetting the kfifo to zero values (the
same approach is used in kfifo_alloc() if allocation failed).

Signed-off-by: Anton Vorontsov 
Acked-by: Stefani Seibold 
Signed-off-by: Greg Kroah-Hartman

kfifo: fix kernel-doc notation

2010-02-03T02:11:21+00:00

Fix kfifo kernel-doc warnings:

Warning(kernel/kfifo.c:361): No description found for parameter 'total'
Warning(kernel/kfifo.c:402): bad line:  @ @lenout: pointer to output variable with copied data
Warning(kernel/kfifo.c:412): No description found for parameter 'lenout'

Signed-off-by: Randy Dunlap 
Cc: Stefani Seibold 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

kfifo: document everywhere that size has to be power of two

2010-01-16T20:15:38+00:00

On my first try using them I missed that the fifos need to be power of
two, resulting in a runtime bug.  Document that requirement everywhere
(and fix one grammar bug)

Signed-off-by: Andi Kleen 
Acked-by: Stefani Seibold 
Cc: Roland Dreier 
Cc: Dmitry Torokhov 
Cc: Andy Walls 
Cc: Vikram Dhillon 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

kfifo: add kfifo_out_peek

2010-01-16T20:15:38+00:00

In some upcoming code it's useful to peek into a FIFO without permanentely
removing data.  This patch implements a new kfifo_out_peek() to do this.

Signed-off-by: Andi Kleen 
Acked-by: Stefani Seibold 
Cc: Roland Dreier 
Cc: Dmitry Torokhov 
Cc: Andy Walls 
Cc: Vikram Dhillon 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

kfifo: sanitize *_user error handling

2010-01-16T20:15:38+00:00

Right now for kfifo_*_user it's not easily possible to distingush between
a user copy failing and the FIFO not containing enough data.  The problem
is that both conditions are multiplexed into the same return code.

Avoid this by moving the "copy length" into a separate output parameter
and only return 0/-EFAULT in the main return value.

I didn't fully adapt the weird "record" variants, those seem
to be unused anyways and were rather messy (should they be just removed?)

I would appreciate some double checking if I did all the conversions
correctly.

Signed-off-by: Andi Kleen 
Cc: Stefani Seibold 
Cc: Roland Dreier 
Cc: Dmitry Torokhov 
Cc: Andy Walls 
Cc: Vikram Dhillon 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

kfifo: use void * pointers for user buffers

2010-01-16T20:15:38+00:00

The pointers to user buffers are currently unsigned char *, which requires
a lot of casting in the caller for any non-char typed buffers.  Use void *
instead.

Signed-off-by: Andi Kleen 
Acked-by: Stefani Seibold 
Cc: Roland Dreier 
Cc: Dmitry Torokhov 
Cc: Andy Walls 
Cc: Vikram Dhillon 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

kfifo: add record handling functions

2009-12-22T22:17:56+00:00

Add kfifo_in_rec() - puts some record data into the FIFO
 Add kfifo_out_rec() - gets some record data from the FIFO
 Add kfifo_from_user_rec() - puts some data from user space into the FIFO
 Add kfifo_to_user_rec() - gets data from the FIFO and write it to user space
 Add kfifo_peek_rec() - gets the size of the next FIFO record field
 Add kfifo_skip_rec() - skip the next fifo out record
 Add kfifo_avail_rec() - determinate the number of bytes available in a record FIFO

Signed-off-by: Stefani Seibold 
Acked-by: Greg Kroah-Hartman 
Acked-by: Mauro Carvalho Chehab 
Acked-by: Andi Kleen 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

kfifo: add kfifo_skip, kfifo_from_user and kfifo_to_user

2009-12-22T22:17:56+00:00

Add kfifo_reset_out() for save lockless discard the fifo output
 Add kfifo_skip() to skip a number of output bytes
 Add kfifo_from_user() to copy user space data into the fifo
 Add kfifo_to_user() to copy fifo data to user space

Signed-off-by: Stefani Seibold 
Acked-by: Greg Kroah-Hartman 
Acked-by: Mauro Carvalho Chehab 
Acked-by: Andi Kleen 
Acked-by: Arnd Bergmann 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

kfifo: rename kfifo_put... into kfifo_in... and kfifo_get... into kfifo_out...

2009-12-22T22:17:56+00:00

rename kfifo_put...  into kfifo_in...  to prevent miss use of old non in
kernel-tree drivers

ditto for kfifo_get...  -> kfifo_out...

Improve the prototypes of kfifo_in and kfifo_out to make the kerneldoc
annotations more readable.

Add mini "howto porting to the new API" in kfifo.h

Signed-off-by: Stefani Seibold 
Acked-by: Greg Kroah-Hartman 
Acked-by: Mauro Carvalho Chehab 
Acked-by: Andi Kleen 
Acked-by: Arnd Bergmann 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds