linux-toradex.git/kernel/module.c, branch v2.6.23.12

Fix Off-by-one in /sys/module/*/refcnt

2007-08-22T21:35:35+00:00

sysfs internals were changed to not pin module in question.

Signed-off-by: Alexey Dobriyan 
Acked-by: Kay Sievers 
Acked-by: Tejun Heo 
Signed-off-by: Greg Kroah-Hartman

kallsyms: make KSYM_NAME_LEN include space for trailing '\0'

2007-07-17T17:23:03+00:00

KSYM_NAME_LEN is peculiar in that it does not include the space for the
trailing '\0', forcing all users to use KSYM_NAME_LEN + 1 when allocating
buffer.  This is nonsense and error-prone.  Moreover, when the caller
forgets that it's very likely to subtly bite back by corrupting the stack
because the last position of the buffer is always cleared to zero.

This patch increments KSYM_NAME_LEN by one and updates code accordingly.

* off-by-one bug in asm-powerpc/kprobes.h::kprobe_lookup_name() macro
  is fixed.

* Where MODULE_NAME_LEN and KSYM_NAME_LEN were used together,
  MODULE_NAME_LEN was treated as if it didn't include space for the
  trailing '\0'.  Fix it.

Signed-off-by: Tejun Heo 
Acked-by: Paulo Marques 
Cc: Benjamin Herrenschmidt 
Cc: Paul Mackerras 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

modules: remove modlist_lock

2007-07-16T16:05:51+00:00

Now we always use stop_machine for module insertion or deletion, we no
longer need the modlist_lock: merely disabling preemption is sufficient to
block against list manipulation.  This avoids deadlock on OOPSen where we
can potentially grab the lock twice.

Bug: 8695
Signed-off-by: Rusty Russell 
Cc: Ingo Molnar 
Cc: Tobias Oed 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Make /proc/modules use seq_list_xxx helpers

2007-07-16T16:05:42+00:00

Here there is not need even in .show callback altering.  The original code
passes list_head in *v.

Signed-off-by: Pavel Emelianov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

sysfs: kill unnecessary attribute->owner

2007-07-11T23:09:06+00:00

sysfs is now completely out of driver/module lifetime game.  After
deletion, a sysfs node doesn't access anything outside sysfs proper,
so there's no reason to hold onto the attribute owners.  Note that
often the wrong modules were accounted for as owners leading to
accessing removed modules.

This patch kills now unnecessary attribute->owner.  Note that with
this change, userland holding a sysfs node does not prevent the
backing module from being unloaded.

For more info regarding lifetime rule cleanup, please read the
following message.

  http://article.gmane.org/gmane.linux.kernel/510293

(tweaked by Greg to not delete the field just yet, to make it easier to
merge things properly.)

Signed-off-by: Tejun Heo 
Cc: Cornelia Huck 
Cc: Andrew Morton 
Signed-off-by: Greg Kroah-Hartman

Fix minor typoes in kernel/module.c

2007-05-09T05:26:28+00:00

Fix minor (comment) typoes in kernel/module.c.

Signed-off-by: Robert P. J. Day 
Signed-off-by: Adrian Bunk

Fix race between cat /proc/slab_allocators and rmmod

2007-05-08T18:15:08+00:00

Same story as with cat /proc/*/wchan race vs rmmod race, only
/proc/slab_allocators want more info than just symbol name.

Signed-off-by: Alexey Dobriyan 
Acked-by: Rusty Russell 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Fix race between cat /proc/*/wchan and rmmod et al

2007-05-08T18:15:08+00:00

kallsyms_lookup() can go iterating over modules list unprotected which is OK
for emergency situations (oops), but not OK for regular stuff like
/proc/*/wchan.

Introduce lookup_symbol_name()/lookup_module_symbol_name() which copy symbol
name into caller-supplied buffer or return -ERANGE.  All copying is done with
module_mutex held, so...

Signed-off-by: Alexey Dobriyan 
Cc: Rusty Russell 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Simplify kallsyms_lookup()

2007-05-08T18:15:08+00:00

Several kallsyms_lookup() pass dummy arguments but only need, say, module's
name.  Make kallsyms_lookup() accept NULLs where possible.

Also, makes picture clearer about what interfaces are needed for all symbol
resolving business.

Signed-off-by: Alexey Dobriyan 
Cc: Rusty Russell 
Acked-by: Ingo Molnar 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Fix race between rmmod and cat /proc/kallsyms

2007-05-08T18:15:08+00:00

module_get_kallsym() leaks "struct module *" outside of module_mutex which is
no-no, because module can dissapear right after mutex unlock.

Copy all needed information from inside module_mutex into caller-supplied
space.

[bunk@stusta.de: is_exported() can now become static]
Signed-off-by: Alexey Dobriyan 
Cc: Rusty Russell 
Signed-off-by: Adrian Bunk 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds