linux-toradex.git/kernel/module.c, branch v5.12-rc5

module: potential uninitialized return in module_kallsyms_on_each_symbol()

2021-02-10T15:57:04+00:00

Smatch complains that:

	kernel/module.c:4472 module_kallsyms_on_each_symbol()
        error: uninitialized symbol 'ret'.

This warning looks like it could be correct if the &modules list is
empty.

Fixes: 013c1667cf78 ("kallsyms: refactor {,module_}kallsyms_on_each_symbol")
Reviewed-by: Miroslav Benes 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Dan Carpenter 
Signed-off-by: Jessica Yu

module: remove EXPORT_UNUSED_SYMBOL*

2021-02-08T11:28:07+00:00

EXPORT_UNUSED_SYMBOL* is not actually used anywhere.  Remove the
unused functionality as we generally just remove unused code anyway.

Reviewed-by: Miroslav Benes 
Reviewed-by: Emil Velikov 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jessica Yu

module: remove EXPORT_SYMBOL_GPL_FUTURE

2021-02-08T11:28:02+00:00

As far as I can tell this has never been used at all, and certainly
not any time recently.

Reviewed-by: Miroslav Benes 
Reviewed-by: Emil Velikov 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jessica Yu

module: move struct symsearch to module.c

2021-02-08T11:27:43+00:00

struct symsearch is only used inside of module.h, so move the definition
out of module.h.

Reviewed-by: Miroslav Benes 
Reviewed-by: Emil Velikov 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jessica Yu

module: pass struct find_symbol_args to find_symbol

2021-02-08T11:25:19+00:00

Simplify the calling convention by passing the find_symbol_args structure
to find_symbol instead of initializing it inside the function.

Reviewed-by: Miroslav Benes 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jessica Yu

module: merge each_symbol_section into find_symbol

2021-02-08T11:25:07+00:00

each_symbol_section is only called by find_symbol, so merge the two
functions.

Reviewed-by: Miroslav Benes 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jessica Yu

module: remove each_symbol_in_section

2021-02-08T11:24:54+00:00

each_symbol_in_section just contains a trivial loop over its arguments.
Just open code the loop in the two callers.

Reviewed-by: Miroslav Benes 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jessica Yu

module: mark module_mutex static

2021-02-08T11:24:26+00:00

Except for two lockdep asserts module_mutex is only used in module.c.
Remove the two asserts given that the functions they are in are not
exported and just called from the module code, and mark module_mutex
static.

Reviewed-by: Miroslav Benes 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jessica Yu

kallsyms: only build {,module_}kallsyms_on_each_symbol when required

2021-02-08T11:24:04+00:00

kallsyms_on_each_symbol and module_kallsyms_on_each_symbol are only used
by the livepatching code, so don't build them if livepatching is not
enabled.

Reviewed-by: Miroslav Benes 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jessica Yu

kallsyms: refactor {,module_}kallsyms_on_each_symbol

2021-02-08T11:22:08+00:00

Require an explicit call to module_kallsyms_on_each_symbol to look
for symbols in modules instead of the call from kallsyms_on_each_symbol,
and acquire module_mutex inside of module_kallsyms_on_each_symbol instead
of leaving that up to the caller.  Note that this slightly changes the
behavior for the livepatch code in that the symbols from vmlinux are not
iterated anymore if objname is set, but that actually is the desired
behavior in this case.

Reviewed-by: Petr Mladek 
Acked-by: Miroslav Benes 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jessica Yu