linux-toradex.git/kernel/nsproxy.c, branch v2.6.22-rc7

fix refcounting of nsproxy object when unshared

2007-06-24T15:59:10+00:00

When a namespace is unshared, a refcount on the previous nsproxy is
abusively taken, leading to a memory leak of nsproxy objects.

Signed-off-by: Cedric Le Goater 
Cc: Badari Pulavarty 
Cc: Herbert Poetzl 
Cc: Oleg Nesterov 
Cc: "Eric W. Biederman" 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Merge sys_clone()/sys_unshare() nsproxy and namespace handling

2007-05-08T18:15:00+00:00

sys_clone() and sys_unshare() both makes copies of nsproxy and its associated
namespaces.  But they have different code paths.

This patch merges all the nsproxy and its associated namespace copy/clone
handling (as much as possible).  Posted on container list earlier for
feedback.

- Create a new nsproxy and its associated namespaces and pass it back to
  caller to attach it to right process.

- Changed all copy_*_ns() routines to return a new copy of namespace
  instead of attaching it to task->nsproxy.

- Moved the CAP_SYS_ADMIN checks out of copy_*_ns() routines.

- Removed unnessary !ns checks from copy_*_ns() and added BUG_ON()
  just incase.

- Get rid of all individual unshare_*_ns() routines and make use of
  copy_*_ns() instead.

[akpm@osdl.org: cleanups, warning fix]
[clg@fr.ibm.com: remove dup_namespaces() declaration]
[serue@us.ibm.com: fix CONFIG_IPC_NS=n, clone(CLONE_NEWIPC) retval]
[akpm@linux-foundation.org: fix build with CONFIG_SYSVIPC=n]
Signed-off-by: Badari Pulavarty 
Signed-off-by: Serge Hallyn 
Cc: Cedric Le Goater 
Cc: "Eric W. Biederman" 
Cc: 
Signed-off-by: Cedric Le Goater 
Cc: Oleg Nesterov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Revert "[PATCH] namespaces: fix exit race by splitting exit"

2007-01-30T21:35:18+00:00

This reverts commit 7a238fcba0629b6f2edbcd37458bae56fcf36be5 in
preparation for a better and simpler fix proposed by Eric Biederman
(and fixed up by Serge Hallyn)

Acked-by: Serge E. Hallyn 
Signed-off-by: Linus Torvalds

[PATCH] namespaces: fix exit race by splitting exit

2007-01-30T16:26:44+00:00

Fix exit race by splitting the nsproxy putting into two pieces.  First
piece reduces the nsproxy refcount.  If we dropped the last reference, then
it puts the mnt_ns, and returns the nsproxy as a hint to the caller.  Else
it returns NULL.  The second piece of exiting task namespaces sets
tsk->nsproxy to NULL, and drops the references to other namespaces and
frees the nsproxy only if an nsproxy was passed in.

A little awkward and should probably be reworked, but hopefully it fixes
the NFS oops.

Signed-off-by: Serge E. Hallyn 
Cc: Herbert Poetzl 
Cc: Oleg Nesterov 
Cc: "Eric W. Biederman" 
Cc: Cedric Le Goater 
Cc: Daniel Hokka Zakrisson 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] Revert "[PATCH] identifier to nsproxy"

2006-12-13T17:05:47+00:00

This reverts commit 373beb35cd6b625e0ba4ad98baace12310a26aa8.

No one is using this identifier yet.  The purpose of this identifier is to
export nsproxy to user space which is wrong.  nsproxy is an internal
implementation optimization, which should keep our fork times from getting
slower as we increase the number of global namespaces you don't have to
share.

Adding a global identifier like this is inappropriate because it makes
namespaces inherently non-recursive, greatly limiting what we can do with
them in the future.

Signed-off-by: Eric W. Biederman 
Cc: Cedric Le Goater 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] to nsproxy

2006-12-08T16:28:52+00:00

Add the pid namespace framework to the nsproxy object.  The copy of the pid
namespace only increases the refcount on the global pid namespace,
init_pid_ns, and unshare is not implemented.

There is no configuration option to activate or deactivate this feature
because this not relevant for the moment.

Signed-off-by: Cedric Le Goater 
Cc: Kirill Korotaev 
Cc: Eric W. Biederman 
Cc: Herbert Poetzl 
Cc: Sukadev Bhattiprolu 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] identifier to nsproxy

2006-12-08T16:28:52+00:00

Add an identifier to nsproxy.  The default init_ns_proxy has identifier 0 and
allocated nsproxies are given -1.

This identifier will be used by a new syscall sys_bind_ns.

Signed-off-by: Cedric Le Goater 
Cc: Kirill Korotaev 
Cc: Eric W. Biederman 
Cc: Herbert Poetzl 
Cc: Sukadev Bhattiprolu 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] rename struct namespace to struct mnt_namespace

2006-12-08T16:28:51+00:00

Rename 'struct namespace' to 'struct mnt_namespace' to avoid confusion with
other namespaces being developped for the containers : pid, uts, ipc, etc.
'namespace' variables and attributes are also renamed to 'mnt_ns'

Signed-off-by: Kirill Korotaev 
Signed-off-by: Cedric Le Goater 
Cc: Eric W. Biederman 
Cc: Herbert Poetzl 
Cc: Sukadev Bhattiprolu 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] kernel/nsproxy.c: use kmemdup()

2006-10-20T17:26:44+00:00

Signed-off-by: Alexey Dobriyan 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] nsproxy cloning error path fix

2006-10-02T14:57:22+00:00

This patch fixes copy_namespaces()'s error path.

when new nsproxy (new_ns) is created pointers to namespaces (ipc, uts) are
copied from the old nsproxy.  Later in copy_utsname, copy_ipcs, etc.
according namespaces are get-ed.  On error path needed namespaces are
put-ed, so there's no need to put new nsproxy itelf as it woud cause
putting namespaces for the second time.

Found when incorporating namespaces into OpenVZ kernel.

Signed-off-by: Pavel Emelianov 
Acked-by: Serge Hallyn 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds