linux-toradex.git/kernel/sysctl.c, branch v7.0-rc6

sysctl: fix uninitialized variable in proc_do_large_bitmap

2026-03-26T08:32:19+00:00

proc_do_large_bitmap() does not initialize variable c, which is expected
to be set to a trailing character by proc_get_long().

However, proc_get_long() only sets c when the input buffer contains a
trailing character after the parsed value.

If c is not initialized it may happen to contain a '-'. If this is the
case proc_do_large_bitmap() expects to be able to parse a second part of
the input buffer. If there is no second part an unjustified -EINVAL will
be returned.

Initialize c to 0 to prevent returning -EINVAL on valid input.

Fixes: 9f977fb7ae9d ("sysctl: add proc_do_large_bitmap")
Signed-off-by: Marc Buerg 
Reviewed-by: Joel Granados 
Signed-off-by: Joel Granados

sysctl: replace SYSCTL_INT_CONV_CUSTOM macro with functions

2026-01-06T10:27:10+00:00

Remove SYSCTL_INT_CONV_CUSTOM and replace it with proc_int_conv. This
converter function expects a negp argument as it can take on negative
values. Update all jiffies converters to use explicit function calls.
Remove SYSCTL_CONV_IDENTITY as it is no longer used.

Signed-off-by: Joel Granados

sysctl: Replace unidirectional INT converter macros with functions

2026-01-06T10:26:42+00:00

Replace SYSCTL_USER_TO_KERN_INT_CONV and SYSCTL_KERN_TO_USER_INT_CONV
macros with function implementing the same logic.This makes debugging
easier and aligns with the functions preference described in
coding-style.rst. Update all jiffies converters to use explicit function
implementations instead of macro-generated versions.

Signed-off-by: Joel Granados

sysctl: Add kernel doc to proc_douintvec_conv

2026-01-05T13:10:32+00:00

This commit is making sure that all the functions that are part of the
API are documented.

Signed-off-by: Joel Granados

sysctl: Replace UINT converter macros with functions

2026-01-05T13:10:32+00:00

Replace the SYSCTL_USER_TO_KERN_UINT_CONV and SYSCTL_UINT_CONV_CUSTOM
macros with functions with the same logic. This makes debugging easier
and aligns with the functions preference described in coding-style.rst.
Update the only user of this API: pipe.c.

Signed-off-by: Joel Granados

sysctl: clarify proc_douintvec_minmax doc

2026-01-05T13:10:32+00:00

Specify that the range check is only when assigning kernel variable

Signed-off-by: Joel Granados

sysctl: Return -ENOSYS from proc_douintvec_conv when CONFIG_PROC_SYSCTL=n

2026-01-05T13:10:32+00:00

Ensure an error if prco_douintvec_conv is erroneously called in a system
with CONFIG_PROC_SYSCTL=n

Signed-off-by: Joel Granados

sysctl: Add missing kernel-doc for proc_dointvec_conv

2026-01-05T12:36:45+00:00

Add kernel-doc documentation for the proc_dointvec_conv function to
describe its parameters and return value.

Reviewed-by: Kees Cook 
Signed-off-by: Joel Granados

sysctl: Wrap do_proc_douintvec with the public function proc_douintvec_conv

2025-11-27T14:45:38+00:00

Make do_proc_douintvec static and export proc_douintvec_conv wrapper
function for external use. This is to keep with the design in sysctl.c.
Update fs/pipe.c to use the new public API.

Signed-off-by: Joel Granados

sysctl: Create pipe-max-size converter using sysctl UINT macros

2025-11-27T14:45:37+00:00

Create a converter for the pipe-max-size proc_handler using the
SYSCTL_UINT_CONV_CUSTOM. Move SYSCTL_CONV_IDENTITY macro to the sysctl
header to make it available for pipe size validation. Keep returning
-EINVAL when (val == 0) by using a range checking converter and setting
the minimal valid value (extern1) to SYSCTL_ONE. Keep round_pipe_size by
passing it as the operation for SYSCTL_USER_TO_KERN_INT_CONV.

Signed-off-by: Joel Granados