linux-toradex.git/kernel/time/alarmtimer.c, branch v3.4.73

alarmtimer: return EINVAL instead of ENOTSUPP if rtcdev doesn't exist

2013-12-04T18:50:14+00:00

commit 98d6f4dd84a134d942827584a3c5f67ffd8ec35f upstream.

Fedora Ruby maintainer reported latest Ruby doesn't work on Fedora Rawhide
on ARM. (http://bugs.ruby-lang.org/issues/9008)

Because of, commit 1c6b39ad3f (alarmtimers: Return -ENOTSUPP if no
RTC device is present) intruduced to return ENOTSUPP when
clock_get{time,res} can't find a RTC device. However this is incorrect.

First, ENOTSUPP isn't exported to userland (ENOTSUP or EOPNOTSUP are the
closest userland equivlents).

Second, Posix and Linux man pages agree that clock_gettime and
clock_getres should return EINVAL if clk_id argument is invalid.
While the arugment that the clockid is valid, but just not supported
on this hardware could be made, this is just a technicality that
doesn't help userspace applicaitons, and only complicates error
handling.

Thus, this patch changes the code to use EINVAL.

Cc: Thomas Gleixner 
Cc: Frederic Weisbecker 
Reported-by: Vit Ondruch 
Signed-off-by: KOSAKI Motohiro 
[jstultz: Tweaks to commit message to include full rational]
Signed-off-by: John Stultz 
Signed-off-by: Greg Kroah-Hartman

alarmtimer: Don't call rtc_timer_init() when CONFIG_RTC_CLASS=n

2012-03-24T11:46:23+00:00

rtc_timer_init() is not available when CONFIG_RTC_CLASS=n. Provide a
proper wrapper in the RTC section of alarmtimer.c

Reported-by: Ingo Molnar 
Signed-off-by: Thomas Gleixner 
Cc: John Stultz

alarmtimer: Make sure we initialize the rtctimer

2012-03-23T23:23:12+00:00

jonghwan Choi reported seeing warnings with the alarmtimer
code at suspend/resume time, and pointed out that the
rtctimer isn't being properly initialized.

This patch corrects this issue.

Reported-by: jonghwan Choi 
Signed-off-by: John Stultz

alarmtimers: Fix time comparison

2011-12-06T10:38:32+00:00

The expiry function compares the timer against current time and does
not expire the timer when the expiry time is >= now. That's wrong. If
the timer is set for now, then it must expire.

Make the condition expiry > now for breaking out the loop.

Signed-off-by: Thomas Gleixner 
Acked-by: John Stultz 
Cc: stable@kernel.org

alarmtimers: Fix error handling

2011-09-14T08:54:29+00:00

commit 8bc0daf (alarmtimers: Rework RTC device selection using class
interface) did not implement required error checks. Add them.

Signed-off-by: Thomas Gleixner

alarmtimers: Rework RTC device selection using class interface

2011-08-10T21:55:30+00:00

This allows cleaner detection of the RTC device being registered, rather
then probing any time someone calls alarmtimer_get_rtcdev.

CC: Thomas Gleixner 
Signed-off-by: John Stultz

alarmtimers: Add try_to_cancel functionality

2011-08-10T21:55:29+00:00

There's a number of edge cases when cancelling a alarm, so
to be sure we accurately do so, introduce try_to_cancel, which
returns proper failure errors if it cannot. Also modify cancel
to spin until the alarm is properly disabled.

CC: Thomas Gleixner 
Signed-off-by: John Stultz

alarmtimers: Add more refined alarm state tracking

2011-08-10T21:55:27+00:00

In order to allow for functionality like try_to_cancel, add
more refined  state tracking (similar to hrtimers).

CC: Thomas Gleixner 
Signed-off-by: John Stultz

alarmtimers: Remove period from alarm structure

2011-08-10T21:55:26+00:00

Now that periodic alarmtimers are managed by the handler function,
remove the period value from the alarm structure and let the handlers
manage the interval on their own.

CC: Thomas Gleixner 
Signed-off-by: John Stultz

alarmtimers: Remove interval cap limit hack

2011-08-10T21:55:24+00:00

Now that the alarmtimers code has been refactored, the interval
cap limit can be removed.

CC: Thomas Gleixner 
Signed-off-by: John Stultz