linux-toradex.git/kernel/time/posix-clock.c, branch v5.1-rc1

timex: use __kernel_timex internally

2019-02-06T23:13:27+00:00

struct timex is not y2038 safe.
Replace all uses of timex with y2038 safe __kernel_timex.

Note that struct __kernel_timex is an ABI interface definition.
We could define a new structure based on __kernel_timex that
is only available internally instead. Right now, there isn't
a strong motivation for this as the structure is isolated to
a few defined struct timex interfaces and such a structure would
be exactly the same as struct timex.

The patch was generated by the following coccinelle script:

virtual patch

@depends on patch forall@
identifier ts;
expression e;
@@
(
- struct timex ts;
+ struct __kernel_timex ts;
|
- struct timex ts = {};
+ struct __kernel_timex ts = {};
|
- struct timex ts = e;
+ struct __kernel_timex ts = e;
|
- struct timex *ts;
+ struct __kernel_timex *ts;
|
(memset \| copy_from_user \| copy_to_user \)(...,
- sizeof(struct timex))
+ sizeof(struct __kernel_timex))
)

@depends on patch forall@
identifier ts;
identifier fn;
@@
fn(...,
- struct timex *ts,
+ struct __kernel_timex *ts,
...) {
...
}

@depends on patch forall@
identifier ts;
identifier fn;
@@
fn(...,
- struct timex *ts) {
+ struct __kernel_timex *ts) {
...
}

Signed-off-by: Deepa Dinamani 
Cc: linux-alpha@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Arnd Bergmann

posix-clocks: Remove license boiler plate

2018-11-23T10:51:22+00:00

The SPDX identifier defines the license of the file already. No need for
the boilerplate.

Signed-off-by: Thomas Gleixner 
Acked-by: Richard Cochran 
Acked-by: Kees Cook 
Acked-by: Ingo Molnar 
Acked-by: Manfred Rudigier 
Acked-by: John Stultz 
Acked-by: Corey Minyard 
Cc: Peter Zijlstra 
Cc: Kate Stewart 
Cc: Philippe Ombredanne 
Cc: Peter Anvin 
Cc: Russell King 
Cc: "Paul E. McKenney" 
Cc: Nicolas Pitre 
Cc: David Riley 
Cc: Colin Cross 
Cc: Mark Brown 
Link: https://lkml.kernel.org/r/20181031182253.385909804@linutronix.de

time: Add SPDX license identifiers

2018-11-23T10:51:20+00:00

Update the time(r) core files files with the correct SPDX license
identifier based on the license text in the file itself. The SPDX
identifier is a legally binding shorthand, which can be used instead of the
full boiler plate text.

This work is based on a script and data from Philippe Ombredanne, Kate
Stewart and myself. The data has been created with two independent license
scanners and manual inspection.

The following files do not contain any direct license information and have
been omitted from the big initial SPDX changes:

  timeconst.bc: The .bc files were not touched
  time.c, timer.c, timekeeping.c: Licence was deduced from EXPORT_SYMBOL_GPL

As those files do not contain direct license references they fall under the
project license, i.e. GPL V2 only.

Signed-off-by: Thomas Gleixner 
Acked-by: Kees Cook 
Acked-by: Ingo Molnar 
Acked-by: John Stultz 
Acked-by: Corey Minyard 
Cc: Peter Zijlstra 
Cc: Kate Stewart 
Cc: Philippe Ombredanne 
Cc: Russell King 
Cc: Richard Cochran 
Cc: Nicolas Pitre 
Cc: David Riley 
Cc: Colin Cross 
Cc: Mark Brown 
Cc: H. Peter Anvin 
Cc: Paul E. McKenney 
Link: https://lkml.kernel.org/r/20181031182252.879109557@linutronix.de

time: Remove useless filenames in top level comments

2018-11-23T10:51:20+00:00

Remove the pointless filenames in the top level comments. They have no
value at all and just occupy space. While at it tidy up some of the
comments and remove a stale one.

Signed-off-by: Thomas Gleixner 
Acked-by: Nicolas Pitre 
Acked-by: Kees Cook 
Acked-by: Ingo Molnar 
Acked-by: John Stultz 
Acked-by: Corey Minyard 
Cc: Peter Zijlstra 
Cc: Kate Stewart 
Cc: Philippe Ombredanne 
Cc: Peter Anvin 
Cc: Russell King 
Cc: Richard Cochran 
Cc: "Paul E. McKenney" 
Cc: David Riley 
Cc: Colin Cross 
Cc: Mark Brown 
Link: https://lkml.kernel.org/r/20181031182252.794898238@linutronix.de

vfs: do bulk POLL* -> EPOLL* replacement

2018-02-11T22:34:03+00:00

This is the mindless scripted replacement of kernel use of POLL*
variables as described by Al, done by this script:

    for V in IN OUT PRI ERR RDNORM RDBAND WRNORM WRBAND HUP RDHUP NVAL MSG; do
        L=`git grep -l -w POLL$V | grep -v '^t' | grep -v /um/ | grep -v '^sa' | grep -v '/poll.h$'|grep -v '^D'`
        for f in $L; do sed -i "-es/^\([^\"]*\)\(\\)/\\1E\\2/" $f; done
    done

with de-mangling cleanups yet to come.

NOTE! On almost all architectures, the EPOLL* constants have the same
values as the POLL* constants do.  But they keyword here is "almost".
For various bad reasons they aren't the same, and epoll() doesn't
actually work quite correctly in some cases due to this on Sparc et al.

The next patch from Al will sort out the final differences, and we
should be all done.

Scripted-by: Al Viro 
Signed-off-by: Linus Torvalds

Merge branch 'misc.poll' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

2018-01-31T01:58:07+00:00

Pull poll annotations from Al Viro:
 "This introduces a __bitwise type for POLL### bitmap, and propagates
  the annotations through the tree. Most of that stuff is as simple as
  'make ->poll() instances return __poll_t and do the same to local
  variables used to hold the future return value'.

  Some of the obvious brainos found in process are fixed (e.g. POLLIN
  misspelled as POLL_IN). At that point the amount of sparse warnings is
  low and most of them are for genuine bugs - e.g. ->poll() instance
  deciding to return -EINVAL instead of a bitmap. I hadn't touched those
  in this series - it's large enough as it is.

  Another problem it has caught was eventpoll() ABI mess; select.c and
  eventpoll.c assumed that corresponding POLL### and EPOLL### were
  equal. That's true for some, but not all of them - EPOLL### are
  arch-independent, but POLL### are not.

  The last commit in this series separates userland POLL### values from
  the (now arch-independent) kernel-side ones, converting between them
  in the few places where they are copied to/from userland. AFAICS, this
  is the least disruptive fix preserving poll(2) ABI and making epoll()
  work on all architectures.

  As it is, it's simply broken on sparc - try to give it EPOLLWRNORM and
  it will trigger only on what would've triggered EPOLLWRBAND on other
  architectures. EPOLLWRBAND and EPOLLRDHUP, OTOH, are never triggered
  at all on sparc. With this patch they should work consistently on all
  architectures"

* 'misc.poll' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs: (37 commits)
  make kernel-side POLL... arch-independent
  eventpoll: no need to mask the result of epi_item_poll() again
  eventpoll: constify struct epoll_event pointers
  debugging printk in sg_poll() uses %x to print POLL... bitmap
  annotate poll(2) guts
  9p: untangle ->poll() mess
  ->si_band gets POLL... bitmap stored into a user-visible long field
  ring_buffer_poll_wait() return value used as return value of ->poll()
  the rest of drivers/*: annotate ->poll() instances
  media: annotate ->poll() instances
  fs: annotate ->poll() instances
  ipc, kernel, mm: annotate ->poll() instances
  net: annotate ->poll() instances
  apparmor: annotate ->poll() instances
  tomoyo: annotate ->poll() instances
  sound: annotate ->poll() instances
  acpi: annotate ->poll() instances
  crypto: annotate ->poll() instances
  block: annotate ->poll() instances
  x86: annotate ->poll() instances
  ...

posix-timers: Prevent UB from shifting negative signed value

2018-01-04T13:57:10+00:00

Shifting a negative signed number is undefined behavior. Looking at the
macros MAKE_PROCESS_CPUCLOCK and FD_TO_CLOCKID, it seems that the
subexpression:

(~(clockid_t) (pid) << 3)

where clockid_t resolves to a signed int, which once negated, is
undefined behavior to shift the value of if the results thus far are
negative.

It was further suggested to make these macros into inline functions.

Suggested-by: Thomas Gleixner 
Signed-off-by: Nick Desaulniers 
Signed-off-by: Thomas Gleixner 
Cc: Dimitri Sivanich 
Cc: Frederic Weisbecker 
Cc: Al Viro 
Cc: linux-kselftest@vger.kernel.org
Cc: Shuah Khan 
Cc: Deepa Dinamani 
Link: https://lkml.kernel.org/r/1514517100-18051-1-git-send-email-nick.desaulniers@gmail.com

ipc, kernel, mm: annotate ->poll() instances

2017-11-27T21:20:05+00:00

Signed-off-by: Al Viro

posix-timers: Move posix-timer internals to core

2017-06-04T13:40:23+00:00

None of these declarations is required outside of kernel/time. Move them to
an internal header.

Signed-off-by: Thomas Gleixner 
Cc: Peter Zijlstra 
Cc: John Stultz 
Cc: Christoph Hellwig 
Link: http://lkml.kernel.org/r/20170530211656.394803853@linutronix.de

posix-clocks: Remove interval timer facility and mmap/fasync callbacks

2017-06-04T13:40:22+00:00

The only user of this facility is ptp_clock, which does not implement any of
those functions.

Remove them to prevent accidental users. Especially the interval timer
interfaces are now more or less impossible to implement because the
necessary infrastructure has been confined to the core code. Aside of that
it's really complex to make these callbacks implemented according to spec
as the alarm timer implementation demonstrates. If at all then a nanosleep
callback might be a reasonable extension. For now keep just what ptp_clock
needs.

Signed-off-by: Thomas Gleixner 
Cc: Peter Zijlstra 
Cc: John Stultz 
Link: http://lkml.kernel.org/r/20170530211656.145036286@linutronix.de