linux-toradex.git/kernel/trace/trace_event_perf.c, branch tegra-11.2.6

perf, trace: Fix module leak

2010-09-09T18:38:51+00:00

Commit 1c024eca (perf, trace: Optimize tracepoints by using
per-tracepoint-per-cpu hlist to track events) caused a module
refcount leak.

Reported-And-Tested-by: Avi Kivity 
Signed-off-by: Peter Zijlstra 
LKML-Reference: <4C7E1F12.8030304@cn.fujitsu.com>
Signed-off-by: Ingo Molnar

perf: Use tracepoint_synchronize_unregister() to flush any pending tracepoint call

2010-08-01T23:30:56+00:00

We use synchronize_sched() to ensure a tracepoint won't be called
while/after we release the perf buffers it references.

But the tracepoint API has its own API for that:
tracepoint_synchronize_unregister(). Use it instead as it's
self-explanatory and eases maintainance.

Signed-off-by: Frederic Weisbecker 
Cc: Ingo Molnar 
Cc: Peter Zijlstra 
Cc: Arnaldo Carvalho de Melo 
Cc: Mathieu Desnoyers 
Cc: Steven Rostedt 
Cc: Li Zefan

tracing: Use class->reg() for all registering of events

2010-06-29T01:13:14+00:00

Because kprobes and syscalls need special processing to register
events, the class->reg() method was created to handle the differences.

But instead of creating a default ->reg for perf and ftrace events,
the code was scattered with:

	if (class->reg)
		class->reg();
	else
		default_reg();

This is messy and can also lead to bugs.

This patch cleans up this code and creates a default reg() entry for
the events allowing for the code to directly call the class->reg()
without the condition.

Reported-by: Peter Zijlstra 
Acked-by: Peter Zijlstra 
Signed-off-by: Steven Rostedt

Merge branch 'linus' into perf/core

2010-06-28T20:33:24+00:00

Reason: Further changes conflict with upstream fixes

Signed-off-by: Thomas Gleixner

perf/tracing: Fix regression of perf losing kprobe events

2010-06-11T00:56:54+00:00

With the addition of the code to shrink the kernel tracepoint
infrastructure, we lost kprobes being traced by perf. The reason
is that I tested if the "tp_event->class->perf_probe" existed before
enabling it. This prevents "ftrace only" events (like the function
trace events) from being enabled by perf.

Unfortunately, kprobe events do not use perf_probe. This causes
kprobes to be missed by perf. To fix this, we add the test to
see if "tp_event->class->reg" exists as well as perf_probe.

Normal trace events have only "perf_probe" but no "reg" function,
and kprobes and syscalls have the "reg" but no "perf_probe".
The ftrace unique events do not have either, so this is a valid
test. If a kprobe or syscall is not to be probed by perf, the
"reg" function is called anyway, and will return a failure and
prevent perf from probing it.

Reported-by: Srikar Dronamraju 
Tested-by: Srikar Dronamraju 
Acked-by: Peter Zijlstra 
Signed-off-by: Steven Rostedt

Merge branch 'perf/core' of git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing into perf/core

2010-06-09T16:55:57+00:00

perf: Drop the skip argument from perf_arch_fetch_regs_caller

2010-06-08T21:31:27+00:00

Drop this argument now that we always want to rewind only to the
state of the first caller.
It means frame pointers are not necessary anymore to reliably get
the source of an event. But this also means we need this helper
to be a macro now, as an inline function is not an option since
we need to know when to provide a default implentation.

Signed-off-by: Frederic Weisbecker 
Signed-off-by: Paul Mackerras 
Cc: David Miller 
Cc: Ingo Molnar 
Cc: Peter Zijlstra 
Cc: Arnaldo Carvalho de Melo

perf_events, trace: Fix perf_trace_destroy(), mutex went missing

2010-05-31T06:46:09+00:00

Steve spotted I forgot to do the destroy under event_mutex.

Reported-by: Steven Rostedt 
Signed-off-by: Peter Zijlstra 
LKML-Reference: <1274451913.1674.1707.camel@laptop>
Signed-off-by: Ingo Molnar

perf_events, trace: Fix probe unregister race

2010-05-31T06:46:09+00:00

tracepoint_probe_unregister() does not synchronize against the probe
callbacks, so do that explicitly. This properly serializes the callbacks
and the free of the data used therein.

Also, use this_cpu_ptr() where possible.

Acked-by: Frederic Weisbecker 
Signed-off-by: Peter Zijlstra 
LKML-Reference: <1274438476.1674.1702.camel@laptop>
Signed-off-by: Ingo Molnar

perf, trace: Fix !x86 build bug

2010-05-25T09:28:49+00:00

Patch b7e2ecef92 (perf, trace: Optimize tracepoints by removing
IRQ-disable from perf/tracepoint interaction) made the
unfortunate mistake of assuming the world is x86 only, correct
this.

The problem was that perf_fetch_caller_regs() did
local_save_flags() into regs->flags, and I re-used that to
remove another local_save_flags(), forgetting !x86 doesn't have
regs->flags.

Do the reverse, remove the local_save_flags() from
perf_fetch_caller_regs() and let the ftrace site do the
local_save_flags() instead.

Signed-off-by: Peter Zijlstra 
Acked-by: Paul Mackerras 
Cc: acme@redhat.com
Cc: efault@gmx.de
Cc: fweisbec@gmail.com
Cc: rostedt@goodmis.org
LKML-Reference: <1274778175.5882.623.camel@twins>
Signed-off-by: Ingo Molnar